multipathd: fix __delayed_reconfig logic
v3 cover multipathd: fix __delayed_reconfig logic
--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel
PATCH v3 11/12 multipathd: make startup / shutdown messages less noisy
From: Martin Wilck <[email protected]>
These messages are noisy in the system log without being actually helpful. Print the version number on startup.
--- multipathd/main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
multipathd/main.c +4 -4
@@ -37,6 +37,7 @@/* * libmultipath */ +#include "version.h" #include "parser.h" #include "vector.h" #include "config.h"
@@ -2566,7 +2567,6 @@ checkerloop (void *ap)rcu_register_thread ();mlockall (MCL_CURRENT |MCL_FUTURE ); vecs = (struct vectors *)ap; -condlog (2 ,"path checkers start up" );/* Tweak start time for initial path check */ get_monotonic_time (&last_time);
@@ -3247,8 +3247,8 @@ child (__attribute__((unused)) void *param)post_config_state (DAEMON_START ); -condlog (2 ,"--------start up--------" ); -condlog (2 ,"read " DEFAULT_CONFIGFILE ); +condlog (2 ,"multipathd v%d.%d.%d: start up" ,MULTIPATH_VERSION (VERSION_CODE )); +condlog (3 ,"read " DEFAULT_CONFIGFILE );if (verbosity) libmp_verbosity = verbosity;
@@ -3441,7 +3441,7 @@ child (__attribute__((unused)) void *param) exit_code =0 ; failed: -condlog (2 ,"--------shut down-------" ); +condlog (2 ,"multipathd: shut down" );/* All cleanup is done in the cleanup_child() exit handler */ return sd_notify_exit (exit_code); }
Signature · 6 lines
2.35.1 -- dm-devel mailing list [email protected] https://listman.redhat.com/mailman/listinfo/dm-devel
Re: [dm-devel] [PATCH v3 11/12] multipathd: make startup / shutdown messages less noisy
Quoted 6 lines · On Thu, Mar 24, 2022 at 10:19:26PM +0100, [email protected] wrote:
From: Martin Wilck <[email protected]>
These messages are noisy in the system log without being actually helpful. Print the version number on startup.
Signed-off-by Martin Wilck <[email protected]>
Quoted 46 lines
--- multipathd/main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)multipathd/main.c +4
-4@@ -37,6 +37,7 @@/* * libmultipath */ +#include "version.h" #include "parser.h" #include "vector.h" #include "config.h" @@ -2566,7 +2567,6 @@ checkerloop (void *ap)rcu_register_thread ();mlockall (MCL_CURRENT |MCL_FUTURE ); vecs = (struct vectors *)ap; -condlog (2 ,"path checkers start up" );/* Tweak start time for initial path check */ get_monotonic_time (&last_time);@@ -3247,8 +3247,8 @@ child (__attribute__((unused)) void *param)post_config_state (DAEMON_START ); -condlog (2 ,"--------start up--------" ); -condlog (2 ,"read " DEFAULT_CONFIGFILE ); +condlog (2 ,"multipathd v%d.%d.%d: start up" ,MULTIPATH_VERSION (VERSION_CODE )); +condlog (3 ,"read " DEFAULT_CONFIGFILE );if (verbosity) libmp_verbosity = verbosity;@@ -3441,7 +3441,7 @@ child (__attribute__((unused)) void *param) exit_code =0 ; failed: -condlog (2 ,"--------shut down-------" ); +condlog (2 ,"multipathd: shut down" );/* All cleanup is done in the cleanup_child() exit handler */ return sd_notify_exit (exit_code); }Signature · 1 line
2.35.1
--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel
PATCH v3 12/12 multipathd: decrease verbosity of handle_signal()
In reply to [email protected]From: Martin Wilck <[email protected]>
The "reset log" message isn't very important, and the others will be followed by more meaningful messages when multipathd actually exits, or reconfigures itself.
--- multipathd/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
multipathd/main.c +3 -3
@@ -2927,18 +2927,18 @@ void handle_signals(bool nonfatal) {if (exit_sig) { -condlog (2 ,"exit (signal)" ); +condlog (3 ,"exit (signal)" ); exit_sig =0 ;exit_daemon (); }if (!nonfatal)return ;if (reconfig_sig) { -condlog (2 ,"reconfigure (signal)" ); +condlog (3 ,"reconfigure (signal)" );schedule_reconfigure (FORCE_RELOAD_WEAK ); }if (log_reset_sig) { -condlog (2 ,"reset log (signal)" ); +condlog (3 ,"reset log (signal)" );if (logsink ==LOGSINK_SYSLOG )log_thread_reset (); }
Signature · 6 lines
2.35.1 -- dm-devel mailing list [email protected] https://listman.redhat.com/mailman/listinfo/dm-devel
Re: [dm-devel] [PATCH v3 12/12] multipathd: decrease verbosity of handle_signal()
Quoted 7 lines · On Thu, Mar 24, 2022 at 10:19:27PM +0100, [email protected] wrote:
From: Martin Wilck <[email protected]>
The "reset log" message isn't very important, and the others will be followed by more meaningful messages when multipathd actually exits, or reconfigures itself.
Signed-off-by Martin Wilck <[email protected]>
Quoted 32 lines
--- multipathd/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)multipathd/main.c +3
-3@@ -2927,18 +2927,18 @@ void handle_signals(bool nonfatal) {if (exit_sig) { -condlog (2 ,"exit (signal)" ); +condlog (3 ,"exit (signal)" ); exit_sig =0 ;exit_daemon (); }if (!nonfatal)return ;if (reconfig_sig) { -condlog (2 ,"reconfigure (signal)" ); +condlog (3 ,"reconfigure (signal)" );schedule_reconfigure (FORCE_RELOAD_WEAK ); }if (log_reset_sig) { -condlog (2 ,"reset log (signal)" ); +condlog (3 ,"reset log (signal)" );if (logsink ==LOGSINK_SYSLOG )log_thread_reset (); }Signature · 1 line
2.35.1
--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel