mm-thp-clearpagedoublemap-in-first-page_add_file_rmap.patch removed from -mm tree
The patch titled
Subject: mm/thp: ClearPageDoubleMap in first page_add_file_rmap()
has been removed from the -mm tree. Its filename was
mm-thp-clearpagedoublemap-in-first-page_add_file_rmap.patch
This patch was dropped because it was merged into mainline or a subsystem tree
------------------------------------------------------
From: Hugh Dickins <[email protected]>
Subject: mm/thp: ClearPageDoubleMap in first page_add_file_rmap()
PageDoubleMap is maintained differently for anon and for shmem+file: the shmem+file one was never cleared, because a safe place to do so could not be found; so it would blight future use of the cached hugepage until evicted.
See https://lore.kernel.org/lkml/[email protected]/
But page_add_file_rmap() does provide a safe place to do so (though later than one might wish): allowing testing to return to an initial state without a damaging drop_caches.
---
mm/rmap.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
mm/rmap.c renamed from mm/rmap.c~mm-thp-clearpagedoublemap-in-first-page_add_file_rmap +11 -0
@@ -1252,6 +1252,17 @@ void page_add_file_rmap(struct page *pag }if (!atomic_inc_and_test (compound_mapcount_ptr (page))) goto out; + +/* +* It is racy to ClearPageDoubleMap in page_remove_file_rmap(); +* but page lock is held by all page_add_file_rmap() compound +* callers, and SetPageDoubleMap below warns if !PageLocked: +* so here is a place that DoubleMap can be safely cleared. +*/ +VM_WARN_ON_ONCE (!PageLocked (page)); +if (nr == nr_pages &&PageDoubleMap (page)) +ClearPageDoubleMap (page); +if (PageSwapBacked (page))__mod_lruvec_page_state (page,NR_SHMEM_PMDMAPPED , nr_pages);
_
Patches currently in -mm which might be from [email protected] are
mm-delete-__clearpagewaiters.patch mm-filemap_unaccount_folio-large-skip-mapcount-fixup.patch mm-thp-fix-nr_file_mapped-accounting-in-page__file_rmap.patch mm-warn-on-deleting-redirtied-only-if-accounted.patch mm-unmap_mapping_range_tree-with-i_mmap_rwsem-shared.patch