Skip to contentSkip to conversation

fs-pipe-local-vars-has-to-match-types-of-proper-pipe_inode_info-fields.patch removed from -mm tree

merged Andrew Morton 1 participant 1 message Mar 25, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The patch titled
Subject: fs/pipe.c: local vars have to match types of proper pipe_inode_info fields
has been removed from the -mm tree. Its filename was
fs-pipe-local-vars-has-to-match-types-of-proper-pipe_inode_info-fields.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Andrei Vagin <[email protected]>
Subject: fs/pipe.c: local vars have to match types of proper pipe_inode_info fields

head, tail, ring_size are declared as unsigned int, so all local variables that operate with these fields have to be unsigned to avoid signed integer overflow.

Right now, it isn't an issue because the maximum pipe size is limited by 1U<<31.

---

 fs/pipe.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/pipe.c renamed from fs/pipe.c~fs-pipe-local-vars-has-to-match-types-of-proper-pipe_inode_info-fields +2 -2
@@ -607,7 +607,7 @@ out:
 static long pipe_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 {
 	struct pipe_inode_info *pipe = filp->private_data;
-	int count, head, tail, mask;
+	unsigned int count, head, tail, mask;
 
 	switch (cmd) {
 	case FIONREAD:
@@ -829,7 +829,7 @@ out_free_uid:
 
 void free_pipe_info(struct pipe_inode_info *pipe)
 {
-	int i;
+	unsigned int i;
 
 #ifdef CONFIG_WATCH_QUEUE
 	if (pipe->watch_queue)

_

Patches currently in -mm which might be from [email protected] are