Skip to contentSkip to conversation

amdgpu/pm: Enable sysfs node for pp_dpm_vclk for NAVI12

PATCH In review Marko Zekovic 2 participants 2 messages Mar 25, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 amdgpu/pm: Enable sysfs node for pp_dpm_vclk for NAVI12

SMI clock measure API is failing, because sysfs node for pp_dpm_vclk is not existing
Bug:
https://ontrack-internal.amd.com/browse/SWDEV-327254

---
 drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/pm/amdgpu_pm.c +1 -1
index 5cd67ddf84956..095cf57d73de4 100644
@@ -1999,7 +1999,7 @@ static int default_attr_update(struct amdgpu_device *adev, struct amdgpu_device_
 		if (asic_type < CHIP_VEGA12)
 			*states = ATTR_STATE_UNSUPPORTED;
 	} else if (DEVICE_ATTR_IS(pp_dpm_vclk)) {
-		if (!(asic_type == CHIP_VANGOGH || asic_type == CHIP_SIENNA_CICHLID))
+		if (!(asic_type == CHIP_VANGOGH || asic_type == CHIP_SIENNA_CICHLID || asic_type == CHIP_NAVI12))
 			*states = ATTR_STATE_UNSUPPORTED;
 	} else if (DEVICE_ATTR_IS(pp_dpm_dclk)) {
 		if (!(asic_type == CHIP_VANGOGH || asic_type == CHIP_SIENNA_CICHLID))
Signature · 1 line
2.24.1.windows.2
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Marko Zekovic

SMI clock measure API is failing, because sysfs node for pp_dpm_vclk is not existing
Bug:
https://ontrack-internal.amd.com/browse/SWDEV-327254

Please drop internal bug tickets. With that fixed, assuming vclk dpm node is actually supported on navi12,

Quoted 22 lines
---
 drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/pm/amdgpu_pm.c +1 -2
index 5cd67ddf84956..095cf57d73de4 100644
@@ -1999,7 +1999,7 @@ static int default_attr_update(struct amdgpu_device *adev, struct amdgpu_device_
                if (asic_type < CHIP_VEGA12)
                        *states = ATTR_STATE_UNSUPPORTED;
        } else if (DEVICE_ATTR_IS(pp_dpm_vclk)) {
-               if (!(asic_type == CHIP_VANGOGH || asic_type == CHIP_SIENNA_CICHLID))
+               if (!(asic_type == CHIP_VANGOGH || asic_type == CHIP_SIENNA_CICHLID || asic_type == CHIP_NAVI12))
                        *states = ATTR_STATE_UNSUPPORTED;
        } else if (DEVICE_ATTR_IS(pp_dpm_dclk)) {
                if (!(asic_type == CHIP_VANGOGH || asic_type == CHIP_SIENNA_CICHLID))
--

2.24.1.windows.2