Skip to contentSkip to conversation

docs: gpu: i915.rst: Update DRRS functions names

PATCH In review José Roberto de Souza 5 participants 5 messages Mar 25, 2022 – Mar 27, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 docs: gpu: i915.rst: Update DRRS functions names

intel_drrs_enable and intel_drrs_disable where renamed to intel_drrs_activate and intel_drrs_deactivate in commit 54903c7a6b40 ("drm/i915: s/enable/active/ for DRRS").

---
 Documentation/gpu/i915.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/gpu/i915.rst +2 -2
index bcaefc952764e..ab596b0a9f259 100644
@@ -187,10 +187,10 @@ Display Refresh Rate Switching (DRRS)
    :doc: Display Refresh Rate Switching (DRRS)
 
 .. kernel-doc:: drivers/gpu/drm/i915/display/intel_drrs.c
-   :functions: intel_drrs_enable
+   :functions: intel_drrs_activate
 
 .. kernel-doc:: drivers/gpu/drm/i915/display/intel_drrs.c
-   :functions: intel_drrs_disable
+   :functions: intel_drrs_deactivate
 
 .. kernel-doc:: drivers/gpu/drm/i915/display/intel_drrs.c
    :functions: intel_drrs_invalidate
Signature · 1 line
2.35.1
#1 lore raw

[Intel-gfx] ✗ Fi.CI.BAT: failure for docs: gpu: i915.rst: Update DRRS functions names

== Series Details ==

== Series Details ==

Series: docs: gpu: i915.rst: Update DRRS functions names
URL : https://patchwork.freedesktop.org/series/101795/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11405 -> Patchwork_22687
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_22687 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_22687, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/index.html

Participating hosts (46 -> 34)
------------------------------

Missing (12): fi-bdw-samus shard-tglu bat-dg1-6 bat-dg2-8 bat-dg2-9 fi-bsw-cyan bat-adlp-6 bat-adlp-4 bat-rpls-1 bat-rpls-2 bat-jsl-2 bat-jsl-1

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_22687:

### IGT changes ###

#### Possible regressions ####

* igt@core_hotunplug@unbind-rebind:
- fi-ilk-650: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-ilk-650/igt@[email protected]
- fi-bsw-nick: NOTRUN -> [INCOMPLETE][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-bsw-nick/igt@[email protected]
- fi-cfl-8109u: NOTRUN -> [INCOMPLETE][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-cfl-8109u/igt@[email protected]

* igt@gem_render_linear_blits@basic:
- fi-elk-e7500: [PASS][4] -> [INCOMPLETE][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11405/fi-elk-e7500/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-elk-e7500/igt@[email protected]

* igt@gem_tiled_blits@basic:
- fi-rkl-guc: [PASS][6] -> [INCOMPLETE][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11405/fi-rkl-guc/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-rkl-guc/igt@[email protected]
- fi-skl-6700k2: [PASS][8] -> [INCOMPLETE][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11405/fi-skl-6700k2/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-skl-6700k2/igt@[email protected]
- fi-kbl-7567u: [PASS][10] -> [INCOMPLETE][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11405/fi-kbl-7567u/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-kbl-7567u/igt@[email protected]
- fi-kbl-8809g: [PASS][12] -> [INCOMPLETE][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11405/fi-kbl-8809g/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-kbl-8809g/igt@[email protected]

#### Warnings ####

* igt@core_hotunplug@unbind-rebind:
- fi-cfl-8700k: [INCOMPLETE][14] ([i915#1982]) -> [INCOMPLETE][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11405/fi-cfl-8700k/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-cfl-8700k/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_22687 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@cs-multi-fence:
- fi-blb-e6850: NOTRUN -> [SKIP][16] ([fdo#109271]) +17 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-blb-e6850/igt@amdgpu/[email protected]

* igt@amdgpu/amd_cs_nop@sync-gfx0:
- fi-glk-j4005: NOTRUN -> [SKIP][17] ([fdo#109271]) +17 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-glk-j4005/igt@amdgpu/[email protected]

* igt@i915_pm_backlight@basic-brightness:
- fi-hsw-4770: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#3012])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-hsw-4770/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: NOTRUN -> [INCOMPLETE][19] ([i915#4785])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-hsw-4770/igt@i915_selftest@[email protected]

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-4770: NOTRUN -> [SKIP][20] ([fdo#109271] / [fdo#111827]) +8 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-hsw-4770/igt@[email protected]

* igt@kms_chamelium@dp-crc-fast:
- fi-bsw-nick: NOTRUN -> [SKIP][21] ([fdo#109271] / [fdo#111827]) +8 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-bsw-nick/igt@[email protected]

* igt@kms_chamelium@dp-hpd-fast:
- fi-ilk-650: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111827]) +8 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-ilk-650/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-cfl-8109u: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111827]) +8 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-cfl-8109u/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-bsw-nick: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#5341])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-bsw-nick/igt@[email protected]
- fi-ilk-650: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#5341])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-ilk-650/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-hsw-4770: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#533])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-hsw-4770/igt@[email protected]
- fi-cfl-8109u: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#533])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-cfl-8109u/igt@[email protected]

* igt@kms_psr@primary_mmap_gtt:
- fi-cfl-8109u: NOTRUN -> [SKIP][28] ([fdo#109271]) +9 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-cfl-8109u/igt@kms_psr@primary_mmap_gtt.html
- fi-hsw-4770: NOTRUN -> [SKIP][29] ([fdo#109271] / [i915#1072]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-hsw-4770/igt@kms_psr@primary_mmap_gtt.html

* igt@kms_psr@primary_page_flip:
- fi-ilk-650: NOTRUN -> [SKIP][30] ([fdo#109271]) +14 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-ilk-650/igt@kms_psr@primary_page_flip.html

* igt@prime_vgem@basic-fence-flip:
- fi-bsw-nick: NOTRUN -> [SKIP][31] ([fdo#109271]) +37 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-bsw-nick/igt@[email protected]

* igt@prime_vgem@basic-userptr:
- fi-hsw-4770: NOTRUN -> [SKIP][32] ([fdo#109271]) +2 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-hsw-4770/igt@[email protected]

* igt@runner@aborted:
- fi-rkl-guc: NOTRUN -> [FAIL][33] ([i915#4312])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-rkl-guc/igt@[email protected]

#### Possible fixes ####

* igt@core_hotunplug@unbind-rebind:
- {fi-ehl-2}: [INCOMPLETE][34] -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11405/fi-ehl-2/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-ehl-2/igt@[email protected]
- fi-glk-j4005: [INCOMPLETE][36] -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11405/fi-glk-j4005/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-glk-j4005/igt@[email protected]

* igt@gem_render_linear_blits@basic:
- fi-ilk-650: [INCOMPLETE][38] -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11405/fi-ilk-650/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-ilk-650/igt@[email protected]

* igt@gem_render_tiled_blits@basic:
- fi-bsw-nick: [INCOMPLETE][40] -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11405/fi-bsw-nick/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-bsw-nick/igt@[email protected]
- fi-cfl-8109u: [INCOMPLETE][42] -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11405/fi-cfl-8109u/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-cfl-8109u/igt@[email protected]

* igt@gem_tiled_blits@basic:
- fi-hsw-4770: [INCOMPLETE][44] -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11405/fi-hsw-4770/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-hsw-4770/igt@[email protected]

* igt@i915_selftest@live@requests:
- fi-blb-e6850: [DMESG-FAIL][46] ([i915#4528]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11405/fi-blb-e6850/igt@i915_selftest@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-blb-e6850/igt@i915_selftest@[email protected]

#### Warnings ####

* igt@runner@aborted:
- fi-bsw-nick: [FAIL][48] ([i915#3428] / [i915#4312]) -> [FAIL][49] ([i915#4312])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11405/fi-bsw-nick/igt@[email protected]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/fi-bsw-nick/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5341]: https://gitlab.freedesktop.org/drm/intel/issues/5341

Build changes
-------------

* Linux: CI_DRM_11405 -> Patchwork_22687

CI-20190529: 20190529
CI_DRM_11405: 631579c25b67cc4a6ee014440ddcac6c72b9bf50 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6393: 1d267ea1b829fa10b31a37ccf6b4a970f032784a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22687: 533f90dcdffc635bbd750dfd7f7e551407e7cb51 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

533f90dcdffc docs: gpu: i915.rst: Update DRRS functions names

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22687/index.html

#2 lore raw
In reply to José Roberto de Souza

Documentation/gpu/i915.rst

Quoted 14 lines · José Roberto de Souza

intel_drrs_enable and intel_drrs_disable where renamed to intel_drrs_activate and intel_drrs_deactivate in commit 54903c7a6b40 ("drm/i915: s/enable/active/ for DRRS").

---
 Documentation/gpu/i915.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/gpu/i915.rst +0 -0
index bcaefc952764e..ab596b0a9f259 100644

Oh that's whete it's coming from.

Documentation/gpu/i915.rst Display Refresh Rate Switching (DRRS) · line 190

Quoted 6 lines
Documentation/gpu/i915.rst +1 -1
@@ -187,10 +187,10 @@ Display Refresh Rate Switching (DRRS)
    :doc: Display Refresh Rate Switching (DRRS)
 
 .. kernel-doc:: drivers/gpu/drm/i915/display/intel_drrs.c
-   :functions: intel_drrs_enable
+   :functions: intel_drrs_activate

Hmm. Can't we just nuke all these explicit references and let the tooling pull in all of it automagically since there's nothing else in that file?

Quoted 9 lines
Documentation/gpu/i915.rst +1 -1
 .. kernel-doc:: drivers/gpu/drm/i915/display/intel_drrs.c
-   :functions: intel_drrs_disable
+   :functions: intel_drrs_deactivate
 
 .. kernel-doc:: drivers/gpu/drm/i915/display/intel_drrs.c
    :functions: intel_drrs_invalidate
Signature · 1 line
2.35.1
Signature · 2 lines
Ville Syrjälä
Intel
maintainer
#3 lore raw
Quoted 21 lines · Ville Syrjälä

Documentation/gpu/i915.rst

Quoted 14 lines · José Roberto de Souza

intel_drrs_enable and intel_drrs_disable where renamed to intel_drrs_activate and intel_drrs_deactivate in commit 54903c7a6b40 ("drm/i915: s/enable/active/ for DRRS").

---
 Documentation/gpu/i915.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Documentation/gpu/i915.rst +0 -0
index bcaefc952764e..ab596b0a9f259 100644

Oh that's whete it's coming from.

Quoted 3 lines
Documentation/gpu/i915.rst +0 -0
@@ -187,10 +187,10 @@ Display Refresh Rate Switching (DRRS)
    :doc: Display Refresh Rate Switching (DRRS)
 
Quoted 7 lines

Documentation/gpu/i915.rst Display Refresh Rate Switching (DRRS) · line 190

Quoted 3 lines
Documentation/gpu/i915.rst +1 -1
 .. kernel-doc:: drivers/gpu/drm/i915/display/intel_drrs.c
-   :functions: intel_drrs_enable
+   :functions: intel_drrs_activate

Hmm. Can't we just nuke all these explicit references and let the tooling pull in all of it automagically since there's nothing else in that file?

Indeed.

.. kernel-doc:: drivers/gpu/drm/i915/display/intel_drrs.c
:doc: Display Refresh Rate Switching (DRRS)

.. kernel-doc:: drivers/gpu/drm/i915/display/intel_drrs.c
:internal:

looks the right thing to do here.

And if the other matters, than sort the functions in intel_drrs.c

Quoted 14 lines
Quoted 10 lines
Documentation/gpu/i915.rst +1 -2
 .. kernel-doc:: drivers/gpu/drm/i915/display/intel_drrs.c
-   :functions: intel_drrs_disable
+   :functions: intel_drrs_deactivate
 
 .. kernel-doc:: drivers/gpu/drm/i915/display/intel_drrs.c
    :functions: intel_drrs_invalidate
--

2.35.1

--
Ville Syrjälä
Intel

#4 lore raw
In reply to José Roberto de Souza
Thank you for the patch! Perhaps something to improve:

Hi "José,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v5.17 next-20220325]
[If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Jos-Roberto-de-Souza/docs-gpu-i915-rst-Update-DRRS-functions-names/20220325-233423
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
reproduce: make htmldocs

If you fix the issue, kindly add following tag as appropriate

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/display/intel_drrs.c:1: warning: 'intel_drrs_activate' not found
>> drivers/gpu/drm/i915/display/intel_drrs.c:1: warning: 'intel_drrs_deactivate' not found

vim +/intel_drrs_activate +1 drivers/gpu/drm/i915/display/intel_drrs.c

a1b63119ee839c8 José Roberto de Souza 2021-08-27 @1 // SPDX-License-Identifier: MIT

a1b63119ee839c8 José Roberto de Souza 2021-08-27  2  /*
a1b63119ee839c8 José Roberto de Souza 2021-08-27  3   * Copyright © 2021 Intel Corporation
a1b63119ee839c8 José Roberto de Souza 2021-08-27  4   */
a1b63119ee839c8 José Roberto de Souza 2021-08-27  5  
Signature · 2 lines
0-DAY CI Kernel Test Service
https://01.org/lkp