f2fs: remove unnecessary f2fs_lock_op in f2fs_new_inode
Jaegeuk Kim
maintainerPATCH 1/1 f2fs: remove unnecessary f2fs_lock_op in f2fs_new_inode
This can be removed, since f2fs_alloc_nid() actually doesn't require to block checkpoint and __f2fs_build_free_nids() is covered by nm_i->nat_tree_lock.
Suggested-by Linus Torvalds <[email protected]>
Signed-off-by Jaegeuk Kim <[email protected]>
--- fs/f2fs/namei.c | 3 --- 1 file changed, 3 deletions(-)
fs/f2fs/namei.c +0 -3
@@ -37,13 +37,10 @@ static struct inode *f2fs_new_inode(struct user_namespace *mnt_userns,if (!inode)return ERR_PTR (-ENOMEM ); -f2fs_lock_op (sbi);if (!f2fs_alloc_nid (sbi, &ino)) { -f2fs_unlock_op (sbi); err = -ENOSPC ; goto fail; } -f2fs_unlock_op (sbi); nid_free = true;
Signature · 8 lines
2.35.1.1021.g381101b075-goog _______________________________________________ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Quoted 5 lines · Jaegeuk Kim
This can be removed, since
f2fs_alloc_nid()actually doesn't require to block checkpoint and__f2fs_build_free_nids()is covered bynm_i->nat_tree_lock.Suggested-by Linus Torvalds <[email protected]>Signed-off-by Jaegeuk Kim <[email protected]>
Looks fine, but still it needs more test to check stability w/ the patch. ;)
Reviewed-by Chao Yu <[email protected]>
Thanks,