Skip to contentSkip to conversation

imx8/ls10xx: Use a sane SYS_MALLOC_F_LEN default

PATCH In review Fabio Estevam 2 participants 2 messages Mar 26, 2022 – Apr 7, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 imx8/ls10xx: Use a sane SYS_MALLOC_F_LEN default

From: Fabio Estevam <[email protected]>

When adding new features to imx8m boards, such as DM clock support, the malloc area can be exhausted.

To avoid such issue, provide a reasonable default for the SYS_MALLOC_F_LEN size.

Quoting Tom Rini:

"This seems to be an area where everyone is either:
- Kicking the value up a bit for themselves
- Having hard to figure out problems booting the platform because it's too small a value until they see someone else picked a larger value.

So lets raise these a bit and get some acks, please."

---
Changes since v2:
- Also bump the default for imx8/layerscape - Tom
- Expand the Cc list - Tom

 Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Kconfig +4 -4
index 9dd9ec7f6dfb..8b346894e581 100644
@@ -232,10 +232,10 @@ config SYS_MALLOC_F_LEN
 	depends on SYS_MALLOC_F
 	default 0x1000 if AM33XX
 	default 0x4000 if SANDBOX
-	default 0x2000 if (ARCH_IMX8 || ARCH_IMX8M || ARCH_MX7 || \
-			   ARCH_MX7ULP || ARCH_MX6 || ARCH_MX5 || \
-			   ARCH_LS1012A || ARCH_LS1021A || ARCH_LS1043A || \
-			   ARCH_LS1046A || ARCH_QEMU || ARCH_SUNXI || ARCH_OWL)
+	default 0x2000 if (ARCH_MX7 || ARCH_MX7ULP || ARCH_MX6 || ARCH_MX5 || \
+			   ARCH_QEMU || ARCH_SUNXI || ARCH_OWL)
+	default 0x10000 if (ARCH_IMX8 || ARCH_IMX8M || ARCH_LS1012A || \
+			    ARCH_LS1021A || ARCH_LS1043A || ARCH_LS1046A)
 	default 0x400
 	help
 	  Before relocation, memory is very limited on many platforms. Still,
Signature · 1 line
2.25.1
#1 lore raw
Quoted 16 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

When adding new features to imx8m boards, such as DM clock support, the malloc area can be exhausted.

To avoid such issue, provide a reasonable default for the SYS_MALLOC_F_LEN size.

Quoting Tom Rini:

"This seems to be an area where everyone is either:
- Kicking the value up a bit for themselves
- Having hard to figure out problems booting the platform because it's too small a value until they see someone else picked a larger value.

Quoted 6 lines

So lets raise these a bit and get some acks, please."

Applied to u-boot/master, thanks!

Signature · 1 line
Tom