Skip to contentSkip to conversation

package/libdill: new package

PATCH Superseded Angelo Compagnucci 3 participants 3 messages Mar 26, 2022 – Jul 28, 2022

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/libdill: new package

Libdill is a C library that makes writing structured concurrent programs easy.

---
v1-v2:
Better configuration options handling:
libdill build can actually be customized only when using configure indeed cmake doesn't offer the same configuration option,

 DEVELOPERS                   |  1 +
 package/Config.in            |  1 +
 package/libdill/Config.in    |  7 +++++++
 package/libdill/libdill.hash |  3 +++
 package/libdill/libdill.mk   | 25 +++++++++++++++++++++++++
 5 files changed, 37 insertions(+)
 create mode 100644 package/libdill/Config.in
 create mode 100644 package/libdill/libdill.hash
 create mode 100644 package/libdill/libdill.mk
DEVELOPERS +1 -0
index 70d71186ed..9410944584 100644
@@ -167,6 +167,7 @@ F:	package/i2c-tools/
 F:	package/jq/
 F:	package/libapparmor/
 F:	package/libb64/
+F:	package/libdill/
 F:	package/mender/
 F:	package/mender-artifact/
 F:	package/mono/
package/Config.in +1 -0
index 0d5d763180..47f84a08dc 100644
@@ -1968,6 +1968,7 @@ menu "Other"
 	source "package/libcrossguid/Config.in"
 	source "package/libcsv/Config.in"
 	source "package/libdaemon/Config.in"
+	source "package/libdill/Config.in"
 	source "package/libeastl/Config.in"
 	source "package/libee/Config.in"
 	source "package/libev/Config.in"
package/libdill/Config.in new file +7 -0
new file mode 100644
index 0000000000..0e6757b809
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBDILL
+	bool "libdill"
+	help
+	  Libdill is a C library that makes writing structured concurrent
+	  programs easy.
+
+	  http://libdill.org
package/libdill/libdill.hash new file +3 -0
new file mode 100644
index 0000000000..4a1fb91a57
@@ -0,0 +1,3 @@
+# sha256 locally computed
+sha256  6df7527e8f1e91f5106c21c5bfeaa69eee470bec476c74585143e3e439864404  libdill-fa01648cf2a8d06e53c965b45eeacfb3ac57bd04.tar.gz
+sha256  3f78d9c42c8919cb6dc63e51de17b9eb40a49d9cdd876ce59e77392721e8c2c6  COPYING
package/libdill/libdill.mk new file +25 -0
new file mode 100644
index 0000000000..8efe1ff356
@@ -0,0 +1,25 @@
+################################################################################
+#
+# libdill
+#
+################################################################################
+
+LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
+LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
+LIBDILL_LICENSE = MIT
+LIBDILL_LICENSE_FILES = COPYING
+LIBDILL_CPE_ID_VENDOR = libdill
+LIBDILL_CPE_ID_PRODUCT = libdill
+LIBDILL_INSTALL_STAGING = YES
+LIBDILL_AUTORECONF = YES
+
+ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
+LIBDILL_CONF_OPTS += --disable-threads
+endif
+
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LIBDILL_DEPENDENCIES = openssl
+LIBDILL_CONF_OPTS += --enable-tls
+endif
+
+$(eval $(autotools-package))
Signature · 6 lines
2.25.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Hello Angelo,

Le 26/03/2022 à 23:07, Angelo Compagnucci a écrit :

Quoted 50 lines

Libdill is a C library that makes writing structured concurrent programs easy.

---
v1-v2:
Better configuration options handling:
libdill build can actually be customized only when using configure indeed cmake doesn't offer the same configuration option,

 DEVELOPERS                   |  1 +
 package/Config.in            |  1 +
 package/libdill/Config.in    |  7 +++++++
 package/libdill/libdill.hash |  3 +++
 package/libdill/libdill.mk   | 25 +++++++++++++++++++++++++
 5 files changed, 37 insertions(+)
 create mode 100644 package/libdill/Config.in
 create mode 100644 package/libdill/libdill.hash
 create mode 100644 package/libdill/libdill.mk
DEVELOPERS +1 -0
index 70d71186ed..9410944584 100644
@@ -167,6 +167,7 @@ F:	package/i2c-tools/
 F:	package/jq/
 F:	package/libapparmor/
 F:	package/libb64/
+F:	package/libdill/
 F:	package/mender/
 F:	package/mender-artifact/
 F:	package/mono/
package/Config.in +1 -0
index 0d5d763180..47f84a08dc 100644
@@ -1968,6 +1968,7 @@ menu "Other"
 	source "package/libcrossguid/Config.in"
 	source "package/libcsv/Config.in"
 	source "package/libdaemon/Config.in"
+	source "package/libdill/Config.in"
 	source "package/libeastl/Config.in"
 	source "package/libee/Config.in"
 	source "package/libev/Config.in"
package/libdill/Config.in new file +0 -0
new file mode 100644
index 0000000000..0e6757b809

package/libdill/Config.in line 1

Quoted 1 line
package/libdill/Config.in new file +1 -0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBDILL

Have you checked with test-pkg ?

Quoted 25 lines
package/libdill/Config.in new file +6 -0
+	bool "libdill"
+	help
+	  Libdill is a C library that makes writing structured concurrent
+	  programs easy.
+
+	  http://libdill.org
package/libdill/libdill.hash new file +3 -0
new file mode 100644
index 0000000000..4a1fb91a57
@@ -0,0 +1,3 @@
+# sha256 locally computed
+sha256  6df7527e8f1e91f5106c21c5bfeaa69eee470bec476c74585143e3e439864404  libdill-fa01648cf2a8d06e53c965b45eeacfb3ac57bd04.tar.gz
+sha256  3f78d9c42c8919cb6dc63e51de17b9eb40a49d9cdd876ce59e77392721e8c2c6  COPYING
package/libdill/libdill.mk new file +4 -0
new file mode 100644
index 0000000000..8efe1ff356
@@ -0,0 +1,25 @@
+################################################################################
+#
+# libdill
+#

package/libdill/libdill.mk line 14

Quoted 10 lines
package/libdill/libdill.mk new file +10 -0
+################################################################################
+
+LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
+LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
+LIBDILL_LICENSE = MIT
+LIBDILL_LICENSE_FILES = COPYING
+LIBDILL_CPE_ID_VENDOR = libdill
+LIBDILL_CPE_ID_PRODUCT = libdill
+LIBDILL_INSTALL_STAGING = YES
+LIBDILL_AUTORECONF = YES

Usually we requires a comment to remember why autoreconf is needed. Here it's directly fetched from github and we need autoreconf to generate the configure script.

package/libdill/libdill.mk line 21

Quoted 7 lines
package/libdill/libdill.mk new file +7 -0
+
+ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
+LIBDILL_CONF_OPTS += --disable-threads
+endif
+
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LIBDILL_DEPENDENCIES = openssl

Openssl is a virtual package. Did you check with other ssl provided such libressl ?

Best regards,
Romain

package/libdill/libdill.mk line 25

Quoted 4 lines
package/libdill/libdill.mk new file +4 -0
+LIBDILL_CONF_OPTS += --enable-tls
+endif
+
+$(eval $(autotools-package))

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw

Il giorno mar 26 lug 2022 alle ore 23:49 Romain Naour <[email protected]> ha scritto:

Quoted 49 lines

Hello Angelo,

Quoted 45 lines · Angelo Compagnucci

Libdill is a C library that makes writing structured concurrent programs easy.

---
v1-v2:
Better configuration options handling:
libdill build can actually be customized only when using configure indeed cmake doesn't offer the same configuration option,

 DEVELOPERS                   |  1 +
 package/Config.in            |  1 +
 package/libdill/Config.in    |  7 +++++++
 package/libdill/libdill.hash |  3 +++
 package/libdill/libdill.mk   | 25 +++++++++++++++++++++++++
 5 files changed, 37 insertions(+)
 create mode 100644 package/libdill/Config.in
 create mode 100644 package/libdill/libdill.hash
 create mode 100644 package/libdill/libdill.mk
DEVELOPERS +1 -0
index 70d71186ed..9410944584 100644
@@ -167,6 +167,7 @@ F:        package/i2c-tools/
 F:   package/jq/
 F:   package/libapparmor/
 F:   package/libb64/
+F:   package/libdill/
 F:   package/mender/
 F:   package/mender-artifact/
 F:   package/mono/
package/Config.in +1 -0
index 0d5d763180..47f84a08dc 100644
@@ -1968,6 +1968,7 @@ menu "Other"
      source "package/libcrossguid/Config.in"
      source "package/libcsv/Config.in"
      source "package/libdaemon/Config.in"
+     source "package/libdill/Config.in"
      source "package/libeastl/Config.in"
      source "package/libee/Config.in"
      source "package/libev/Config.in"
package/libdill/Config.in +0 -0
Quoted 8 lines

package/libdill/Config.in line 1

Quoted 6 lines

new file mode 100644
index 0000000000..0e6757b809

package/libdill/Config.in new file +1 -0
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBDILL

Have you checked with test-pkg ?

Not really, I tested it with some configuration I'm working with. I'll do a run with test-pkg too.

Quoted 32 lines
Quoted 32 lines
package/libdill/Config.in new file +6 -0
+     bool "libdill"
+     help
+       Libdill is a C library that makes writing structured concurrent
+       programs easy.
+
+       http://libdill.org
package/libdill/libdill.hash new file +3 -0
new file mode 100644
index 0000000000..4a1fb91a57
@@ -0,0 +1,3 @@
+# sha256 locally computed
+sha256  6df7527e8f1e91f5106c21c5bfeaa69eee470bec476c74585143e3e439864404  libdill-fa01648cf2a8d06e53c965b45eeacfb3ac57bd04.tar.gz
+sha256  3f78d9c42c8919cb6dc63e51de17b9eb40a49d9cdd876ce59e77392721e8c2c6  COPYING
package/libdill/libdill.mk new file +10 -0
new file mode 100644
index 0000000000..8efe1ff356
@@ -0,0 +1,25 @@
+################################################################################
+#
+# libdill
+#
+################################################################################
+
+LIBDILL_VERSION = fa01648cf2a8d06e53c965b45eeacfb3ac57bd04
+LIBDILL_SITE = $(call github,sustrik,libdill,$(LIBDILL_VERSION))
+LIBDILL_LICENSE = MIT
+LIBDILL_LICENSE_FILES = COPYING
Quoted 8 lines

package/libdill/libdill.mk line 14

Quoted 4 lines
package/libdill/libdill.mk new file +4 -0
+LIBDILL_CPE_ID_VENDOR = libdill
+LIBDILL_CPE_ID_PRODUCT = libdill
+LIBDILL_INSTALL_STAGING = YES
+LIBDILL_AUTORECONF = YES

Usually we requires a comment to remember why autoreconf is needed. Here it's directly fetched from github and we need autoreconf to generate the configure script.

I'll add to V2

Quoted 10 lines

package/libdill/libdill.mk line 21

Quoted 8 lines
package/libdill/libdill.mk new file +7 -0
+
+ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
+LIBDILL_CONF_OPTS += --disable-threads
+endif
+
+ifeq ($(BR2_PACKAGE_OPENSSL),y)
+LIBDILL_DEPENDENCIES = openssl

Openssl is a virtual package. Did you check with other ssl provided such libressl ?

Yes and it work with both open/libressl

Quoted 14 lines

Best regards,
Romain

package/libdill/libdill.mk line 25

Quoted 4 lines
package/libdill/libdill.mk new file +4 -0
+LIBDILL_CONF_OPTS += --enable-tls
+endif
+
+$(eval $(autotools-package))

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Signature · 5 lines
Profile: http://it.linkedin.com/in/compagnucciangelo
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot