Skip to contentSkip to conversation

drm/i915: avoid concurrent writes to aux_inv

PATCH In review [email protected] 3 participants 6 messages Mar 28, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: avoid concurrent writes to aux_inv

From: Fei Yang <[email protected]>

GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because the rq->engine is not necessarily the engine eventually carrying out the request, and potentially the engine could even be a virtual one (with engine->instance being -1). With the MMIO remap feature, we can actually set bit 17 of MI_LRI instruction and let the hardware to figure out the local aux_inv register at runtime to avoid invalidating auxiliary table for all engines.

Bspec: 45728

v2: Invalidate AUX table for indirect context as well.

Cc Stuart Summers <[email protected]>
Cc Tvrtko Ursulin <[email protected]>
---
 drivers/gpu/drm/i915/gt/gen8_engine_cs.c     | 48 ++++----------------
 drivers/gpu/drm/i915/gt/gen8_engine_cs.h     |  4 +-
 drivers/gpu/drm/i915/gt/intel_gpu_commands.h |  1 +
 drivers/gpu/drm/i915/gt/intel_lrc.c          | 12 +++++
 4 files changed, 26 insertions(+), 39 deletions(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +10 -38
index 36148887c699..8178be083b42 100644
@@ -6,7 +6,6 @@
 #include "gen8_engine_cs.h"
 #include "i915_drv.h"
 #include "intel_gpu_commands.h"
-#include "intel_gt_regs.h"
 #include "intel_lrc.h"
 #include "intel_ring.h"
 
@@ -165,33 +164,9 @@ static u32 preparser_disable(bool state)
 	return MI_ARB_CHECK | 1 << 8 | state;
 }
 
-static i915_reg_t aux_inv_reg(const struct intel_engine_cs *engine)
+u32 *gen12_emit_aux_table_inv(const i915_reg_t inv_reg, u32 *cs)
 {
-	static const i915_reg_t vd[] = {
-		GEN12_VD0_AUX_NV,
-		GEN12_VD1_AUX_NV,
-		GEN12_VD2_AUX_NV,
-		GEN12_VD3_AUX_NV,
-	};
-
-	static const i915_reg_t ve[] = {
-		GEN12_VE0_AUX_NV,
-		GEN12_VE1_AUX_NV,
-	};
-
-	if (engine->class == VIDEO_DECODE_CLASS)
-		return vd[engine->instance];
-
-	if (engine->class == VIDEO_ENHANCEMENT_CLASS)
-		return ve[engine->instance];
-
-	GEM_BUG_ON("unknown aux_inv reg\n");
-	return INVALID_MMIO_REG;
-}
-
-static u32 *gen12_emit_aux_table_inv(const i915_reg_t inv_reg, u32 *cs)
-{
-	*cs++ = MI_LOAD_REGISTER_IMM(1);
+	*cs++ = MI_LOAD_REGISTER_IMM(1) | MI_LRI_MMIO_REMAP_EN;
 	*cs++ = i915_mmio_reg_offset(inv_reg);
 	*cs++ = AUX_INV;
 	*cs++ = MI_NOOP;
@@ -293,10 +268,12 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode)
 	if (mode & EMIT_INVALIDATE) {
 		cmd += 2;
 
-		if (!HAS_FLAT_CCS(rq->engine->i915)) {
+		if (!HAS_FLAT_CCS(rq->engine->i915) &&
+		    (rq->engine->class == VIDEO_DECODE_CLASS ||
+		     rq->engine->class == VIDEO_ENHANCEMENT_CLASS)) {
 			aux_inv = rq->engine->mask & ~BIT(BCS0);
 			if (aux_inv)
-				cmd += 2 * hweight32(aux_inv) + 2;
+				cmd += 4;
 		}
 	}
 
@@ -329,15 +306,10 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode)
 	*cs++ = 0; /* value */
 
 	if (aux_inv) { /* hsdes: 1809175790 */
-		struct intel_engine_cs *engine;
-		unsigned int tmp;
-
-		*cs++ = MI_LOAD_REGISTER_IMM(hweight32(aux_inv));
-		for_each_engine_masked(engine, rq->engine->gt, aux_inv, tmp) {
-			*cs++ = i915_mmio_reg_offset(aux_inv_reg(engine));
-			*cs++ = AUX_INV;
-		}
-		*cs++ = MI_NOOP;
+		if (rq->engine->class == VIDEO_DECODE_CLASS)
+			cs = gen12_emit_aux_table_inv(GEN12_VD0_AUX_NV, cs);
+		else
+			cs = gen12_emit_aux_table_inv(GEN12_VE0_AUX_NV, cs);
 	}
 
 	if (mode & EMIT_INVALIDATE)
drivers/gpu/drm/i915/gt/gen8_engine_cs.h +3 -1
index cc6e21d3662a..94f589e73d10 100644
@@ -10,7 +10,7 @@
 #include <linux/types.h>
 
 #include "i915_gem.h" /* GEM_BUG_ON */
-
+#include "intel_gt_regs.h"
 #include "intel_gpu_commands.h"
 
 struct i915_request;
@@ -38,6 +38,8 @@ u32 *gen8_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs);
 u32 *gen11_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs);
 u32 *gen12_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs);
 
+u32 *gen12_emit_aux_table_inv(const i915_reg_t inv_reg, u32 *cs);
+
 static inline u32 *
 __gen8_emit_pipe_control(u32 *batch, u32 flags0, u32 flags1, u32 offset)
 {
drivers/gpu/drm/i915/gt/intel_gpu_commands.h +1 -0
index d112ffd56418..4243be030bc1 100644
@@ -144,6 +144,7 @@
 #define MI_LOAD_REGISTER_IMM(x)	MI_INSTR(0x22, 2*(x)-1)
 /* Gen11+. addr = base + (ctx_restore ? offset & GENMASK(12,2) : offset) */
 #define   MI_LRI_LRM_CS_MMIO		REG_BIT(19)
+#define   MI_LRI_MMIO_REMAP_EN		REG_BIT(17)
 #define   MI_LRI_FORCE_POSTED		(1<<12)
 #define MI_LOAD_REGISTER_IMM_MAX_REGS (126)
 #define MI_STORE_REGISTER_MEM        MI_INSTR(0x24, 1)
drivers/gpu/drm/i915/gt/intel_lrc.c +12 -0
index 07bef7128fdb..7581ef9e2cce 100644
@@ -1208,6 +1208,10 @@ gen12_emit_indirect_ctx_rcs(const struct intel_context *ce, u32 *cs)
 	    IS_DG2_G11(ce->engine->i915))
 		cs = gen8_emit_pipe_control(cs, PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE, 0);
 
+	/* hsdes: 1809175790 */
+	if (!HAS_FLAT_CCS(ce->engine->i915))
+		cs = gen12_emit_aux_table_inv(GEN12_GFX_CCS_AUX_NV, cs);
+
 	return cs;
 }
 
@@ -1225,6 +1229,14 @@ gen12_emit_indirect_ctx_xcs(const struct intel_context *ce, u32 *cs)
 						    PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE,
 						    0);
 
+	/* hsdes: 1809175790 */
+	if (!HAS_FLAT_CCS(ce->engine->i915)) {
+		if (ce->engine->class == VIDEO_DECODE_CLASS)
+			cs = gen12_emit_aux_table_inv(GEN12_VD0_AUX_NV, cs);
+		else if (ce->engine->class == VIDEO_ENHANCEMENT_CLASS)
+			cs = gen12_emit_aux_table_inv(GEN12_VE0_AUX_NV, cs);
+	}
+
 	return cs;
 }
 
Signature · 1 line
2.25.1
#1 lore raw

[Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915: avoid concurrent writes to aux_inv (rev9)

== Series Details ==

== Series Details ==

Series: drm/i915: avoid concurrent writes to aux_inv (rev9)
URL : https://patchwork.freedesktop.org/series/100772/
State : warning

== Summary ==

$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/display/intel_drrs.c:1: warning: 'intel_drrs_enable' not found
./drivers/gpu/drm/i915/display/intel_drrs.c:1: warning: 'intel_drrs_disable' not found
#2 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: avoid concurrent writes to aux_inv (rev9)

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: drm/i915: avoid concurrent writes to aux_inv (rev9)
URL : https://patchwork.freedesktop.org/series/100772/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11407 -> Patchwork_22692
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/index.html

Participating hosts (48 -> 43)
------------------------------

Additional (2): bat-adlm-1 fi-pnv-d510
Missing (7): shard-tglu fi-bsw-cyan bat-adlp-4 fi-kbl-x1275 shard-rkl shard-dg1 fi-bdw-samus

Known issues
------------

Here are the changes found in Patchwork_22692 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@core_hotunplug@unbind-rebind:
- fi-elk-e7500: NOTRUN -> [INCOMPLETE][1] ([i915#5441])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-elk-e7500/igt@[email protected]
- fi-ilk-650: NOTRUN -> [INCOMPLETE][2] ([i915#5441])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-ilk-650/igt@[email protected]
- fi-bsw-n3050: NOTRUN -> [INCOMPLETE][3] ([i915#5441])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-bsw-n3050/igt@[email protected]
- fi-snb-2600: NOTRUN -> [INCOMPLETE][4] ([i915#5441])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-snb-2600/igt@[email protected]
- fi-glk-dsi: [PASS][5] -> [INCOMPLETE][6] ([i915#5441])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-glk-dsi/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-glk-dsi/igt@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-pnv-d510: NOTRUN -> [SKIP][7] ([fdo#109271]) +9 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-pnv-d510/igt@[email protected]

* igt@gem_render_linear_blits@basic:
- fi-snb-2520m: [PASS][8] -> [INCOMPLETE][9] ([i915#5441])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-snb-2520m/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-snb-2520m/igt@[email protected]

* igt@gem_render_tiled_blits@basic:
- fi-cfl-8700k: [PASS][10] -> [INCOMPLETE][11] ([i915#5441])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-cfl-8700k/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-cfl-8700k/igt@[email protected]
- fi-pnv-d510: NOTRUN -> [INCOMPLETE][12] ([i915#5441])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-pnv-d510/igt@[email protected]

* igt@gem_tiled_blits@basic:
- fi-hsw-4770: [PASS][13] -> [INCOMPLETE][14] ([i915#5441])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-hsw-4770/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-hsw-4770/igt@[email protected]
- fi-cfl-8109u: [PASS][15] -> [INCOMPLETE][16] ([i915#5441])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-cfl-8109u/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-cfl-8109u/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- bat-dg1-6: NOTRUN -> [DMESG-FAIL][17] ([i915#4494] / [i915#4957])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/bat-dg1-6/igt@i915_selftest@[email protected]

* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- fi-snb-2600: NOTRUN -> [SKIP][18] ([fdo#109271]) +10 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-snb-2600/igt@[email protected]

* igt@kms_chamelium@dp-edid-read:
- fi-elk-e7500: NOTRUN -> [SKIP][19] ([fdo#109271]) +26 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-elk-e7500/igt@[email protected]

* igt@kms_chamelium@dp-hpd-fast:
- fi-ilk-650: NOTRUN -> [SKIP][20] ([fdo#109271] / [fdo#111827]) +8 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-ilk-650/igt@[email protected]

* igt@kms_chamelium@hdmi-crc-fast:
- fi-bsw-n3050: NOTRUN -> [SKIP][21] ([fdo#109271] / [fdo#111827]) +8 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-bsw-n3050/igt@[email protected]
- fi-snb-2600: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111827]) +8 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-snb-2600/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-snb-2600: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#5341])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-snb-2600/igt@[email protected]
- fi-elk-e7500: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#5341])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-elk-e7500/igt@[email protected]
- fi-ilk-650: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#5341])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-ilk-650/igt@[email protected]

* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-bsw-n3050: NOTRUN -> [SKIP][26] ([fdo#109271]) +22 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-bsw-n3050/igt@[email protected]

* igt@kms_psr@primary_page_flip:
- fi-ilk-650: NOTRUN -> [SKIP][27] ([fdo#109271]) +14 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-ilk-650/igt@kms_psr@primary_page_flip.html

* igt@runner@aborted:
- fi-pnv-d510: NOTRUN -> [FAIL][28] ([i915#2403] / [i915#4312])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-pnv-d510/igt@[email protected]
- fi-glk-dsi: NOTRUN -> [FAIL][29] ([i915#4312] / [k.org#202321])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-glk-dsi/igt@[email protected]
- fi-hsw-4770: NOTRUN -> [FAIL][30] ([i915#4312])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-hsw-4770/igt@[email protected]

#### Possible fixes ####

* igt@core_hotunplug@unbind-rebind:
- {bat-jsl-2}: [INCOMPLETE][31] ([i915#1373]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/bat-jsl-2/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/bat-jsl-2/igt@[email protected]
- bat-dg1-6: [INCOMPLETE][33] ([i915#5441]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/bat-dg1-6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/bat-dg1-6/igt@[email protected]

* igt@gem_render_linear_blits@basic:
- fi-ilk-650: [INCOMPLETE][35] ([i915#5441]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-ilk-650/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-ilk-650/igt@[email protected]
- {fi-tgl-dsi}: [INCOMPLETE][37] ([i915#5441]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-tgl-dsi/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-tgl-dsi/igt@[email protected]

* igt@gem_render_tiled_blits@basic:
- fi-bsw-n3050: [INCOMPLETE][39] ([i915#5441]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-bsw-n3050/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-bsw-n3050/igt@[email protected]
- {bat-rpls-2}: [INCOMPLETE][41] ([i915#5441]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/bat-rpls-2/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/bat-rpls-2/igt@[email protected]

* igt@gem_tiled_blits@basic:
- fi-snb-2600: [INCOMPLETE][43] ([i915#5441]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-snb-2600/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-snb-2600/igt@[email protected]
- fi-elk-e7500: [INCOMPLETE][45] ([i915#5441]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-elk-e7500/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-elk-e7500/igt@[email protected]

* igt@kms_flip@basic-flip-vs-wf_vblank@a-edp1:
- fi-bsw-kefka: [FAIL][47] ([i915#2122]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-bsw-kefka/igt@kms_flip@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-bsw-kefka/igt@kms_flip@[email protected]

#### Warnings ####

* igt@core_hotunplug@unbind-rebind:
- fi-tgl-1115g4: [INCOMPLETE][49] ([i915#1373]) -> [INCOMPLETE][50] ([i915#1373] / [i915#5441])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-tgl-1115g4/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-tgl-1115g4/igt@[email protected]
- fi-kbl-7500u: [INCOMPLETE][51] ([i915#1373]) -> [INCOMPLETE][52] ([i915#1373] / [i915#5441])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-kbl-7500u/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-kbl-7500u/igt@[email protected]
- fi-kbl-7567u: [INCOMPLETE][53] ([i915#1373]) -> [INCOMPLETE][54] ([i915#1373] / [i915#5441])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-kbl-7567u/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-kbl-7567u/igt@[email protected]

* igt@runner@aborted:
- fi-bsw-n3050: [FAIL][55] ([i915#3428] / [i915#4312]) -> [FAIL][56] ([i915#4312])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/fi-bsw-n3050/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/fi-bsw-n3050/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1373]: https://gitlab.freedesktop.org/drm/intel/issues/1373
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4897]: https://gitlab.freedesktop.org/drm/intel/issues/4897
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#5127]: https://gitlab.freedesktop.org/drm/intel/issues/5127
[i915#5341]: https://gitlab.freedesktop.org/drm/intel/issues/5341
[i915#5401]: https://gitlab.freedesktop.org/drm/intel/issues/5401
[i915#5441]: https://gitlab.freedesktop.org/drm/intel/issues/5441
[k.org#202321]: https://bugzilla.kernel.org/show_bug.cgi?id=202321

Build changes
-------------

* Linux: CI_DRM_11407 -> Patchwork_22692

CI-20190529: 20190529
CI_DRM_11407: a2fff1c90d9587c65608497d5bf5781c073bf46a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6393: 1d267ea1b829fa10b31a37ccf6b4a970f032784a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22692: 58aa7ec1c67e400f933c51b67bacc5d010bba6b1 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

58aa7ec1c67e drm/i915: avoid concurrent writes to aux_inv

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/index.html

#3 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: avoid concurrent writes to aux_inv (rev9)

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: drm/i915: avoid concurrent writes to aux_inv (rev9)
URL : https://patchwork.freedesktop.org/series/100772/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11407_full -> Patchwork_22692_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Participating hosts (11 -> 11)
------------------------------

No changes in participating hosts

Known issues
------------

Here are the changes found in Patchwork_22692_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@api_intel_bb@blit-reloc-keep-cache:
- shard-glk: [PASS][1] -> [INCOMPLETE][2] ([i915#5441]) +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-glk1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-glk8/igt@[email protected]

* igt@gem_ctx_persistence@engines-cleanup:
- shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-snb5/igt@[email protected]

* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: NOTRUN -> [SKIP][4] ([i915#4525])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb5/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [PASS][5] -> [FAIL][6] ([i915#2846])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-kbl7/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-kbl7/igt@[email protected]

* igt@gem_exec_fair@basic-none@vecs0:
- shard-kbl: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-kbl3/igt@gem_exec_fair@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_suspend@basic-s3@smem:
- shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([i915#180]) +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-kbl3/igt@gem_exec_suspend@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-kbl6/igt@gem_exec_suspend@[email protected]

* igt@gem_lmem_swapping@heavy-multi:
- shard-skl: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4613])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-skl6/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random:
- shard-apl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4613])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-apl7/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#4613])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-glk4/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][14] ([i915#4613]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb6/igt@[email protected]

* igt@gem_ppgtt@blt-vs-render-ctx0:
- shard-kbl: NOTRUN -> [DMESG-FAIL][15] ([i915#5441])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-kbl7/igt@[email protected]
- shard-tglb: NOTRUN -> [DMESG-FAIL][16] ([i915#5441])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-tglb1/igt@[email protected]

* igt@gem_pwrite@basic-exhaustion:
- shard-glk: NOTRUN -> [WARN][17] ([i915#2658])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-glk9/igt@[email protected]

* igt@gem_pxp@create-regular-buffer:
- shard-iclb: NOTRUN -> [SKIP][18] ([i915#4270])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb5/igt@[email protected]

* igt@gem_pxp@create-regular-context-1:
- shard-kbl: NOTRUN -> [SKIP][19] ([fdo#109271]) +29 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-kbl6/igt@[email protected]

* igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][20] ([i915#768]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb6/igt@[email protected]

* igt@gem_tiled_blits@basic:
- shard-apl: [PASS][21] -> [INCOMPLETE][22] ([i915#5441])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-apl7/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-apl2/igt@[email protected]

* igt@gem_tiled_partial_pwrite_pread@reads:
- shard-kbl: NOTRUN -> [INCOMPLETE][23] ([i915#5441])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-kbl4/igt@[email protected]

* igt@gem_tiled_partial_pwrite_pread@writes-after-reads:
- shard-skl: NOTRUN -> [INCOMPLETE][24] ([i915#5441]) +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-skl7/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-glk: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3323])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-glk9/igt@[email protected]

* igt@gem_userptr_blits@input-checking:
- shard-iclb: NOTRUN -> [DMESG-WARN][26] ([i915#4991])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb5/igt@[email protected]

* igt@gem_userptr_blits@unsync-unmap-cycles:
- shard-iclb: NOTRUN -> [SKIP][27] ([i915#3297]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb6/igt@[email protected]

* igt@gen7_exec_parse@batch-without-end:
- shard-iclb: NOTRUN -> [SKIP][28] ([fdo#109289]) +2 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb5/igt@[email protected]

* igt@gen9_exec_parse@batch-invalid-length:
- shard-snb: NOTRUN -> [SKIP][29] ([fdo#109271]) +67 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-snb5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][30] ([i915#2856]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb6/igt@[email protected]

* igt@i915_pm_rpm@modeset-non-lpsp:
- shard-tglb: NOTRUN -> [SKIP][31] ([fdo#111644] / [i915#1397] / [i915#2411])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-tglb1/igt@[email protected]

* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-iclb: NOTRUN -> [SKIP][32] ([fdo#110892])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb6/igt@[email protected]

* igt@kms_big_fb@4-tiled-32bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][33] ([i915#5286])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-tglb6/igt@[email protected]

* igt@kms_big_fb@4-tiled-8bpp-rotate-0:
- shard-iclb: NOTRUN -> [SKIP][34] ([i915#5286]) +3 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb6/igt@[email protected]

* igt@kms_big_fb@linear-8bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][35] ([fdo#110725] / [fdo#111614])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb5/igt@[email protected]

* igt@kms_big_fb@linear-max-hw-stride-64bpp-rotate-0:
- shard-skl: [PASS][36] -> [INCOMPLETE][37] ([i915#5441]) +2 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-skl4/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-skl4/igt@[email protected]

* igt@kms_big_fb@x-tiled-16bpp-rotate-0:
- shard-kbl: [PASS][38] -> [INCOMPLETE][39] ([i915#5441]) +3 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-kbl1/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-kbl3/igt@[email protected]
- shard-apl: [PASS][40] -> [INCOMPLETE][41] ([i915#1982] / [i915#5441])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-apl3/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-apl6/igt@[email protected]

* igt@kms_big_fb@x-tiled-64bpp-rotate-180:
- shard-tglb: NOTRUN -> [INCOMPLETE][42] ([i915#2828] / [i915#5441])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-tglb6/igt@[email protected]
- shard-snb: NOTRUN -> [INCOMPLETE][43] ([i915#5441])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-snb2/igt@[email protected]

* igt@kms_big_fb@x-tiled-8bpp-rotate-0:
- shard-apl: [PASS][44] -> [INCOMPLETE][45] ([i915#1373] / [i915#5441])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-apl1/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-apl4/igt@[email protected]
- shard-iclb: [PASS][46] -> [INCOMPLETE][47] ([i915#1373] / [i915#5441])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-iclb4/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb8/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#3777])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-apl1/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-iclb: NOTRUN -> [INCOMPLETE][49] ([i915#5441]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb6/igt@[email protected]

* igt@kms_big_fb@y-tiled-32bpp-rotate-90:
- shard-iclb: [PASS][50] -> [INCOMPLETE][51] ([i915#5441]) +2 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-iclb8/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb4/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-tglb: [PASS][52] -> [INCOMPLETE][53] ([i915#5441]) +3 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-tglb6/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-tglb2/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-glk: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#3777])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-glk9/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html

* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-skl: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#3777])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-skl6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-iclb: NOTRUN -> [SKIP][56] ([fdo#110723]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb5/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html

* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#3886]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-glk9/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#3886]) +2 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-apl3/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#3886]) +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-kbl4/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][60] ([fdo#109278] / [i915#3886])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb5/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][61] ([fdo#111615] / [i915#3689])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-tglb6/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-yf_tiled_ccs.html

* igt@kms_cdclk@mode-transition:
- shard-tglb: NOTRUN -> [SKIP][62] ([i915#3742])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-tglb1/igt@[email protected]

* igt@kms_chamelium@dp-hpd-for-each-pipe:
- shard-kbl: NOTRUN -> [SKIP][63] ([fdo#109271] / [fdo#111827]) +3 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-kbl4/igt@[email protected]

* igt@kms_chamelium@dp-mode-timings:
- shard-apl: NOTRUN -> [SKIP][64] ([fdo#109271] / [fdo#111827]) +4 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-apl1/igt@[email protected]

* igt@kms_chamelium@vga-hpd-after-suspend:
- shard-tglb: NOTRUN -> [SKIP][65] ([fdo#109284] / [fdo#111827]) +2 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-tglb6/igt@[email protected]

* igt@kms_chamelium@vga-hpd-enable-disable-mode:
- shard-glk: NOTRUN -> [SKIP][66] ([fdo#109271] / [fdo#111827]) +4 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-glk9/igt@[email protected]

* igt@kms_color@pipe-d-ctm-0-5:
- shard-iclb: NOTRUN -> [SKIP][67] ([fdo#109278] / [i915#1149])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb5/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109284] / [fdo#111827]) +6 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb5/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-degamma:
- shard-snb: NOTRUN -> [SKIP][69] ([fdo#109271] / [fdo#111827]) +2 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-snb5/igt@[email protected]

* igt@kms_color_chamelium@pipe-c-ctm-0-5:
- shard-skl: NOTRUN -> [SKIP][70] ([fdo#109271] / [fdo#111827])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-skl7/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-negative:
- shard-iclb: NOTRUN -> [SKIP][71] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb6/igt@[email protected]

* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> [TIMEOUT][72] ([i915#1319]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-apl3/igt@[email protected]

* igt@kms_content_protection@legacy:
- shard-kbl: NOTRUN -> [TIMEOUT][73] ([i915#1319])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-kbl6/igt@[email protected]

* igt@kms_content_protection@mei_interface:
- shard-tglb: NOTRUN -> [SKIP][74] ([i915#1063])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-tglb6/igt@kms_content_protection@mei_interface.html

* igt@kms_content_protection@srm:
- shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109300] / [fdo#111066])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb6/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-512x512-sliding:
- shard-tglb: NOTRUN -> [SKIP][76] ([fdo#109279] / [i915#3359])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-tglb6/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-d-256x256-left-edge:
- shard-iclb: NOTRUN -> [SKIP][77] ([fdo#109278]) +19 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb5/igt@[email protected]

* igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic:
- shard-iclb: NOTRUN -> [SKIP][78] ([fdo#109274] / [fdo#109278]) +3 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb8/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-blt-4tiled:
- shard-iclb: NOTRUN -> [SKIP][79] ([i915#5287]) +3 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb5/igt@[email protected]

* igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible:
- shard-iclb: NOTRUN -> [SKIP][80] ([fdo#109274])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb6/igt@kms_flip@2x-flip-vs-absolute-wf_vblank-interruptible.html

* igt@kms_flip@2x-plain-flip-ts-check:
- shard-tglb: NOTRUN -> [SKIP][81] ([fdo#109274] / [fdo#111825]) +3 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-tglb1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-pwrite:
- shard-iclb: NOTRUN -> [SKIP][82] ([fdo#109280]) +13 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-pwrite:
- shard-tglb: NOTRUN -> [SKIP][83] ([fdo#109280] / [fdo#111825])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-tglb1/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-pwrite.html

* igt@kms_hdr@static-swap:
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#3555])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-tglb6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][85] ([fdo#108145] / [i915#265])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-kbl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-skl: NOTRUN -> [FAIL][86] ([fdo#108145] / [i915#265])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-skl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-d-alpha-opaque-fb:
- shard-glk: NOTRUN -> [SKIP][87] ([fdo#109271]) +67 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-glk9/igt@[email protected]

* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: NOTRUN -> [SKIP][88] ([i915#3536]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb5/igt@[email protected]

* igt@kms_plane_lowres@pipe-c-tiling-4:
- shard-iclb: NOTRUN -> [SKIP][89] ([i915#5288])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb6/igt@[email protected]

* igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-25@pipe-a-edp-1-downscale-with-pixel-format:
- shard-iclb: NOTRUN -> [SKIP][90] ([i915#5176]) +2 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb5/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-25@pipe-a-edp-1-downscale-with-pixel-format.html

* igt@kms_psr2_sf@cursor-plane-move-continuous-sf:
- shard-skl: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#658])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-skl6/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][92] ([i915#658])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb5/igt@[email protected]

* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-kbl: NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#658])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-kbl6/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-glk: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#658])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-glk9/igt@[email protected]

* igt@kms_psr@psr2_cursor_plane_move:
- shard-tglb: NOTRUN -> [FAIL][95] ([i915#132] / [i915#3467])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-tglb1/igt@kms_psr@psr2_cursor_plane_move.html

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: NOTRUN -> [SKIP][96] ([fdo#109441]) +2 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html

* igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
- shard-skl: [PASS][97] -> [DMESG-WARN][98] ([i915#1982])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-skl10/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-skl10/igt@[email protected]

* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][99] ([i915#180])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-kbl6/igt@[email protected]

* igt@kms_vblank@pipe-d-query-forked-busy:
- shard-skl: NOTRUN -> [SKIP][100] ([fdo#109271]) +33 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-skl7/igt@[email protected]

* igt@kms_vrr@flip-dpms:
- shard-iclb: NOTRUN -> [SKIP][101] ([fdo#109502])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb6/igt@[email protected]

* igt@kms_writeback@writeback-check-output:
- shard-iclb: NOTRUN -> [SKIP][102] ([i915#2437])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb5/igt@[email protected]

* igt@nouveau_crc@pipe-b-ctx-flip-skip-current-frame:
- shard-apl: NOTRUN -> [SKIP][103] ([fdo#109271]) +65 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-apl1/igt@[email protected]

* igt@prime_nv_test@i915_nv_sharing:
- shard-iclb: NOTRUN -> [SKIP][104] ([fdo#109291]) +1 similar issue
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb5/igt@prime_nv_test@i915_nv_sharing.html

* igt@sysfs_clients@create:
- shard-tglb: NOTRUN -> [SKIP][105] ([i915#2994])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-tglb6/igt@[email protected]

* igt@sysfs_clients@fair-3:
- shard-skl: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#2994])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-skl7/igt@[email protected]

* igt@sysfs_clients@sema-50:
- shard-glk: NOTRUN -> [SKIP][107] ([fdo#109271] / [i915#2994]) +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-glk9/igt@[email protected]

* igt@sysfs_clients@split-10:
- shard-kbl: NOTRUN -> [SKIP][108] ([fdo#109271] / [i915#2994])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-kbl6/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [FAIL][109] ([i915#2842]) -> [PASS][110] +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-kbl3/igt@gem_exec_fair@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_render_copy@mixed-tiled-to-yf-tiled-ccs@smem:
- shard-glk: [INCOMPLETE][111] ([i915#5441]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-glk4/igt@gem_render_copy@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-glk9/igt@gem_render_copy@[email protected]

* igt@kms_big_fb@x-tiled-16bpp-rotate-0:
- shard-snb: [INCOMPLETE][113] ([i915#5441]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-snb7/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-snb2/igt@[email protected]

* igt@kms_big_fb@y-tiled-32bpp-rotate-90:
- {shard-tglu}: [INCOMPLETE][115] ([i915#5441]) -> [PASS][116] +2 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-tglu-6/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-tglu-1/igt@[email protected]

* igt@kms_big_fb@y-tiled-8bpp-rotate-0:
- shard-apl: [INCOMPLETE][117] ([i915#5441]) -> [PASS][118] +1 similar issue
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-apl4/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-apl3/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-tglb: [INCOMPLETE][119] ([i915#5441]) -> [PASS][120] +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-tglb6/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-tglb1/igt@[email protected]

* igt@kms_big_fb@yf-tiled-32bpp-rotate-90:
- shard-iclb: [INCOMPLETE][121] ([i915#5441]) -> [PASS][122] +3 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-iclb4/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb5/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180:
- shard-kbl: [INCOMPLETE][123] ([i915#5441]) -> [PASS][124] +1 similar issue
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-kbl7/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-kbl7/igt@[email protected]

* igt@kms_flip@plain-flip-ts-check@a-edp1:
- shard-skl: [FAIL][125] ([i915#2122]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-skl10/igt@kms_flip@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-skl10/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling:
- shard-glk: [FAIL][127] ([i915#4911]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-glk1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html

* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][129] ([fdo#109441]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11407/shard-iclb6/igt@kms_psr@psr2_cursor_blt.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html

* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][131] ([i915#180] / [

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22692/index.html

Reviewed-by on v1 1/1
#4 lore raw
In reply to [email protected]
Quoted 42 lines · On 28/03/2022 04:16, [email protected] wrote:

From: Fei Yang <[email protected]>

GPU hangs have been observed when multiple engines write to the same aux_inv register at the same time. To avoid this each engine should only invalidate its own auxiliary table. The function gen12_emit_flush_xcs() currently invalidate the auxiliary table for all engines because the rq->engine is not necessarily the engine eventually carrying out the request, and potentially the engine could even be a virtual one (with engine->instance being -1). With the MMIO remap feature, we can actually set bit 17 of MI_LRI instruction and let the hardware to figure out the local aux_inv register at runtime to avoid invalidating auxiliary table for all engines.

Bspec: 45728

v2: Invalidate AUX table for indirect context as well.

Cc Stuart Summers <[email protected]>
Cc Tvrtko Ursulin <[email protected]>
---
  drivers/gpu/drm/i915/gt/gen8_engine_cs.c     | 48 ++++----------------
  drivers/gpu/drm/i915/gt/gen8_engine_cs.h     |  4 +-
  drivers/gpu/drm/i915/gt/intel_gpu_commands.h |  1 +
  drivers/gpu/drm/i915/gt/intel_lrc.c          | 12 +++++
  4 files changed, 26 insertions(+), 39 deletions(-)
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +0 -1
index 36148887c699..8178be083b42 100644
@@ -6,7 +6,6 @@
  #include "gen8_engine_cs.h"
  #include "i915_drv.h"
  #include "intel_gpu_commands.h"
-#include "intel_gt_regs.h"
  #include "intel_lrc.h"
  #include "intel_ring.h"
 

drivers/gpu/drm/i915/gt/gen8_engine_cs.c static u32 preparser_disable(bool state) · line 167

Quoted 5 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +1 -1
@@ -165,33 +164,9 @@ static u32 preparser_disable(bool state)
  	return MI_ARB_CHECK | 1 << 8 | state;
  }
 
-static i915_reg_t aux_inv_reg(const struct intel_engine_cs *engine)
+u32 *gen12_emit_aux_table_inv(const i915_reg_t inv_reg, u32 *cs)

I think all helpers which emit to ring take cs as the first argument so it would be good to make this consistent.

Quoted 52 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +5 -30
  {
-	static const i915_reg_t vd[] = {
-		GEN12_VD0_AUX_NV,
-		GEN12_VD1_AUX_NV,
-		GEN12_VD2_AUX_NV,
-		GEN12_VD3_AUX_NV,
-	};
-
-	static const i915_reg_t ve[] = {
-		GEN12_VE0_AUX_NV,
-		GEN12_VE1_AUX_NV,
-	};
-
-	if (engine->class == VIDEO_DECODE_CLASS)
-		return vd[engine->instance];
-
-	if (engine->class == VIDEO_ENHANCEMENT_CLASS)
-		return ve[engine->instance];
-
-	GEM_BUG_ON("unknown aux_inv reg\n");
-	return INVALID_MMIO_REG;
-}
-
-static u32 *gen12_emit_aux_table_inv(const i915_reg_t inv_reg, u32 *cs)
-{
-	*cs++ = MI_LOAD_REGISTER_IMM(1);
+	*cs++ = MI_LOAD_REGISTER_IMM(1) | MI_LRI_MMIO_REMAP_EN;
  	*cs++ = i915_mmio_reg_offset(inv_reg);
  	*cs++ = AUX_INV;
  	*cs++ = MI_NOOP;
@@ -293,10 +268,12 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode)
  	if (mode & EMIT_INVALIDATE) {
  		cmd += 2;
 
-		if (!HAS_FLAT_CCS(rq->engine->i915)) {
+		if (!HAS_FLAT_CCS(rq->engine->i915) &&
+		    (rq->engine->class == VIDEO_DECODE_CLASS ||
+		     rq->engine->class == VIDEO_ENHANCEMENT_CLASS)) {
  			aux_inv = rq->engine->mask & ~BIT(BCS0);
  			if (aux_inv)
-				cmd += 2 * hweight32(aux_inv) + 2;
+				cmd += 4;
  		}
  	}
 
@@ -329,15 +306,10 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode)
  	*cs++ = 0; /* value */
 
  	if (aux_inv) { /* hsdes: 1809175790 */
-		struct intel_engine_cs *engine;
-		unsigned int tmp;
-

drivers/gpu/drm/i915/gt/gen8_engine_cs.c int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode) · line 312

Quoted 10 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +4 -6
-		*cs++ = MI_LOAD_REGISTER_IMM(hweight32(aux_inv));
-		for_each_engine_masked(engine, rq->engine->gt, aux_inv, tmp) {
-			*cs++ = i915_mmio_reg_offset(aux_inv_reg(engine));
-			*cs++ = AUX_INV;
-		}
-		*cs++ = MI_NOOP;
+		if (rq->engine->class == VIDEO_DECODE_CLASS)
+			cs = gen12_emit_aux_table_inv(GEN12_VD0_AUX_NV, cs);
+		else
+			cs = gen12_emit_aux_table_inv(GEN12_VE0_AUX_NV, cs);

Not sure if, here and below, it would be worth to put register in a local and then have a single function call - up to you.

Quoted 57 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +0 -0
  	}
 
  	if (mode & EMIT_INVALIDATE)
drivers/gpu/drm/i915/gt/gen8_engine_cs.h +3 -1
index cc6e21d3662a..94f589e73d10 100644
@@ -10,7 +10,7 @@
  #include <linux/types.h>
 
  #include "i915_gem.h" /* GEM_BUG_ON */
-
+#include "intel_gt_regs.h"
  #include "intel_gpu_commands.h"
 
  struct i915_request;
@@ -38,6 +38,8 @@ u32 *gen8_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs);
  u32 *gen11_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs);
  u32 *gen12_emit_fini_breadcrumb_rcs(struct i915_request *rq, u32 *cs);
 
+u32 *gen12_emit_aux_table_inv(const i915_reg_t inv_reg, u32 *cs);
+
  static inline u32 *
  __gen8_emit_pipe_control(u32 *batch, u32 flags0, u32 flags1, u32 offset)
  {
drivers/gpu/drm/i915/gt/intel_gpu_commands.h +1 -0
index d112ffd56418..4243be030bc1 100644
@@ -144,6 +144,7 @@
  #define MI_LOAD_REGISTER_IMM(x)	MI_INSTR(0x22, 2*(x)-1)
  /* Gen11+. addr = base + (ctx_restore ? offset & GENMASK(12,2) : offset) */
  #define   MI_LRI_LRM_CS_MMIO		REG_BIT(19)
+#define   MI_LRI_MMIO_REMAP_EN		REG_BIT(17)
  #define   MI_LRI_FORCE_POSTED		(1<<12)
  #define MI_LOAD_REGISTER_IMM_MAX_REGS (126)
  #define MI_STORE_REGISTER_MEM        MI_INSTR(0x24, 1)
drivers/gpu/drm/i915/gt/intel_lrc.c +5 -0
index 07bef7128fdb..7581ef9e2cce 100644
@@ -1208,6 +1208,10 @@ gen12_emit_indirect_ctx_rcs(const struct intel_context *ce, u32 *cs)
  	    IS_DG2_G11(ce->engine->i915))
  		cs = gen8_emit_pipe_control(cs, PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE, 0);
 
+	/* hsdes: 1809175790 */
+	if (!HAS_FLAT_CCS(ce->engine->i915))
+		cs = gen12_emit_aux_table_inv(GEN12_GFX_CCS_AUX_NV, cs);
+
  	return cs;
  }
 
@@ -1225,6 +1229,14 @@ gen12_emit_indirect_ctx_xcs(const struct intel_context *ce, u32 *cs)
  						    PIPE_CONTROL_INSTRUCTION_CACHE_INVALIDATE,
  						    0);
 
+	/* hsdes: 1809175790 */

drivers/gpu/drm/i915/gt/intel_lrc.c gen12_emit_indirect_ctx_xcs(const struct intel_context *ce, u32 *cs) · line 1242

Quoted 10 lines
drivers/gpu/drm/i915/gt/intel_lrc.c +7 -0
+	if (!HAS_FLAT_CCS(ce->engine->i915)) {
+		if (ce->engine->class == VIDEO_DECODE_CLASS)
+			cs = gen12_emit_aux_table_inv(GEN12_VD0_AUX_NV, cs);
+		else if (ce->engine->class == VIDEO_ENHANCEMENT_CLASS)
+			cs = gen12_emit_aux_table_inv(GEN12_VE0_AUX_NV, cs);
+	}
+
  	return cs;
  }
 

Apart from the cs re-order looks good to me.

Regards,

Tvrtko

author
#5 lore raw
Quoted 4 lines

drivers/gpu/drm/i915/gt/gen8_engine_cs.c static u32 preparser_disable(bool state) · line 192

Quoted 2 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +1 -1
+u32 *gen12_emit_aux_table_inv(const i915_reg_t inv_reg, u32 *cs)
-static u32 *gen12_emit_aux_table_inv(const i915_reg_t inv_reg, u32 *cs)

I think all helpers which emit to ring take cs as the first argument so it would be good to make this consistent.

Updated the patch, please review rev10.
This helper function has been there for a long while, I was hesitant to change. But I agree cs should be the first argument. Since I removed the "static" anyway, so might just change the order all together.

Quoted 19 lines
Quoted 7 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +0 -3
@@ -329,15 +306,10 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode)
  	*cs++ = 0; /* value */
 
  	if (aux_inv) { /* hsdes: 1809175790 */
-		struct intel_engine_cs *engine;
-		unsigned int tmp;
-

drivers/gpu/drm/i915/gt/gen8_engine_cs.c int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode) · line 312

Quoted 10 lines
drivers/gpu/drm/i915/gt/gen8_engine_cs.c +4 -6
-		*cs++ = MI_LOAD_REGISTER_IMM(hweight32(aux_inv));
-		for_each_engine_masked(engine, rq->engine->gt, aux_inv, tmp) {
-			*cs++ = i915_mmio_reg_offset(aux_inv_reg(engine));
-			*cs++ = AUX_INV;
-		}
-		*cs++ = MI_NOOP;
+		if (rq->engine->class == VIDEO_DECODE_CLASS)
+			cs = gen12_emit_aux_table_inv(GEN12_VD0_AUX_NV, cs);
+		else
+			cs = gen12_emit_aux_table_inv(GEN12_VE0_AUX_NV, cs);

Not sure if, here and below, it would be worth to put register in a local and then have a single function call - up to you.

I feel it's easier to check the code correctness in the *_rcs/*_xcs functions and leave the helper function as simple as possible.

Quoted 2 lines

Apart from the cs re-order looks good to me.

If no other problems with rev10, would you please help push it upstream? I don't have the commit right, will need to find someone to help take it further.

Thanks,
-Fei

Quoted 1 line