Skip to contentSkip to conversation

eapol: zero entire buffer when creating frame

PATCH Applied James Prestwood 2 participants 2 messages Mar 28, 2022

lore
Share & tools
lore

James Prestwood

author
#0 lore raw

PATCH 1/1 eapol: zero entire buffer when creating frame

Since l_malloc is used the frame contents are not zero'ed automatically which could result in random bytes being present in the frame which were expected to be zero. This poses a problem when calculating the MIC as the crypto operations are done on the entire frame with the expectation of the MIC being zero.

---
 src/eapol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/eapol.c +1 -1
index 9f397d1d..e2c99991 100644
@@ -706,7 +706,7 @@ static struct eapol_key *eapol_create_common(
 	struct eapol_key *out_frame = l_malloc(to_alloc + extra_len +
 						extra_key_len);
 
-	memset(out_frame, 0, to_alloc + extra_len);
+	memset(out_frame, 0, to_alloc + extra_len + extra_key_len);
 
 	out_frame->header.protocol_version = protocol;
 	out_frame->header.packet_type = 0x3;
Signature · 1 line
2.34.1
Applied
#1 lore raw

Hi James,

Quoted 9 lines · James Prestwood

Since l_malloc is used the frame contents are not zero'ed automatically which could result in random bytes being present in the frame which were expected to be zero. This poses a problem when calculating the MIC as the crypto operations are done on the entire frame with the expectation of the MIC being zero.

---
  src/eapol.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Regards,
-Denis