go: Upgrade to 1.18
PATCH v3 1/4 go: Upgrade to 1.18
1.18 is a major release brings in long awaited new features e.g. generics, fuzzing
Detailed list is here [1]
Drop patches to manipulate multiword CC/CXX as go has fixed it differently [2]
Drop cgo portion of patch to hack hash generation logic either we should find a way to not use it or redo it,
in current form its not upstreamable and its
altering core features of go compiler, it can not be maintained as is
Do not emit linkinfo into the actionID
Drop ignoring CVE-2021-29923 its already addressed in go >= 1.17
[1] https://go.dev/doc/go1.18
[2] https://groups.google.com/g/golang-codereviews/c/fUhCbpYG7HE
---
v3: Ignore modinfo from actionID
meta/conf/distro/include/tcmode-default.inc | 2 +-
.../go/{go-1.17.8.inc => go-1.18.inc} | 11 +-
...ow-CC-and-CXX-to-have-multiple-words.patch | 33 ---
...ent-based-hash-generation-less-pedan.patch | 158 ++++++++++++
...not-write-linker-flags-into-buildids.patch | 9 +-
...ldgo.go-do-not-hardcode-host-compile.patch | 2 -
...ent-based-hash-generation-less-pedan.patch | 237 ------------------
...-to-be-overridden-in-the-environment.patch | 10 +-
...4-ld-add-soname-to-shareable-objects.patch | 6 +-
...de-CC-when-building-dist-and-go_boot.patch | 6 +-
...dist-separate-host-and-target-builds.patch | 38 ++-
...d-go-make-GOROOT-precious-by-default.patch | 10 +-
...008-use-GOBUILDMODE-to-set-buildmode.patch | 2 +-
...go-make-sure-CC-and-CXX-are-absolute.patch | 94 -------
...ive_1.17.8.bb => go-binary-native_1.18.bb} | 4 +-
...an_1.17.8.bb => go-cross-canadian_1.18.bb} | 0
.../{go-cross_1.17.8.bb => go-cross_1.18.bb} | 0
...crosssdk_1.17.8.bb => go-crosssdk_1.18.bb} | 0
...{go-native_1.17.8.bb => go-native_1.18.bb} | 0
...o-runtime_1.17.8.bb => go-runtime_1.18.bb} | 0
.../go/{go_1.17.8.bb => go_1.18.bb} | 0
21 files changed, 197 insertions(+), 425 deletions(-)
rename meta/recipes-devtools/go/{go-1.17.8.inc => go-1.18.inc} (58%)
delete mode 100644 meta/recipes-devtools/go/go-1.18/0001-allow-CC-and-CXX-to-have-multiple-words.patch
create mode 100644 meta/recipes-devtools/go/go-1.18/0001-cmd-go-make-content-based-hash-generation-less-pedan.patch
delete mode 100644 meta/recipes-devtools/go/go-1.18/0002-cmd-go-make-content-based-hash-generation-less-pedan.patch
delete mode 100644 meta/recipes-devtools/go/go-1.18/0009-Revert-cmd-go-make-sure-CC-and-CXX-are-absolute.patch
rename meta/recipes-devtools/go/{go-binary-native_1.17.8.bb => go-binary-native_1.18.bb} (83%)
rename meta/recipes-devtools/go/{go-cross-canadian_1.17.8.bb => go-cross-canadian_1.18.bb} (100%)
rename meta/recipes-devtools/go/{go-cross_1.17.8.bb => go-cross_1.18.bb} (100%)
rename meta/recipes-devtools/go/{go-crosssdk_1.17.8.bb => go-crosssdk_1.18.bb} (100%)
rename meta/recipes-devtools/go/{go-native_1.17.8.bb => go-native_1.18.bb} (100%)
rename meta/recipes-devtools/go/{go-runtime_1.17.8.bb => go-runtime_1.18.bb} (100%)
rename meta/recipes-devtools/go/{go_1.17.8.bb => go_1.18.bb} (100%)meta/conf/distro/include/tcmode-default.inc +1 -1
@@ -23,7 +23,7 @@ GDBVERSION ?= "11.%" GLIBCVERSION ?= "2.35" LINUXLIBCVERSION ?= "5.16%" QEMUVERSION ?= "6.2%" -GOVERSION ?= "1.17%" +GOVERSION ?= "1.18%" # This can not use wildcards like 8.0.% since it is also used in mesa to denote # llvm version being used, so always bump it with llvm recipe version bump LLVMVERSION ?= "13.0.1"
meta/recipes-devtools/go/go-1.18.inc renamed from meta/recipes-devtools/go/go-1.17.8.inc +2 -9
@@ -5,21 +5,14 @@ FILESEXTRAPATHS:prepend := "${FILE_DIRNAME}/go-1.18:" LIC_FILES_CHKSUM = "file://LICENSE;md5=5d4950ecb7b26d2c5e4e7b4e0dd74707" SRC_URI += "\ - file://0001-allow-CC-and-CXX-to-have-multiple-words.patch \ - file://0002-cmd-go-make-content-based-hash-generation-less-pedan.patch \ + file://0001-cmd-go-make-content-based-hash-generation-less-pedan.patch \ file://0003-allow-GOTOOLDIR-to-be-overridden-in-the-environment.patch \ file://0004-ld-add-soname-to-shareable-objects.patch \ file://0005-make.bash-override-CC-when-building-dist-and-go_boot.patch \ file://0006-cmd-dist-separate-host-and-target-builds.patch \ file://0007-cmd-go-make-GOROOT-precious-by-default.patch \ file://0008-use-GOBUILDMODE-to-set-buildmode.patch \ - file://0009-Revert-cmd-go-make-sure-CC-and-CXX-are-absolute.patch \ file://0001-exec.go-do-not-write-linker-flags-into-buildids.patch \ file://0001-src-cmd-dist-buildgo.go-do-not-hardcode-host-compile.patch \ " -SRC_URI[main.sha256sum] = "2effcd898140da79a061f3784ca4f8d8b13d811fb2abe9dad2404442dabbdf7a" - -# Upstream don't believe it is a signifiant real world issue and will only -# fix in 1.17 onwards where we can drop this. -# https://github.com/golang/go/issues/30999#issuecomment-910470358 -CVE_CHECK_IGNORE += "CVE-2021-29923" +SRC_URI[main.sha256sum] = "38f423db4cc834883f2b52344282fa7a39fbb93650dc62a11fdf0be6409bdad6"
meta/recipes-devtools/go/go-1.18/0001-allow-CC-and-CXX-to-have-multiple-words.patch deleted +0 -33
@@ -1,33 +0,0 @@ -From 9e3dc44cdfa58d96504d0a789dc82617dd5bef55 Mon Sep 17 00:00:00 2001 -From: Alex Kube <[email protected]> -Date: Wed, 23 Oct 2019 21:01:13 +0430 -Subject: [PATCH 1/9] cmd/go: Allow CC and CXX to have multiple words - -Upstream-Status: Inappropriate [OE specific] - -Adapted to Go 1.13 from patches originally submitted to -the meta/recipes-devtools/go tree by -Matt Madison <[email protected]>. - -Signed-off-by: Alexander J Kube <[email protected]> - ---- - src/cmd/go/internal/envcmd/env.go | 4 ++-- - 1 file changed, 2 insertions(+), 2 deletions(-) - ---- a/src/cmd/go/internal/envcmd/env.go -+++ b/src/cmd/go/internal/envcmd/env.go -@@ -103,11 +103,11 @@ func MkEnv() []cfg.EnvVar { - - cc := cfg.DefaultCC(cfg.Goos, cfg.Goarch) - if env := strings.Fields(cfg.Getenv("CC")); len(env) > 0 { -- cc = env[0] -+ cc = strings.Join(env, " ") - } - cxx := cfg.DefaultCXX(cfg.Goos, cfg.Goarch) - if env := strings.Fields(cfg.Getenv("CXX")); len(env) > 0 { -- cxx = env[0] -+ cxx = strings.Join(env, " ") - } - env = append(env, cfg.EnvVar{Name: "AR", Value: envOr("AR", "ar")}) - env = append(env, cfg.EnvVar{Name: "CC", Value: cc})
meta/recipes-devtools/go/go-1.18/0001-cmd-go-make-content-based-hash-generation-less-pedan.patch new file +158 -0
158 lines not on this page · raw message
meta/recipes-devtools/go/go-1.18/0001-exec.go-do-not-write-linker-flags-into-buildids.patch +2 -7
@@ -14,11 +14,9 @@ Signed-off-by: Alexander Kanavin <[email protected]> src/cmd/go/internal/work/exec.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -diff --git a/src/cmd/go/internal/work/exec.go b/src/cmd/go/internal/work/exec.go -index 696db23..727d40b 100644 --- a/src/cmd/go/internal/work/exec.go +++ b/src/cmd/go/internal/work/exec.go -@@ -1136,7 +1136,7 @@ func (b *Builder) linkActionID(a *Action) cache.ActionID { +@@ -1274,7 +1274,7 @@ func (b *Builder) linkActionID(a *Action } // Toolchain-dependent configuration, shared with b.linkSharedActionID.
@@ -27,7 +25,7 @@ index 696db23..727d40b 100644 // Input files. for _, a1 := range a.Deps { -@@ -1418,7 +1418,7 @@ func (b *Builder) linkSharedActionID(a *Action) cache.ActionID { +@@ -1568,7 +1568,7 @@ func (b *Builder) linkSharedActionID(a * fmt.Fprintf(h, "goos %s goarch %s\n", cfg.Goos, cfg.Goarch) // Toolchain-dependent configuration, shared with b.linkActionID.
@@ -36,6 +34,3 @@ index 696db23..727d40b 100644 // Input files. for _, a1 := range a.Deps { --- -2.17.1 -
meta/recipes-devtools/go/go-1.18/0001-src-cmd-dist-buildgo.go-do-not-hardcode-host-compile.patch +0 -2
@@ -13,8 +13,6 @@ Signed-off-by: Alexander Kanavin <[email protected]> src/cmd/dist/buildgo.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -diff --git a/src/cmd/dist/buildgo.go b/src/cmd/dist/buildgo.go -index caafc13..4eb1c96 100644 --- a/src/cmd/dist/buildgo.go +++ b/src/cmd/dist/buildgo.go @@ -34,8 +34,8 @@ func mkzdefaultcc(dir, file string) {
meta/recipes-devtools/go/go-1.18/0002-cmd-go-make-content-based-hash-generation-less-pedan.patch deleted +0 -237
237 lines not on this page · raw message
meta/recipes-devtools/go/go-1.18/0003-allow-GOTOOLDIR-to-be-overridden-in-the-environment.patch +3 -7
@@ -18,11 +18,9 @@ Signed-off-by: Alexander J Kube <[email protected]> src/cmd/go/internal/cfg/cfg.go | 6 +++++- 2 files changed, 8 insertions(+), 2 deletions(-) -diff --git a/src/cmd/dist/build.go b/src/cmd/dist/build.go -index bec1769..d82f612 100644 --- a/src/cmd/dist/build.go +++ b/src/cmd/dist/build.go -@@ -248,7 +248,9 @@ func xinit() { +@@ -251,7 +251,9 @@ func xinit() { } xatexit(rmworkdir)
@@ -33,11 +31,9 @@ index bec1769..d82f612 100644 } // compilerEnv returns a map from "goos/goarch" to the -diff --git a/src/cmd/go/internal/cfg/cfg.go b/src/cmd/go/internal/cfg/cfg.go -index 57a3c1f..825d8c7 100644 --- a/src/cmd/go/internal/cfg/cfg.go +++ b/src/cmd/go/internal/cfg/cfg.go -@@ -67,7 +67,11 @@ func defaultContext() build.Context { +@@ -76,7 +76,11 @@ func defaultContext() build.Context { // variables. This matches the initialization of ToolDir in // go/build, except for using ctxt.GOROOT rather than // runtime.GOROOT.
@@ -49,4 +45,4 @@ index 57a3c1f..825d8c7 100644 + } } - ctxt.GOPATH = envOr("GOPATH", ctxt.GOPATH) + ctxt.GOPATH = envOr("GOPATH", gopath(ctxt))
meta/recipes-devtools/go/go-1.18/0004-ld-add-soname-to-shareable-objects.patch +3 -3
@@ -19,7 +19,7 @@ Signed-off-by: Alexander J Kube <[email protected]> --- a/src/cmd/link/internal/ld/lib.go +++ b/src/cmd/link/internal/ld/lib.go -@@ -1343,6 +1343,7 @@ func (ctxt *Link) hostlink() { +@@ -1347,6 +1347,7 @@ func (ctxt *Link) hostlink() { argv = append(argv, "-Wl,-z,relro") } argv = append(argv, "-shared")
@@ -27,7 +27,7 @@ Signed-off-by: Alexander J Kube <[email protected]> if ctxt.HeadType == objabi.Hwindows { if *flagAslr { argv = addASLRargs(argv) -@@ -1358,6 +1359,7 @@ func (ctxt *Link) hostlink() { +@@ -1364,6 +1365,7 @@ func (ctxt *Link) hostlink() { argv = append(argv, "-Wl,-z,relro") } argv = append(argv, "-shared")
@@ -35,7 +35,7 @@ Signed-off-by: Alexander J Kube <[email protected]> case BuildModePlugin: if ctxt.HeadType == objabi.Hdarwin { argv = append(argv, "-dynamiclib") -@@ -1366,6 +1368,7 @@ func (ctxt *Link) hostlink() { +@@ -1372,6 +1374,7 @@ func (ctxt *Link) hostlink() { argv = append(argv, "-Wl,-z,relro") } argv = append(argv, "-shared")
meta/recipes-devtools/go/go-1.18/0005-make.bash-override-CC-when-building-dist-and-go_boot.patch +2 -4
@@ -17,11 +17,9 @@ Signed-off-by: Alexander J Kube <[email protected]> src/make.bash | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -diff --git a/src/make.bash b/src/make.bash -index 7986125..dd67029 100755 --- a/src/make.bash +++ b/src/make.bash -@@ -181,7 +181,7 @@ if [ "$GOROOT_BOOTSTRAP" = "$GOROOT" ]; then +@@ -195,7 +195,7 @@ if [ "$GOROOT_BOOTSTRAP" = "$GOROOT" ]; exit 1 fi rm -f cmd/dist/dist
@@ -30,7 +28,7 @@ index 7986125..dd67029 100755 # -e doesn't propagate out of eval, so check success by hand. eval $(./cmd/dist/dist env -p || echo FAIL=true) -@@ -206,7 +206,7 @@ fi +@@ -220,7 +220,7 @@ fi # Run dist bootstrap to complete make.bash. # Bootstrap installs a proper cmd/dist, built with the new toolchain. # Throw ours, built with Go 1.4, away after bootstrap.
meta/recipes-devtools/go/go-1.18/0006-cmd-dist-separate-host-and-target-builds.patch +18 -20
@@ -39,11 +39,9 @@ Signed-off-by: Alexander J Kube <[email protected]> src/cmd/dist/build.go | 156 ++++++++++++++++++++++++++++++------------ 1 file changed, 113 insertions(+), 43 deletions(-) -diff --git a/src/cmd/dist/build.go b/src/cmd/dist/build.go -index d82f612..5c8459c 100644 --- a/src/cmd/dist/build.go +++ b/src/cmd/dist/build.go -@@ -43,6 +43,7 @@ var ( +@@ -44,6 +44,7 @@ var ( goexperiment string workdir string tooldir string
@@ -51,7 +49,7 @@ index d82f612..5c8459c 100644 oldgoos string oldgoarch string exe string -@@ -55,6 +56,7 @@ var ( +@@ -54,6 +55,7 @@ var ( rebuildall bool defaultclang bool
@@ -59,7 +57,7 @@ index d82f612..5c8459c 100644 vflag int // verbosity ) -@@ -251,6 +253,8 @@ func xinit() { +@@ -254,6 +256,8 @@ func xinit() { if tooldir = os.Getenv("GOTOOLDIR"); tooldir == "" { tooldir = pathf("%s/pkg/tool/%s_%s", goroot, gohostos, gohostarch) }
@@ -68,7 +66,7 @@ index d82f612..5c8459c 100644 } // compilerEnv returns a map from "goos/goarch" to the -@@ -496,8 +500,10 @@ func setup() { +@@ -499,8 +503,10 @@ func setup() { p := pathf("%s/pkg/%s_%s", goroot, gohostos, gohostarch) if rebuildall { xremoveall(p)
@@ -79,7 +77,7 @@ index d82f612..5c8459c 100644 if goos != gohostos || goarch != gohostarch { p := pathf("%s/pkg/%s_%s", goroot, goos, goarch) -@@ -1267,17 +1273,35 @@ func cmdbootstrap() { +@@ -1252,17 +1258,35 @@ func cmdbootstrap() { var noBanner, noClean bool var debug bool
@@ -116,7 +114,7 @@ index d82f612..5c8459c 100644 // Set GOPATH to an internal directory. We shouldn't actually // need to store files here, since the toolchain won't // depend on modules outside of vendor directories, but if -@@ -1345,8 +1369,13 @@ func cmdbootstrap() { +@@ -1330,8 +1354,13 @@ func cmdbootstrap() { xprintf("\n") }
@@ -132,7 +130,7 @@ index d82f612..5c8459c 100644 goBootstrap := pathf("%s/go_bootstrap", tooldir) cmdGo := pathf("%s/go", gobin) if debug { -@@ -1375,7 +1404,11 @@ func cmdbootstrap() { +@@ -1360,7 +1389,11 @@ func cmdbootstrap() { xprintf("\n") } xprintf("Building Go toolchain2 using go_bootstrap and Go toolchain1.\n")
@@ -145,7 +143,7 @@ index d82f612..5c8459c 100644 // Now that cmd/go is in charge of the build process, enable GOEXPERIMENT. os.Setenv("GOEXPERIMENT", goexperiment) goInstall(goBootstrap, append([]string{"-i"}, toolchain...)...) -@@ -1414,50 +1447,84 @@ func cmdbootstrap() { +@@ -1399,50 +1432,84 @@ func cmdbootstrap() { } checkNotStale(goBootstrap, append(toolchain, "runtime/internal/sys")...)
@@ -197,8 +195,6 @@ index d82f612..5c8459c 100644 - timelog("build", "host toolchain") - if vflag > 0 { - xprintf("\n") -- } -- xprintf("Building packages and commands for host, %s/%s.\n", goos, goarch) + + if goos == oldgoos && goarch == oldgoarch { + // Common case - not setting up for cross-compilation.
@@ -230,7 +226,8 @@ index d82f612..5c8459c 100644 + os.Setenv("GOARCH", goarch) + os.Setenv("CC", compilerEnvLookup(defaultcc, goos, goarch)) + xprintf("Building packages and commands for target, %s/%s.\n", goos, goarch) -+ } + } +- xprintf("Building packages and commands for host, %s/%s.\n", goos, goarch) goInstall(goBootstrap, "std", "cmd") checkNotStale(goBootstrap, "std", "cmd") checkNotStale(cmdGo, "std", "cmd")
@@ -238,12 +235,7 @@ index d82f612..5c8459c 100644 - timelog("build", "target toolchain") - if vflag > 0 { - xprintf("\n") -+ if debug { -+ run("", ShowOutput|CheckExit, pathf("%s/compile", tooldir), "-V=full") -+ run("", ShowOutput|CheckExit, pathf("%s/buildid", tooldir), pathf("%s/pkg/%s_%s/runtime/internal/sys.a", goroot, goos, goarch)) -+ checkNotStale(goBootstrap, append(toolchain, "runtime/internal/sys")...) -+ copyfile(pathf("%s/compile4", tooldir), pathf("%s/compile", tooldir), writeExec) - } +- } - goos = oldgoos - goarch = oldgoarch - os.Setenv("GOOS", goos)
@@ -264,10 +256,16 @@ index d82f612..5c8459c 100644 - run("", ShowOutput|CheckExit, pathf("%s/buildid", tooldir), pathf("%s/pkg/%s_%s/runtime/internal/sys.a", goroot, goos, goarch)) - checkNotStale(goBootstrap, append(toolchain, "runtime/internal/sys")...) - copyfile(pathf("%s/compile4", tooldir), pathf("%s/compile", tooldir), writeExec) ++ if debug { ++ run("", ShowOutput|CheckExit, pathf("%s/compile", tooldir), "-V=full") ++ run("", ShowOutput|CheckExit, pathf("%s/buildid", tooldir), pathf("%s/pkg/%s_%s/runtime/internal/sys.a", goroot, goos, goarch)) ++ checkNotStale(goBootstrap, append(toolchain, "runtime/internal/sys")...) ++ copyfile(pathf("%s/compile4", tooldir), pathf("%s/compile", tooldir), writeExec) ++ } } // Check that there are no new files in $GOROOT/bin other than -@@ -1474,8 +1541,11 @@ func cmdbootstrap() { +@@ -1459,8 +1526,11 @@ func cmdbootstrap() { } }
meta/recipes-devtools/go/go-1.18/0007-cmd-go-make-GOROOT-precious-by-default.patch +5 -5
@@ -29,7 +29,7 @@ Signed-off-by: Alexander J Kube <[email protected]> --- a/src/cmd/go/internal/work/action.go +++ b/src/cmd/go/internal/work/action.go -@@ -670,6 +670,9 @@ func (b *Builder) addTransitiveLinkDeps( +@@ -673,6 +673,9 @@ func (b *Builder) addTransitiveLinkDeps( if p1 == nil || p1.Shlib == "" || haveShlib[filepath.Base(p1.Shlib)] { continue }
@@ -41,7 +41,7 @@ Signed-off-by: Alexander J Kube <[email protected]> // we'll end up building an overall library or executable that depends at runtime --- a/src/cmd/go/internal/work/build.go +++ b/src/cmd/go/internal/work/build.go -@@ -167,6 +167,8 @@ See also: go install, go get, go clean. +@@ -197,6 +197,8 @@ See also: go install, go get, go clean. const concurrentGCBackendCompilationEnabledByDefault = true
@@ -50,7 +50,7 @@ Signed-off-by: Alexander J Kube <[email protected]> func init() { // break init cycle CmdBuild.Run = runBuild -@@ -179,6 +181,10 @@ func init() { +@@ -209,6 +211,10 @@ func init() { AddBuildFlags(CmdBuild, DefaultBuildFlags) AddBuildFlags(CmdInstall, DefaultBuildFlags)
@@ -63,7 +63,7 @@ Signed-off-by: Alexander J Kube <[email protected]> // Note that flags consulted by other parts of the code --- a/src/cmd/go/internal/work/exec.go +++ b/src/cmd/go/internal/work/exec.go -@@ -468,6 +468,23 @@ func (b *Builder) build(a *Action) (err +@@ -535,6 +535,23 @@ func (b *Builder) build(ctx context.Cont return errors.New("binary-only packages are no longer supported") }
@@ -87,7 +87,7 @@ Signed-off-by: Alexander J Kube <[email protected]> if err := b.Mkdir(a.Objdir); err != nil { return err } -@@ -1520,6 +1537,14 @@ func BuildInstallFunc(b *Builder, a *Act +@@ -1585,6 +1602,14 @@ func (b *Builder) linkShared(ctx context return err }
meta/recipes-devtools/go/go-1.18/0008-use-GOBUILDMODE-to-set-buildmode.patch +1 -1
@@ -25,7 +25,7 @@ Signed-off-by: Alexander J Kube <[email protected]> --- a/src/cmd/go/internal/work/build.go +++ b/src/cmd/go/internal/work/build.go -@@ -254,7 +254,13 @@ func AddBuildFlags(cmd *base.Command, ma +@@ -283,7 +283,13 @@ func AddBuildFlags(cmd *base.Command, ma cmd.Flag.Var(&load.BuildAsmflags, "asmflags", "") cmd.Flag.Var(buildCompiler{}, "compiler", "")
meta/recipes-devtools/go/go-1.18/0009-Revert-cmd-go-make-sure-CC-and-CXX-are-absolute.patch deleted +0 -94
94 lines not on this page · raw message
meta/recipes-devtools/go/go-binary-native_1.18.bb renamed from meta/recipes-devtools/go/go-binary-native_1.17.8.bb +2 -2
@@ -8,8 +8,8 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=5d4950ecb7b26d2c5e4e7b4e0dd74707" PROVIDES = "go-native" SRC_URI = "https://dl.google.com/go/go${PV}.${BUILD_GOOS}-${BUILD_GOARCH}.tar.gz;name=go_${BUILD_GOTUPLE}" -SRC_URI[go_linux_amd64.sha256sum] = "980e65a863377e69fd9b67df9d8395fd8e93858e7a24c9f55803421e453f4f99" -SRC_URI[go_linux_arm64.sha256sum] = "57a9171682e297df1a5bd287be056ed0280195ad079af90af16dcad4f64710cb" +SRC_URI[go_linux_amd64.sha256sum] = "e85278e98f57cdb150fe8409e6e5df5343ecb13cebf03a5d5ff12bd55a80264f" +SRC_URI[go_linux_arm64.sha256sum] = "7ac7b396a691e588c5fb57687759e6c4db84a2a3bbebb0765f4b38e5b1c5b00e" UPSTREAM_CHECK_URI = "https://golang.org/dl/" UPSTREAM_CHECK_REGEX = "go(?P<pver>\d+(\.\d+)+)\.linux"
meta/recipes-devtools/go/go-cross-canadian_1.18.bb renamed from meta/recipes-devtools/go/go-cross-canadian_1.17.8.bb +0 -0
meta/recipes-devtools/go/go-cross_1.18.bb renamed from meta/recipes-devtools/go/go-cross_1.17.8.bb +0 -0
meta/recipes-devtools/go/go-crosssdk_1.18.bb renamed from meta/recipes-devtools/go/go-crosssdk_1.17.8.bb +0 -0
meta/recipes-devtools/go/go-native_1.18.bb renamed from meta/recipes-devtools/go/go-native_1.17.8.bb +0 -0
meta/recipes-devtools/go/go-runtime_1.18.bb renamed from meta/recipes-devtools/go/go-runtime_1.17.8.bb +0 -0
meta/recipes-devtools/go/go_1.18.bb renamed from meta/recipes-devtools/go/go_1.17.8.bb +0 -0
Signature · 1 line
2.35.1
PATCH v3 2/4 go: Drop GOBUILDMODE
This is local invention which is no longer needed, pie-mode works good now a days to build go for target
--- meta/recipes-devtools/go/go-1.18.inc | 1 - ...008-use-GOBUILDMODE-to-set-buildmode.patch | 42 ------------------- meta/recipes-devtools/go/go_1.18.bb | 1 - 3 files changed, 44 deletions(-) delete mode 100644 meta/recipes-devtools/go/go-1.18/0008-use-GOBUILDMODE-to-set-buildmode.patch
meta/recipes-devtools/go/go-1.18.inc +0 -1
@@ -11,7 +11,6 @@ SRC_URI += "\ file://0005-make.bash-override-CC-when-building-dist-and-go_boot.patch \ file://0006-cmd-dist-separate-host-and-target-builds.patch \ file://0007-cmd-go-make-GOROOT-precious-by-default.patch \ - file://0008-use-GOBUILDMODE-to-set-buildmode.patch \ file://0001-exec.go-do-not-write-linker-flags-into-buildids.patch \ file://0001-src-cmd-dist-buildgo.go-do-not-hardcode-host-compile.patch \ "
meta/recipes-devtools/go/go-1.18/0008-use-GOBUILDMODE-to-set-buildmode.patch deleted +0 -42
42 lines not on this page · raw message
meta/recipes-devtools/go/go_1.18.bb +0 -1
@@ -3,7 +3,6 @@ require go-target.inc inherit linuxloader -export GOBUILDMODE="" export GO_LDSO = "${@get_linuxloader(d)}" export CC_FOR_TARGET = "gcc" export CXX_FOR_TARGET = "g++"
Signature · 1 line
2.35.1
PATCH v3 3/4 go: Disable pie in cgo for mips
In reply to Khem RajThis overcomes the linking errors e.g.
| /usr/lib/go/src/cmd/go/internal/base/base.go:110:(.text+0x60fef8): relocation R_MIPS_26 against a local symbol' cannot be used when making a shared object; recompile with -fPIC | /usr/lib/go/src/cmd/go/internal/base/base.go:110:(.text+0x60ff0c): relocation R_MIPS_HI16 against a local symbol' cannot be used when making a shared object; recompile with -fPIC
--- meta/recipes-devtools/go/go_1.18.bb | 2 ++ 1 file changed, 2 insertions(+)
meta/recipes-devtools/go/go_1.18.bb +2 -0
@@ -3,6 +3,8 @@ require go-target.inc inherit linuxloader +CGO_LDFLAGS:append:mips = " -no-pie" + export GO_LDSO = "${@get_linuxloader(d)}" export CC_FOR_TARGET = "gcc" export CXX_FOR_TARGET = "g++"
Signature · 1 line
2.35.1
PATCH v3 4/4 go-target: Pass -trimpath to go linker
In reply to Khem RajThis is for improving reproducibility to trim absolute paths as these recipes do not inherit go bbclass where it would be set automatically
--- meta/recipes-devtools/go/go-target.inc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-devtools/go/go-target.inc +2 -2
@@ -14,9 +14,9 @@ export CGO_LDFLAGS = "${@ ' '.join(filter(lambda f: not f.startswith('-fdebug-pr export GOCACHE = "${B}/.cache" GO_LDFLAGS = "" -GO_LDFLAGS:class-nativesdk = "-linkmode external" +GO_LDFLAGS:class-nativesdk = " -linkmode external" export GO_LDFLAGS - +export GOBUILDFLAGS = "-gcflags=-trimpath=$GOPATH -asmflags=-trimpath=$GOPATH -trimpath" CC:append:class-nativesdk = " ${SECURITY_NOPIE_CFLAGS}" do_configure[noexec] = "1"
Signature · 1 line
2.35.1