ice: switch: fix a braino in the new dummy packet match definitions
Subsystems (3)
PATCH 1/1 ice: switch: fix a braino in the new dummy packet match definitions
There's a trivial mistake[0] in @ice_dummy_pkt_profile due to which it incorrectly states that "plain" TCP IPv6 packets should match on the flag 'inner IPv6', not the 'outer' one.
[0] https://lore.kernel.org/netdev/PH0PR11MB5782637EA9771D3ED4E56012FD1E9 at PH0PR11MB5782.namprd11.prod.outlook.com
---
Tony, please squash it with the mentioned commit on applying. Thanks.
--- drivers/net/ethernet/intel/ice/ice_switch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/intel/ice/ice_switch.c +2 -2
@@ -1276,8 +1276,8 @@ static const struct ice_dummy_pkt_profile ice_dummy_pkt_profiles[] = {ICE_PKT_PROFILE (udp_ipv6,ICE_PKT_OUTER_IPV6 |ICE_PKT_INNER_UDP ),ICE_PKT_PROFILE (vlan_udp,ICE_PKT_INNER_UDP |ICE_PKT_VLAN ),ICE_PKT_PROFILE (udp,ICE_PKT_INNER_UDP ), -ICE_PKT_PROFILE (vlan_tcp_ipv6,ICE_PKT_INNER_IPV6 |ICE_PKT_VLAN ), -ICE_PKT_PROFILE (tcp_ipv6,ICE_PKT_INNER_IPV6 ), +ICE_PKT_PROFILE (vlan_tcp_ipv6,ICE_PKT_OUTER_IPV6 |ICE_PKT_VLAN ), +ICE_PKT_PROFILE (tcp_ipv6,ICE_PKT_OUTER_IPV6 ),ICE_PKT_PROFILE (vlan_tcp,ICE_PKT_VLAN ), ICE_PKT_PROFILE(tcp, 0), };
Signature · 1 line
2.35.1
Thanks for the fix Alex!
Quoted 44 lines
-----Original Message-----
From: Lobakin, Alexandr <[email protected]>
Sent: ?roda, 30 marca 2022 11:21
To: intel-wired-lan at lists.osuosl.org
Cc: Lobakin, Alexandr <[email protected]>; Fijalkowski, Maciej <[email protected]>; Michal Swiatkowski <[email protected]>; Drewek, Wojciech <[email protected]>; Marcin Szycik <[email protected]>; Szapar-Mudlaw, Martyna <[email protected]>; David S. Miller <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni <[email protected]>; netdev at vger.kernel.org; linux- kernel at vger.kernel.org
Subject: [PATCH intel-next] ice: switch: fix a braino in the new dummy packet match definitionsThere's a trivial mistake[0] in @ice_dummy_pkt_profile due to which it incorrectly states that "plain" TCP IPv6 packets should match on the flag 'inner IPv6', not the 'outer' one.
[0] https://lore.kernel.org/netdev/PH0PR11MB5782637EA9771D3ED4E56012FD1E9 at PH0PR11MB5782.namprd11.prod.outlook.com
Fixes b5c7ae81ff90 ("ice: switch: convert packet template match code to rodata")Reported-by Wojciech Drewek <[email protected]>Signed-off-by Alexander Lobakin <[email protected]>---
Tony, please squash it with the mentioned commit on applying. Thanks.--- drivers/net/ethernet/intel/ice/ice_switch.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/net/ethernet/intel/ice/ice_switch.c +2
-3@@ -1276,8 +1276,8 @@ static const struct ice_dummy_pkt_profile ice_dummy_pkt_profiles[] = {ICE_PKT_PROFILE (udp_ipv6,ICE_PKT_OUTER_IPV6 |ICE_PKT_INNER_UDP ),ICE_PKT_PROFILE (vlan_udp,ICE_PKT_INNER_UDP |ICE_PKT_VLAN ),ICE_PKT_PROFILE (udp,ICE_PKT_INNER_UDP ), -ICE_PKT_PROFILE (vlan_tcp_ipv6,ICE_PKT_INNER_IPV6 |ICE_PKT_VLAN ), -ICE_PKT_PROFILE (tcp_ipv6,ICE_PKT_INNER_IPV6 ), +ICE_PKT_PROFILE (vlan_tcp_ipv6,ICE_PKT_OUTER_IPV6 |ICE_PKT_VLAN ), +ICE_PKT_PROFILE (tcp_ipv6,ICE_PKT_OUTER_IPV6 ),ICE_PKT_PROFILE (vlan_tcp,ICE_PKT_VLAN ), ICE_PKT_PROFILE(tcp, 0), }; --2.35.1