Skip to contentSkip to conversation

arm: imx: parse-container: add some missing end of line

PATCH In review Clément Péron 4 participants 4 messages Mar 30, 2022 – Apr 12, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: imx: parse-container: add some missing end of line

Some printf() have strings that doesn't terminate with end of line and make the output hard to read.

---
 arch/arm/mach-imx/parse-container.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-imx/parse-container.c +2 -2
index 039a4c7303..a4214d5376 100644
@@ -142,12 +142,12 @@ static int read_auth_container(struct spl_image_info *spl_image,
 		return -EIO;
 
 	if (container->tag != 0x87 && container->version != 0x0) {
-		printf("Wrong container header");
+		printf("Wrong container header\n");
 		return -ENOENT;
 	}
 
 	if (!container->num_images) {
-		printf("Wrong container, no image found");
+		printf("Wrong container, no image found\n");
 		return -ENOENT;
 	}
 
Signature · 1 line
2.32.0
Reviewed-by Peng Fan on v1 1/1
#2 lore raw
In reply to Clément Péron
Quoted 4 lines · Clément Péron

Some printf() have strings that doesn't terminate with end of line and make the output hard to read.

Quoted 24 lines
---
  arch/arm/mach-imx/parse-container.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-imx/parse-container.c +2 -2
index 039a4c7303..a4214d5376 100644
@@ -142,12 +142,12 @@ static int read_auth_container(struct spl_image_info *spl_image,
  		return -EIO;
 
  	if (container->tag != 0x87 && container->version != 0x0) {
-		printf("Wrong container header");
+		printf("Wrong container header\n");
  		return -ENOENT;
  	}
 
  	if (!container->num_images) {
-		printf("Wrong container, no image found");
+		printf("Wrong container, no image found\n");
  		return -ENOENT;
  	}
 
#3 lore raw

PATCH 1/1 arm: imx: parse-container: add some missing end of line

In reply to Clément Péron
Quoted 5 lines

Some printf() have strings that doesn't terminate with end of line and make the output hard to read.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================