Skip to contentSkip to conversation

dt-bindings: clock: convert rockchip,rk3228-cru.txt to YAML

PATCH Applied Johan Jonker 3 participants 6 messages Mar 30, 2022 – May 17, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 dt-bindings: clock: convert rockchip,rk3228-cru.txt to YAML

Convert rockchip,rk3228-cru.txt to YAML.

Changes against original bindings:
Add clocks and clock-names because the device has to have at least one input clock.

---
 .../bindings/clock/rockchip,rk3228-cru.txt    | 58 ---------------
 .../bindings/clock/rockchip,rk3228-cru.yaml   | 74 +++++++++++++++++++
 2 files changed, 74 insertions(+), 58 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3228-cru.txt
 create mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3228-cru.yaml
Documentation/devicetree/bindings/clock/rockchip,rk3228-cru.txt deleted +0 -58
deleted file mode 100644
index f32304812..000000000
@@ -1,58 +0,0 @@
-* Rockchip RK3228 Clock and Reset Unit
-
-The RK3228 clock controller generates and supplies clock to various
-controllers within the SoC and also implements a reset controller for SoC
-peripherals.
-
-Required Properties:
-
-- compatible: should be "rockchip,rk3228-cru"
-- reg: physical base address of the controller and length of memory mapped
-  region.
-- #clock-cells: should be 1.
-- #reset-cells: should be 1.
-
-Optional Properties:
-
-- rockchip,grf: phandle to the syscon managing the "general register files"
-  If missing pll rates are not changeable, due to the missing pll lock status.
-
-Each clock is assigned an identifier and client nodes can use this identifier
-to specify the clock which they consume. All available clocks are defined as
-preprocessor macros in the dt-bindings/clock/rk3228-cru.h headers and can be
-used in device tree sources. Similar macros exist for the reset sources in
-these files.
-
-External clocks:
-
-There are several clocks that are generated outside the SoC. It is expected
-that they are defined using standard clock bindings with following
-clock-output-names:
- - "xin24m" - crystal input - required,
- - "ext_i2s" - external I2S clock - optional,
- - "ext_gmac" - external GMAC clock - optional
- - "ext_hsadc" - external HSADC clock - optional
- - "phy_50m_out" - output clock of the pll in the mac phy
-
-Example: Clock controller node:
-
-	cru: cru@20000000 {
-		compatible = "rockchip,rk3228-cru";
-		reg = <0x20000000 0x1000>;
-		rockchip,grf = <&grf>;
-
-		#clock-cells = <1>;
-		#reset-cells = <1>;
-	};
-
-Example: UART controller node that consumes the clock generated by the clock
-  controller:
-
-	uart0: serial@10110000 {
-		compatible = "snps,dw-apb-uart";
-		reg = <0x10110000 0x100>;
-		interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
-		reg-shift = <2>;
-		reg-io-width = <4>;
-		clocks = <&cru SCLK_UART0>;
-	};
Documentation/devicetree/bindings/clock/rockchip,rk3228-cru.yaml new file +74 -0

74 lines not on this page · raw message

Signature · 1 line
2.20.1
#1 lore raw

PATCH 2/3 ARM: dts: rockchip: add clocks property to cru node rk3228

Add clocks and clock-names to the rk3228 cru node, because the device has to have at least one input clock.

---
 arch/arm/boot/dts/rk322x.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/rk322x.dtsi +2 -0
index 5868eb512..2547f46fe 100644
@@ -484,6 +484,8 @@
 	cru: clock-controller@110e0000 {
 		compatible = "rockchip,rk3228-cru";
 		reg = <0x110e0000 0x1000>;
+		clocks = <&xin24m>;
+		clock-names = "xin24m";
 		rockchip,grf = <&grf>;
 		#clock-cells = <1>;
 		#reset-cells = <1>;
Signature · 1 line
2.20.1
#2 lore raw

PATCH 3/3 ARM: dts: rockchip: rk322x: use generic node name for dma

In reply to Johan Jonker

The node names should be generic, so fix this for the rk3228 dma node and rename it to "dma-controller".

---
 arch/arm/boot/dts/rk322x.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/rk322x.dtsi +1 -1
index 2547f46fe..ffc16d6b9 100644
@@ -503,7 +503,7 @@
 			<75000000>;
 	};
 
-	pdma: pdma@110f0000 {
+	pdma: dma-controller@110f0000 {
 		compatible = "arm,pl330", "arm,primecell";
 		reg = <0x110f0000 0x4000>;
 		interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
Signature · 1 line
2.20.1
#3 lore raw

Re: [PATCH v1 3/3] ARM: dts: rockchip: rk322x: use generic node name for dma

Quoted 8 lines · Johan Jonker

The node names should be generic, so fix this for the rk3228 dma node and rename it to "dma-controller".

---
 arch/arm/boot/dts/rk322x.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Squash it with your other change that type and submit one commit per sub-arch (so for all arm Rockchips).

Best regards,
Krzysztof

Reviewed-by on v1 1/3
#4 lore raw
In reply to Johan Jonker
Quoted 6 lines · Johan Jonker

Convert rockchip,rk3228-cru.txt to YAML.

Changes against original bindings:
Add clocks and clock-names because the device has to have at least one input clock.

Quoted 8 lines
---
 .../bindings/clock/rockchip,rk3228-cru.txt    | 58 ---------------
 .../bindings/clock/rockchip,rk3228-cru.yaml   | 74 +++++++++++++++++++
 2 files changed, 74 insertions(+), 58 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3228-cru.txt
 create mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3228-cru.yaml

Best regards,
Krzysztof

maintainer Applied
#5 lore raw
In reply to Johan Jonker
Quoted 5 lines · Johan Jonker

Convert rockchip,rk3228-cru.txt to YAML.

Changes against original bindings:
Add clocks and clock-names because the device has to have at least one input clock.

Applied, thanks!

[1/3] dt-bindings: clock: convert rockchip,rk3228-cru.txt to YAML

      commit: 5b0c9b98e836724ad826c02f59f7350ddf6466a0
[2/3] ARM: dts: rockchip: add clocks property to cru node rk3228
      commit: 36b1b58523b531f60721d42910e4d6fe447c90d5

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>