powerpc: Fix incorrect SYS_IMMR migration values
PATCH 1/1 powerpc: Fix incorrect SYS_IMMR migration values
When migrating SYS_IMMR, I didn't allow for boards to provide non-default values here. This lead to an incorrect migration on the platforms where CONFIG_SYS_IMMR is set to CONFIG_SYS_CCSRBAR and CONFIG_SYS_CSSRBAR is NOT the same as CONFIG_SYS_CCSRBAR_DEFAULT. Add text to the prompt so that non-default values can be used and re-migrate the platforms that have CONFIG_SYS_IMMR=CONFIG_SYS_CSSRBAR where CONFIG_SYS_CSSRBAR != CONFIG_SYS_CCSRBAR_DEFAULT.
--- arch/Kconfig | 2 +- configs/MPC8548CDS_36BIT_defconfig | 1 + configs/MPC8548CDS_defconfig | 1 + configs/MPC8548CDS_legacy_defconfig | 1 + configs/P1010RDB-PA_36BIT_NAND_defconfig | 1 + configs/P1010RDB-PA_36BIT_NOR_defconfig | 1 + configs/P1010RDB-PA_36BIT_SDCARD_defconfig | 1 + configs/P1010RDB-PA_36BIT_SPIFLASH_defconfig | 1 + configs/P1010RDB-PA_NAND_defconfig | 1 + configs/P1010RDB-PA_NOR_defconfig | 1 + configs/P1010RDB-PA_SDCARD_defconfig | 1 + configs/P1010RDB-PA_SPIFLASH_defconfig | 1 + configs/P1010RDB-PB_36BIT_NAND_defconfig | 1 + configs/P1010RDB-PB_36BIT_NOR_defconfig | 1 + configs/P1010RDB-PB_36BIT_SDCARD_defconfig | 1 + configs/P1010RDB-PB_36BIT_SPIFLASH_defconfig | 1 + configs/P1010RDB-PB_NAND_defconfig | 1 + configs/P1010RDB-PB_NOR_defconfig | 1 + configs/P1010RDB-PB_SDCARD_defconfig | 1 + configs/P1010RDB-PB_SPIFLASH_defconfig | 1 + configs/P1020RDB-PC_36BIT_NAND_defconfig | 1 + configs/P1020RDB-PC_36BIT_SDCARD_defconfig | 1 + configs/P1020RDB-PC_36BIT_SPIFLASH_defconfig | 1 + configs/P1020RDB-PC_36BIT_defconfig | 1 + configs/P1020RDB-PC_NAND_defconfig | 1 + configs/P1020RDB-PC_SDCARD_defconfig | 1 + configs/P1020RDB-PC_SPIFLASH_defconfig | 1 + configs/P1020RDB-PC_defconfig | 1 + configs/P1020RDB-PD_NAND_defconfig | 1 + configs/P1020RDB-PD_SDCARD_defconfig | 1 + configs/P1020RDB-PD_SPIFLASH_defconfig | 1 + configs/P1020RDB-PD_defconfig | 1 + configs/P2020RDB-PC_36BIT_NAND_defconfig | 1 + configs/P2020RDB-PC_36BIT_SDCARD_defconfig | 1 + configs/P2020RDB-PC_36BIT_SPIFLASH_defconfig | 1 + configs/P2020RDB-PC_36BIT_defconfig | 1 + configs/P2020RDB-PC_NAND_defconfig | 1 + configs/P2020RDB-PC_SDCARD_defconfig | 1 + configs/P2020RDB-PC_SPIFLASH_defconfig | 1 + configs/P2020RDB-PC_defconfig | 1 + configs/socrates_defconfig | 1 + 41 files changed, 41 insertions(+), 1 deletion(-)
arch/Kconfig +1 -1
@@ -363,7 +363,7 @@ config SYS_DISABLE_DCACHE_OPS this functionality. config SYS_IMMR - hex + hex "Address for the Internal Memory-Mapped Registers (IMMR) window" depends on PPC || FSL_LSCH2 || FSL_LSCH3 || ARCH_LS1021A default 0xFF000000 if MPC8xx default 0xF0000000 if ARCH_MPC8313
configs/MPC8548CDS_36BIT_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xE0000000 CONFIG_SYS_TEXT_BASE=0xFFF80000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000
configs/MPC8548CDS_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xE0000000 CONFIG_SYS_TEXT_BASE=0xFFF80000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000
configs/MPC8548CDS_legacy_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xE0000000 CONFIG_SYS_TEXT_BASE=0xFFF80000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000
configs/P1010RDB-PA_36BIT_NAND_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x4000
configs/P1010RDB-PA_36BIT_NOR_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0xEFF40000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000
configs/P1010RDB-PA_36BIT_SDCARD_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=y
configs/P1010RDB-PA_36BIT_SPIFLASH_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=y
configs/P1010RDB-PA_NAND_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x4000
configs/P1010RDB-PA_NOR_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0xEFF40000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000
configs/P1010RDB-PA_SDCARD_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=y
configs/P1010RDB-PA_SPIFLASH_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=y
configs/P1010RDB-PB_36BIT_NAND_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x4000
configs/P1010RDB-PB_36BIT_NOR_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0xEFF40000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000
configs/P1010RDB-PB_36BIT_SDCARD_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=y
configs/P1010RDB-PB_36BIT_SPIFLASH_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=y
configs/P1010RDB-PB_NAND_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x4000
configs/P1010RDB-PB_NOR_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0xEFF40000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000
configs/P1010RDB-PB_SDCARD_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=y
configs/P1010RDB-PB_SPIFLASH_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=y
configs/P1020RDB-PC_36BIT_NAND_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x4000
configs/P1020RDB-PC_36BIT_SDCARD_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=y
configs/P1020RDB-PC_36BIT_SPIFLASH_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=y
configs/P1020RDB-PC_36BIT_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0xEFF40000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000
configs/P1020RDB-PC_NAND_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x4000
configs/P1020RDB-PC_SDCARD_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=y
configs/P1020RDB-PC_SPIFLASH_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=y
configs/P1020RDB-PC_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0xEFF40000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000
configs/P1020RDB-PD_NAND_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x20000
configs/P1020RDB-PD_SDCARD_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=y
configs/P1020RDB-PD_SPIFLASH_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=y
configs/P1020RDB-PD_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0xEFF40000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000
configs/P2020RDB-PC_36BIT_NAND_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x4000
configs/P2020RDB-PC_36BIT_SDCARD_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=y
configs/P2020RDB-PC_36BIT_SPIFLASH_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=y
configs/P2020RDB-PC_36BIT_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0xEFF40000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000
configs/P2020RDB-PC_NAND_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x4000
configs/P2020RDB-PC_SDCARD_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=y
configs/P2020RDB-PC_SPIFLASH_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=y
configs/P2020RDB-PC_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0xEFF40000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000
configs/socrates_defconfig +1 -0
@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xE0000000 CONFIG_SYS_TEXT_BASE=0xfff80000 CONFIG_ENV_SIZE=0x4000 CONFIG_ENV_SECT_SIZE=0x20000
Signature · 1 line
2.25.1
Quoted 11 lines · On Wednesday 30 March 2022 09:30:15 Tom Rini wrote:
When migrating
SYS_IMMR, I didn't allow for boards to provide non-default values here. This lead to an incorrect migration on the platforms whereCONFIG_SYS_IMMRis set toCONFIG_SYS_CCSRBARandCONFIG_SYS_CSSRBARis NOT the same asCONFIG_SYS_CCSRBAR_DEFAULT. Add text to the prompt so that non-default values can be used and re-migrate the platforms that haveCONFIG_SYS_IMMR=CONFIG_SYS_CSSRBARwhereCONFIG_SYS_CSSRBAR!=CONFIG_SYS_CCSRBAR_DEFAULT.Fixes be7dbb60c5bf ("Convert CONFIG_SYS_IMMR to Kconfig")Reported-by Pali Rohár <[email protected]>Signed-off-by Tom Rini <[email protected]>
For P2020RDB-PC_SDCARD_defconfig:
Quoted 460 lines
--- arch/Kconfig | 2 +- configs/MPC8548CDS_36BIT_defconfig | 1 + configs/MPC8548CDS_defconfig | 1 + configs/MPC8548CDS_legacy_defconfig | 1 + configs/P1010RDB-PA_36BIT_NAND_defconfig | 1 + configs/P1010RDB-PA_36BIT_NOR_defconfig | 1 + configs/P1010RDB-PA_36BIT_SDCARD_defconfig | 1 + configs/P1010RDB-PA_36BIT_SPIFLASH_defconfig | 1 + configs/P1010RDB-PA_NAND_defconfig | 1 + configs/P1010RDB-PA_NOR_defconfig | 1 + configs/P1010RDB-PA_SDCARD_defconfig | 1 + configs/P1010RDB-PA_SPIFLASH_defconfig | 1 + configs/P1010RDB-PB_36BIT_NAND_defconfig | 1 + configs/P1010RDB-PB_36BIT_NOR_defconfig | 1 + configs/P1010RDB-PB_36BIT_SDCARD_defconfig | 1 + configs/P1010RDB-PB_36BIT_SPIFLASH_defconfig | 1 + configs/P1010RDB-PB_NAND_defconfig | 1 + configs/P1010RDB-PB_NOR_defconfig | 1 + configs/P1010RDB-PB_SDCARD_defconfig | 1 + configs/P1010RDB-PB_SPIFLASH_defconfig | 1 + configs/P1020RDB-PC_36BIT_NAND_defconfig | 1 + configs/P1020RDB-PC_36BIT_SDCARD_defconfig | 1 + configs/P1020RDB-PC_36BIT_SPIFLASH_defconfig | 1 + configs/P1020RDB-PC_36BIT_defconfig | 1 + configs/P1020RDB-PC_NAND_defconfig | 1 + configs/P1020RDB-PC_SDCARD_defconfig | 1 + configs/P1020RDB-PC_SPIFLASH_defconfig | 1 + configs/P1020RDB-PC_defconfig | 1 + configs/P1020RDB-PD_NAND_defconfig | 1 + configs/P1020RDB-PD_SDCARD_defconfig | 1 + configs/P1020RDB-PD_SPIFLASH_defconfig | 1 + configs/P1020RDB-PD_defconfig | 1 + configs/P2020RDB-PC_36BIT_NAND_defconfig | 1 + configs/P2020RDB-PC_36BIT_SDCARD_defconfig | 1 + configs/P2020RDB-PC_36BIT_SPIFLASH_defconfig | 1 + configs/P2020RDB-PC_36BIT_defconfig | 1 + configs/P2020RDB-PC_NAND_defconfig | 1 + configs/P2020RDB-PC_SDCARD_defconfig | 1 + configs/P2020RDB-PC_SPIFLASH_defconfig | 1 + configs/P2020RDB-PC_defconfig | 1 + configs/socrates_defconfig | 1 + 41 files changed, 41 insertions(+), 1 deletion(-)arch/Kconfig +1
-1@@ -363,7 +363,7 @@ config SYS_DISABLE_DCACHE_OPS this functionality. config SYS_IMMR - hex + hex "Address for the Internal Memory-Mapped Registers (IMMR) window" depends on PPC || FSL_LSCH2 || FSL_LSCH3 || ARCH_LS1021A default 0xFF000000 if MPC8xx default 0xF0000000 if ARCH_MPC8313configs/MPC8548CDS_36BIT_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xE0000000 CONFIG_SYS_TEXT_BASE=0xFFF80000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000configs/MPC8548CDS_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xE0000000 CONFIG_SYS_TEXT_BASE=0xFFF80000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000configs/MPC8548CDS_legacy_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xE0000000 CONFIG_SYS_TEXT_BASE=0xFFF80000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000configs/P1010RDB-PA_36BIT_NAND_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x4000configs/P1010RDB-PA_36BIT_NOR_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0xEFF40000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000configs/P1010RDB-PA_36BIT_SDCARD_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=yconfigs/P1010RDB-PA_36BIT_SPIFLASH_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=yconfigs/P1010RDB-PA_NAND_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x4000configs/P1010RDB-PA_NOR_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0xEFF40000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000configs/P1010RDB-PA_SDCARD_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=yconfigs/P1010RDB-PA_SPIFLASH_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=yconfigs/P1010RDB-PB_36BIT_NAND_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x4000configs/P1010RDB-PB_36BIT_NOR_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0xEFF40000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000configs/P1010RDB-PB_36BIT_SDCARD_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=yconfigs/P1010RDB-PB_36BIT_SPIFLASH_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=yconfigs/P1010RDB-PB_NAND_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x4000configs/P1010RDB-PB_NOR_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0xEFF40000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000configs/P1010RDB-PB_SDCARD_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=yconfigs/P1010RDB-PB_SPIFLASH_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=yconfigs/P1020RDB-PC_36BIT_NAND_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x4000configs/P1020RDB-PC_36BIT_SDCARD_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=yconfigs/P1020RDB-PC_36BIT_SPIFLASH_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=yconfigs/P1020RDB-PC_36BIT_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0xEFF40000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000configs/P1020RDB-PC_NAND_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x4000configs/P1020RDB-PC_SDCARD_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=yconfigs/P1020RDB-PC_SPIFLASH_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=yconfigs/P1020RDB-PC_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0xEFF40000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000configs/P1020RDB-PD_NAND_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x20000configs/P1020RDB-PD_SDCARD_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=yconfigs/P1020RDB-PD_SPIFLASH_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=yconfigs/P1020RDB-PD_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0xEFF40000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000configs/P2020RDB-PC_36BIT_NAND_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x4000configs/P2020RDB-PC_36BIT_SDCARD_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=yconfigs/P2020RDB-PC_36BIT_SPIFLASH_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=yconfigs/P2020RDB-PC_36BIT_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0xEFF40000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000configs/P2020RDB-PC_NAND_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x4000configs/P2020RDB-PC_SDCARD_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=yconfigs/P2020RDB-PC_SPIFLASH_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0x11001000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_SPL_LIBCOMMON_SUPPORT=yconfigs/P2020RDB-PC_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xFFE00000 CONFIG_SYS_TEXT_BASE=0xEFF40000 CONFIG_SYS_MALLOC_LEN=0x100000 CONFIG_ENV_SIZE=0x2000configs/socrates_defconfig +1
-0@@ -1,4 +1,5 @@ CONFIG_PPC=y +CONFIG_SYS_IMMR=0xE0000000 CONFIG_SYS_TEXT_BASE=0xfff80000 CONFIG_ENV_SIZE=0x4000 CONFIG_ENV_SECT_SIZE=0x20000Signature · 1 line
2.25.1
Quoted 8 lines · Tom Rini
When migrating
SYS_IMMR, I didn't allow for boards to provide non-default values here. This lead to an incorrect migration on the platforms whereCONFIG_SYS_IMMRis set toCONFIG_SYS_CCSRBARandCONFIG_SYS_CSSRBARis NOT the same asCONFIG_SYS_CCSRBAR_DEFAULT. Add text to the prompt so that non-default values can be used and re-migrate the platforms that haveCONFIG_SYS_IMMR=CONFIG_SYS_CSSRBARwhereCONFIG_SYS_CSSRBAR!=CONFIG_SYS_CCSRBAR_DEFAULT.
Quoted 4 lines
Fixes be7dbb60c5bf ("Convert CONFIG_SYS_IMMR to Kconfig")Reported-by Pali Rohár <[email protected]>Signed-off-by Tom Rini <[email protected]>Tested-by Pali Rohár <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom