openvswitch: Add recirc_id to recirc warning
Subsystems (3)
PATCH 1/1 openvswitch: Add recirc_id to recirc warning
When hitting the recirculation limit, the kernel would currently log something like this:
[ 58.586597] openvswitch: ovs-system: deferred action limit reached, drop recirc action
Which isn't all that useful to debug as we only have the interface name to go on but can't track it down to a specific flow.
With this change, we now instead get:
[ 58.586597] openvswitch: ovs-system: deferred action limit reached, drop recirc action (recirc_id=0x9e)
Which can now be correlated with the flow entries from OVS.
--- net/openvswitch/actions.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
net/openvswitch/actions.c +2 -2
@@ -1539,8 +1539,8 @@ static int clone_execute(struct datapath *dp, struct sk_buff *skb,pr_warn ("%s: deferred action limit reached, drop sample action\n" ,ovs_dp_name (dp)); }else {/* Recirc action */ -pr_warn ("%s: deferred action limit reached, drop recirc action\n" , -ovs_dp_name (dp)); +pr_warn ("%s: deferred action limit reached, drop recirc action (recirc_id=%#x)\n" , +ovs_dp_name (dp), recirc_id); } } }
Signature · 1 line
2.34.1
Quoted 10 lines · Stéphane Graber
When hitting the recirculation limit, the kernel would currently log something like this:
[ 58.586597] openvswitch: ovs-system: deferred action limit reached, drop recirc actionWhich isn't all that useful to debug as we only have the interface name to go on but can't track it down to a specific flow.
With this change, we now instead get:
Quoted 8 lines
[ 58.586597] openvswitch: ovs-system: deferred action limit reached, drop recirc action (recirc_id=0x9e)Which can now be correlated with the flow entries from OVS.
Suggested-by Frode Nordahl <[email protected]>Signed-off-by Stéphane Graber <[email protected]>Tested-by Stephane Graber <[email protected]>---
This change looks good to me, and it makes debugging easier.
Quoted 20 lines
net/openvswitch/actions.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)net/openvswitch/actions.c +2
-2@@ -1539,8 +1539,8 @@ static int clone_execute(struct datapath *dp, struct sk_buff *skb,pr_warn ("%s: deferred action limit reached, drop sample action\n" ,ovs_dp_name (dp)); }else {/* Recirc action */ -pr_warn ("%s: deferred action limit reached, drop recirc action\n" , -ovs_dp_name (dp)); +pr_warn ("%s: deferred action limit reached, drop recirc action (recirc_id=%#x)\n" , +ovs_dp_name (dp), recirc_id); } } }Signature · 1 line
2.34.1
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:
Quoted 9 lines · On Wed, 30 Mar 2022 15:42:45 -0400 you wrote:
When hitting the recirculation limit, the kernel would currently log something like this:
[ 58.586597] openvswitch: ovs-system: deferred action limit reached, drop recirc actionWhich isn't all that useful to debug as we only have the interface name to go on but can't track it down to a specific flow.
[...]
Here is the summary with links:
- openvswitch: Add recirc_id to recirc warning
https://git.kernel.org/netdev/net/c/ea07af2e71cd
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html