multipath-tools: update "Generic NVMe" options in hwtable
RFC PATCH 1/1 multipath-tools: update "Generic NVMe" options in hwtable
Removed values were default.
Check ANA, else fall back to CONST(multibus).
--- libmultipath/hwtable.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
libmultipath/hwtable.c +3 -3
@@ -88,9 +88,9 @@ static struct hwentry default_hw[] = {/* Generic NVMe */ .vendor = "NVME", .product = ".*", - .uid_attribute = DEFAULT_NVME_UID_ATTRIBUTE, - .checker_name = NONE, - .retain_hwhandler = RETAIN_HWHANDLER_OFF, + .pgpolicy = GROUP_BY_PRIO, + .pgfailback = -FAILBACK_IMMEDIATE, + .no_path_retry = NO_PATH_RETRY_QUEUE, },/* * Apple
Signature · 6 lines
2.35.1 -- dm-devel mailing list [email protected] https://listman.redhat.com/mailman/listinfo/dm-devel
Quoted 1 line · Xose Vazquez Perez
Removed values were default.
This is wrong for uid_attribute. You can see it when you run "make test", which fails with your patch. It's also wrong for retain_hwhandler, but that entry should indeed be removed, because keeping it there is misleading at best. hwhandlers have no meaning for NVMe, and retain_hwhandler is enforced to be true an all kernels since 4.3.
Regards,
Martin
Quoted 18 lines
Check ANA, else fall back to CONST(multibus).
Cc Martin Wilck <[email protected]>Cc Benjamin Marzinski <[email protected]>Cc Christophe Varoqui <[email protected]>Cc DM-DEVEL ML <[email protected]>Signed-off-by Xose Vazquez Perez <[email protected]>---
libmultipath/hwtable.c | 6 +++---1 file changed, 3 insertions(+), 3 deletions(-)libmultipath/hwtable.c +0
-0@@ -88,9 +88,9 @@ static struct hwentry default_hw[] = { /* Generic NVMe */ .vendor = "NVME",
libmultipath/hwtable.c static struct hwentry default_hw[] = { · line 96
Quoted 10 lines
libmultipath/hwtable.c +3
-3.product = ".*", - .uid_attribute = DEFAULT_NVME_UID_ATTRIBUTE, - .checker_name = NONE, - .retain_hwhandler = RETAIN_HWHANDLER_OFF, + .pgpolicy = GROUP_BY_PRIO, + .pgfailback = -FAILBACK_IMMEDIATE, + .no_path_retry = NO_PATH_RETRY_QUEUE, }, /** Apple
--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel
Quoted 33 lines · Martin Wilck
Quoted 1 line · Xose Vazquez Perez
Removed values were default.
This is wrong for
uid_attribute. You can see it when you run "make test", which fails with your patch. It's also wrong forretain_hwhandler, but that entry should indeed be removed, because keeping it there is misleading at best. hwhandlers have no meaning for NVMe, andretain_hwhandleris enforced to be true an all kernels since 4.3.Regards,
MartinQuoted 20 lines
Check ANA, else fall back to CONST(multibus).
Cc Martin Wilck <[email protected]>Cc Benjamin Marzinski <[email protected]>Cc Christophe Varoqui <[email protected]>Cc DM-DEVEL ML <[email protected]>Signed-off-by Xose Vazquez Perez <[email protected]>--- libmultipath/hwtable.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)libmultipath/hwtable.c +0
-1@@ -88,9 +88,9 @@ static struct hwentry default_hw[] = { /* Generic NVMe */ .vendor = "NVME", .product = ".*", - .uid_attribute = DEFAULT_NVME_UID_ATTRIBUTE,
Quoted 9 lines
libmultipath/hwtable.c static struct hwentry default_hw[] = { · line 96
Quoted 8 lines
libmultipath/hwtable.c +3
-2- .checker_name = NONE, - .retain_hwhandler = RETAIN_HWHANDLER_OFF, + .pgpolicy = GROUP_BY_PRIO, + .pgfailback = -FAILBACK_IMMEDIATE, + .no_path_retry = NO_PATH_RETRY_QUEUE, }, /** Apple
as of this patch, what else do you want to add/remove ?
libmultipath/hwtable.c +1 -2
@@ -86,11 +86,10 @@ static struct hwentry default_hw[] = {*/ {/* Generic NVMe */ - .vendor = "NVME", + .vendor = "NVM[eE]", .product = ".*", .uid_attribute = DEFAULT_NVME_UID_ATTRIBUTE, .checker_name = NONE, - .retain_hwhandler = RETAIN_HWHANDLER_OFF, },/* * Apple
--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel
Quoted 56 lines · Xose Vazquez Perez
Quoted 35 lines · Martin Wilck
Quoted 1 line · Xose Vazquez Perez
Removed values were default.
This is wrong for
uid_attribute. You can see it when you run "make test", which fails with your patch. It's also wrong forretain_hwhandler, but that entry should indeed be removed, because keeping it there is misleading at best. hwhandlers have no meaning for
NVMe, andretain_hwhandleris enforced to be true an all kernels since
4.3.Regards,
MartinQuoted 20 lines
Check ANA, else fall back to CONST(multibus).
Cc Martin Wilck <[email protected]>Cc Benjamin Marzinski <[email protected]>Cc Christophe Varoqui <[email protected]>Cc DM-DEVEL ML <[email protected]>Signed-off-by Xose Vazquez Perez <[email protected]>---
libmultipath/hwtable.c | 6 +++---1 file changed, 3 insertions(+), 3 deletions(-)libmultipath/hwtable.c +0
-1@@ -88,9 +88,9 @@ static struct hwentry default_hw[] = { /* Generic NVMe */ .vendor = "NVME", .product = ".*", - .uid_attribute = DEFAULT_NVME_UID_ATTRIBUTE,Quoted 9 lines
libmultipath/hwtable.c static struct hwentry default_hw[] = { · line 95
Quoted 8 lines
libmultipath/hwtable.c +3
-2- .checker_name = NONE, - .retain_hwhandler = RETAIN_HWHANDLER_OFF, + .pgpolicy = GROUP_BY_PRIO, + .pgfailback = -FAILBACK_IMMEDIATE, + .no_path_retry = NO_PATH_RETRY_QUEUE, }, /** Apple as of this patch, what else do you want to add/remove ?
libmultipath/hwtable.c +0
-0@@ -86,11 +86,10 @@ static struct hwentry default_hw[] = {*/ {
libmultipath/hwtable.c static struct hwentry default_hw[] = { · line 95
Quoted 10 lines
libmultipath/hwtable.c +1
-2/* Generic NVMe */ - .vendor = "NVME", + .vendor = "NVM[eE]", .product = ".*", .uid_attribute = DEFAULT_NVME_UID_ATTRIBUTE, .checker_name = NONE, - .retain_hwhandler = RETAIN_HWHANDLER_OFF, }, /** Apple
This looks ok to me.
Martin
--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel