mmotm 2022-03-30-13-01 uploaded
Subsystems (4)
Andrew Morton
maintainerThe mm-of-the-moment snapshot 2022-03-30-13-01 has been uploaded to
https://www.ozlabs.org/~akpm/mmotm/
mmotm-readme.txt says
README for mm-of-the-moment:
https://www.ozlabs.org/~akpm/mmotm/
This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week.
You will need quilt to apply these patches to the latest Linus release (5.x or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in
https://ozlabs.org/~akpm/mmotm/series
The file broken-out.tar.gz contains two datestamp files: .DATE and .DATE-yyyy-mm-dd-hh-mm-ss. Both contain the string yyyy-mm-dd-hh-mm-ss, followed by the base kernel version against which this patch series is to be applied.
This tree is partially included in linux-next. To see which patches are included in linux-next, consult the `series' file. Only the patches within the #NEXT_PATCHES_START/#NEXT_PATCHES_END markers are included in linux-next.
A full copy of the full kernel tree with the linux-next and mmotm patches already applied is available through git within an hour of the mmotm release. Individual mmotm releases are tagged. The master branch always points to the latest release, so it's constantly rebasing.
https://github.com/hnaz/linux-mm
The directory https://www.ozlabs.org/~akpm/mmots/ (mm-of-the-second) contains daily snapshots of the -mm tree. It is updated more frequently than mmotm, and is untested.
A git copy of this tree is also available at
https://github.com/hnaz/linux-mm
This mmotm tree contains the following patches against 5.17:
(patches marked "*" will be included in linux-next)
origin.patch
* mm-secretmem-fix-panic-when-growing-a-memfd_secret.patch
* mailmap-update-vasily-averins-email-address.patch
* memcg-sync-flush-only-if-periodic-flush-is-delayed.patch
* revert-mm-madvise-skip-unmapped-vma-holes-passed-to-process_madvise.patch
* ocfs2-fix-crash-when-mount-with-quota-enabled.patch
* nilfs2-fix-lockdep-warnings-in-page-operations-for-btree-nodes.patch
* nilfs2-fix-lockdep-warnings-during-disk-space-reclamation.patch
* nilfs2-get-rid-of-nilfs_mapping_init.patch
* mm-munlock-remove-fields-to-fix-htmldocs-warnings.patch
* mm-munlock-add-lru_add_drain-to-fix-memcg_stat_test.patch
* mm-kfence-fix-objcgs-vector-allocation.patch
* mailmap-update-kirills-email.patch
* mmhwpoison-unmap-poisoned-page-before-invalidation.patch
* mm-kasan-fix-__gfp_bits_shift-definition-breaking-lockdep.patch
* tools-vm-page_owner_sortc-remove-c-option.patch
* doc-vm-page_ownerrst-remove-content-related-to-c-option.patch
* mm-kmemleak-reset-tag-when-compare-object-pointer.patch
* userfaultfd-mark-uffd_wp-regardless-of-vm_write-flag.patch
* mm-fix-unexpected-zeroed-page-mapping-with-zram-swap.patch
* mm-compaction-fix-compiler-warning-when-config_compaction=n.patch
* hugetlb-do-not-demote-poisoned-hugetlb-pages.patch
* proc-kpageflags-prevent-an-integer-overflow-in-stable_page_flags.patch
* proc-kpageflags-do-not-use-uninitialized-struct-pages.patch
* procfs-prevent-unpriveleged-processes-accessing-fdinfo-dir.patch
mm.patch
* stacktrace-add-interface-based-on-shadow-call-stack.patch
* arm64-scs-save-scs_sp-values-per-cpu-when-switching-stacks.patch
* arm64-implement-stack_trace_save_shadow.patch
* kasan-use-stack_trace_save_shadow.patch
* mm-shmem-make-shmem_init-return-void.patch
* mm-shmem-make-shmem_init-return-void-fix.patch
* mm-memcg-remove-unneeded-nr_scanned.patch
* mm-memcg-mz-already-removed-from-rb_tree-if-not-null.patch
* mm-use-mmap_assert_write_locked-instead-of-open-coding-it.patch
* mm-mmu_gather-limit-free-batch-count-and-add-schedule-point-in-tlb_batch_pages_flush.patch
* mm-mremap-use-helper-mlock_future_check.patch
* documentation-sysctl-document-page_lock_unfairness.patch
* mm-page_alloc-simplify-update-of-pgdat-in-wake_all_kswapds.patch
* mm-page_alloc-add-same-penalty-is-enough-to-get-round-robin-order.patch
* mm-discard-__gfp_atomic.patch
* mm-remove-unnecessary-void-conversions.patch
* mm-munlock-protect-the-per-cpu-pagevec-by-a-local_lock_t.patch
* mm-khugepaged-sched-to-numa-node-when-collapse-huge-page.patch
* mm-vmscan-reclaim-only-affects-managed_zones.patch
* mm-vmscan-make-sure-wakeup_kswapd-with-managed-zone.patch
* mm-vmscan-sc-reclaim_idx-must-be-a-valid-zone-index.patch
* mm-z3fold-declare-z3fold_mount-with-__init.patch
* mm-z3fold-remove-obsolete-comment-in-z3fold_alloc.patch
* mm-z3fold-minor-clean-up-for-z3fold_free.patch
* mm-z3fold-remove-unneeded-page_mapcount_reset-and-clearpageprivate.patch
* mm-z3fold-remove-confusing-local-variable-l-reassignment.patch
* mm-z3fold-move-decrement-of-pool-pages_nr-into-__release_z3fold_page.patch
* mm-z3fold-remove-redundant-list_del_init-of-zhdr-buddy-in-z3fold_free.patch
* mm-z3fold-remove-unneeded-page_headless-check-in-free_handle.patch
* mm-compaction-use-helper-isolation_suitable.patch
* mm-add-selftests-for-migration-entries.patch
* mm-migration-remove-unneeded-local-variable-mapping_locked.patch
* mm-migration-remove-unneeded-out-label.patch
* mm-migration-remove-unneeded-local-variable-page_lru.patch
* mm-migration-fix-the-confusing-pagetranshuge-check.patch
* mm-migration-use-helper-function-vma_lookup-in-add_page_for_migration.patch
* mm-migration-use-helper-macro-min-in-do_pages_stat.patch
* mm-migration-avoid-unneeded-nodemask_t-initialization.patch
* mm-migration-remove-some-duplicated-codes-in-migrate_pages.patch
* mm-migration-fix-potential-page-refcounts-leak-in-migrate_pages.patch
* mm-migration-fix-potential-invalid-node-access-for-reclaim-based-migration.patch
* mm-migration-fix-possible-do_pages_stat_array-racing-with-memory-offline.patch
* ksm-count-ksm-merging-pages-for-each-process.patch
* ksm-count-ksm-merging-pages-for-each-process-fix.patch
* mm-untangle-config-dependencies-for-demote-on-reclaim.patch
* mm-page_alloc-do-not-calculate-nodes-total-pages-and-memmap-pages-when-empty.patch
* mm-memory_hotplug-reset-nodes-state-when-empty-during-offline.patch
* mm-memory_hotplug-refactor-hotadd_init_pgdat-and-try_online_node.patch
* mm-memory_hotplug-refactor-hotadd_init_pgdat-and-try_online_node-checkpatch-fixes.patch
* mm-rmap-convert-from-atomic_t-to-refcount_t-on-anon_vma-refcount.patch
* mm-rmap-fix-cache-flush-on-thp-pages.patch
* dax-fix-cache-flush-on-pmd-mapped-pages.patch
* mm-rmap-introduce-pfn_mkclean_range-to-cleans-ptes.patch
* mm-pvmw-add-support-for-walking-devmap-pages.patch
* dax-fix-missing-writeprotect-the-pte-entry.patch
* mm-simplify-follow_invalidate_pte.patch
* zram-add-a-huge_idle-writeback-mode.patch
* damon-vaddr-test-tweak-code-to-make-the-logic-clearer.patch
* info-task-hung-in-generic_file_write_iter.patch
* info-task-hung-in-generic_file_write-fix.patch
* kernel-hung_taskc-monitor-killed-tasks.patch
* ia64-fix-typos-in-comments.patch
* ia64-ptrace-fix-typos-in-comments.patch
* ia64-replace-comments-with-c99-initializers.patch
* ocfs2-replace-usage-of-found-with-dedicated-list-iterator-variable.patch
* ocfs2-remove-usage-of-list-iterator-variable-after-the-loop-body.patch
* ocfs2-reflink-deadlock-when-clone-file-to-the-same-directory-simultaneously.patch
* ocfs2-clear-links-count-in-ocfs2_mknod-if-an-error-occurs.patch
* ocfs2-fix-ocfs2-corrupt-when-iputting-an-inode.patch
* proc-fix-dentry-inode-overinstantiating-under-proc-pid-net.patch
* proc-fix-dentry-inode-overinstantiating-under-proc-pid-net-checkpatch-fixes.patch
* proc-sysctl-make-protected_-world-readable.patch
* kernel-pid_namespace-use-null-instead-of-using-plain-integer-as-pointer.patch
* get_maintainer-honor-mailmap-for-in-file-emails.patch
* lib-test_meminit-optimize-do_kmem_cache_rcu_persistent-test.patch
* lib-kconfigdebug-remove-more-config__value-indirections.patch
* lib-test_stringc-add-strspn-and-strcspn-tests.patch
* lib-stringc-simplify-strspn.patch
* lz4-fix-lz4_decompress_safe_partial-read-out-of-bound.patch
* pipe-make-poll_usage-boolean-and-annotate-its-access.patch
* list-fix-a-data-race-around-ep-rdllist.patch
* init-mainc-silence-some-wunused-parameter-warnings.patch
* fatfs-remove-redundant-judgment.patch
* rapidio-remove-unnecessary-use-of-list-iterator.patch
* ipc-mqueue-use-get_tree_nodev-in-mqueue_get_tree.patch
linux-next.patch
linux-next-rejects.patch
* mm-oom_killc-fix-vm_oom_kill_table-ifdeffery.patch
* selftests-vm-add-test-for-soft-dirty-pte-bit.patch
* kselftest-vm-override-targets-from-arguments.patch make-sure-nobodys-leaking-resources.patch releasing-resources-with-children.patch mutex-subsystem-synchro-test-module.patch mutex-subsystem-synchro-test-module-fix.patch kernel-forkc-export-kernel_thread-to-modules.patch workaround-for-a-pci-restoring-bug.patch
Re: mmotm 2022-03-30-13-01 uploaded (kernel/sched/ and sysctls)
Luis-
Quoted 8 lines · Andrew Morton
The mm-of-the-moment snapshot 2022-03-30-13-01 has been uploaded to
https://www.ozlabs.org/~akpm/mmotm/mmotm-readme.txt says
README for mm-of-the-moment:
Quoted 8 lines
https://www.ozlabs.org/~akpm/mmotm/
This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week.
You will need quilt to apply these patches to the latest Linus release (5.x or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in
https://ozlabs.org/~akpm/mmotm/series
# CONFIG_SYSCTL is not set
# CONFIG_PROC_SYSCTL is not set
In file included from ../kernel/sched/build_policy.c:43:0:../kernel/sched/rt.c:3017:12: warning: ‘sched_rr_handler’ defined but not used [-Wunused-function]
static int sched_rr_handler(struct ctl_table *table, int write, void *buffer,
^~~~~~~~~~~~~~~~
../kernel/sched/rt.c:2978:12: warning: ‘sched_rt_handler’ defined but not used [-Wunused-function]
static int sched_rt_handler(struct ctl_table *table, int write, void *buffer,
^~~~~~~~~~~~~~~~This was also reported on Feb.22/2022:
https://lore.kernel.org/all/[email protected]/
and by Baisong Zhong <[email protected]>
on Mar.17/2022.
Signature · 1 line
~Randy
Re: mmotm 2022-03-30-13-01 uploaded (kernel/sched/ and sysctls)
Quoted 27 lines · Randy Dunlap
Luis-
Quoted 8 lines · Andrew Morton
The mm-of-the-moment snapshot 2022-03-30-13-01 has been uploaded to
https://www.ozlabs.org/~akpm/mmotm/mmotm-readme.txt says
README for mm-of-the-moment:
Quoted 8 lines
https://www.ozlabs.org/~akpm/mmotm/
This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week.
You will need quilt to apply these patches to the latest Linus release (5.x or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in
https://ozlabs.org/~akpm/mmotm/series#
CONFIG_SYSCTLis not set
#CONFIG_PROC_SYSCTLis not setIn file included from
../kernel/sched/build_policy.c:43:0:../kernel/sched/rt.c:3017:12: warning: ‘sched_rr_handler’ defined but not used [-Wunused-function]
static int sched_rr_handler(structctl_table*table, int write, void *buffer,
Quoted 8 lines
^~~~~~~~~~~~~~~~ ../kernel/sched/rt.c:2978:12: warning: ‘sched_rt_handler’ defined but not used [-Wunused-function] static int sched_rt_handler(struct ctl_table *table, int write, void *buffer, ^~~~~~~~~~~~~~~~This was also reported on Feb.22/2022:
https://lore.kernel.org/all/[email protected]/
Yes, I'm on it, thanks!
Luis
Re: mmotm 2022-03-30-13-01 uploaded (DWARF error: could not find abbrev number 74)
In reply to Andrew MortonQuoted 8 lines · Andrew Morton
The mm-of-the-moment snapshot 2022-03-30-13-01 has been uploaded to
https://www.ozlabs.org/~akpm/mmotm/mmotm-readme.txt says
README for mm-of-the-moment:
Quoted 8 lines
https://www.ozlabs.org/~akpm/mmotm/
This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week.
You will need quilt to apply these patches to the latest Linus release (5.x or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in
https://ozlabs.org/~akpm/mmotm/series
on x86_64:
ld: ld: DWARF error: could not find abbrev number 74 or
ld: ld: DWARF error: could not find abbrev number 77
gcc is:
gcc (SUSE Linux) 7.5.0
Full randconfig file is attached.
Signature · 1 line
~Randy
Re: mmotm 2022-03-30-13-01 uploaded (drivers/platform/x86/amd-pmc.o)
In reply to Andrew MortonQuoted 8 lines · Andrew Morton
The mm-of-the-moment snapshot 2022-03-30-13-01 has been uploaded to
https://www.ozlabs.org/~akpm/mmotm/mmotm-readme.txt says
README for mm-of-the-moment:
Quoted 9 lines
https://www.ozlabs.org/~akpm/mmotm/
This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week.
You will need quilt to apply these patches to the latest Linus release (5.x or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in
https://ozlabs.org/~akpm/mmotm/series
on x86_64:
when CONFIG_SUSPEND is not set:
drivers/platform/x86/amd-pmc.o: in function `amd_pmc_remove':
amd-pmc.c:(.text+0x11d): undefined reference to `acpi_unregister_lps0_dev'
ld: drivers/platform/x86/amd-pmc.o: in function `amd_pmc_probe':
amd-pmc.c:(.text+0x20be): undefined reference to `acpi_register_lps0_dev'
Signature · 1 line
~Randy
RE: mmotm 2022-03-30-13-01 uploaded (drivers/platform/x86/amd-pmc.o)
[AMD Official Use Only]
Quoted 64 lines
-----Original Message-----
From: Randy Dunlap <[email protected]>
Sent: Thursday, March 31, 2022 10:51
To: Andrew Morton <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]; [email protected]; linux- [email protected]; [email protected]; platform-driver- [email protected]; Limonciello, Mario <[email protected]>
Subject: Re: mmotm 2022-03-30-13-01 uploaded (drivers/platform/x86/amd-pmc.o)Quoted 3 lines · Andrew Morton
The mm-of-the-moment snapshot 2022-03-30-13-01 has been uploaded to
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww
w.ozlabs.org%2F~akpm%2Fmmotm%2F&data=04%7C01%7Cmario.limo nciello%40amd.com%7Caa3aae02b7b6437c46ea08da132e4222%7C3dd8961fe 4884e608e11a82d994e183d%7C0%7C0%7C637843386674652995%7CUnknown %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha WwiLCJXVCI6Mn0%3D%7C3000&sdata=WpfXOyTRBgvqCj3iZ%2BJjXVTb V%2FUWDP4ds5XtDfa5bPc%3D&reserved=0Quoted 6 lines
mmotm-readme.txt says
README for mm-of-the-moment:
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww
w.ozlabs.org%2F~akpm%2Fmmotm%2F&data=04%7C01%7Cmario.limo nciello%40amd.com%7Caa3aae02b7b6437c46ea08da132e4222%7C3dd8961fe 4884e608e11a82d994e183d%7C0%7C0%7C637843386674652995%7CUnknown %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha WwiLCJXVCI6Mn0%3D%7C3000&sdata=WpfXOyTRBgvqCj3iZ%2BJjXVTb V%2FUWDP4ds5XtDfa5bPc%3D&reserved=0Quoted 7 lines
This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week.
You will need quilt to apply these patches to the latest Linus release (5.x or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fozla
bs.org%2F~akpm%2Fmmotm%2Fseries&data=04%7C01%7Cmario.limon ciello%40amd.com%7Caa3aae02b7b6437c46ea08da132e4222%7C3dd8961fe4 884e608e11a82d994e183d%7C0%7C0%7C637843386674652995%7CUnknown %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha WwiLCJXVCI6Mn0%3D%7C3000&sdata=adnYHchdMvieQ0lCqQ1er1jhHA UMomgFpaWBo%2BMnINk%3D&reserved=0Quoted 1 line
on
x86_64:
whenCONFIG_SUSPENDis not set:
drivers/platform/x86/amd-pmc.o: in function `amd_pmc_remove':
amd-pmc.c:(.text+0x11d): undefined reference to `acpi_unregister_lps0_dev'
ld:drivers/platform/x86/amd-pmc.o: in function `amd_pmc_probe':
amd-pmc.c:(.text+0x20be): undefined reference to `acpi_register_lps0_dev'
Quoted 2 lines
--
~Randy
AFAICT you're missing 20e1d6402a71dba7ad2b81f332a3c14c7d3b939b.
I cloned https://github.com/hnaz/linux-mm
As of commit 074b4ea9811e2c47ae1ecada177629c19fa56d59 And don't see the commit. This is in mainline though.
$ git show 20e1d6402a71dba7ad2b81f332a3c14c7d3b939b fatal: bad object 20e1d6402a71dba7ad2b81f332a3c14c7d3b939b
Re: mmotm 2022-03-30-13-01 uploaded (drivers/platform/x86/amd-pmc.o)
Hi Mario,
Quoted 66 lines · Mario
[AMD Official Use Only]
Quoted 64 lines
-----Original Message-----
From: Randy Dunlap <[email protected]>
Sent: Thursday, March 31, 2022 10:51
To: Andrew Morton <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]; [email protected]; linux- [email protected]; [email protected]; platform-driver- [email protected]; Limonciello, Mario <[email protected]>
Subject: Re: mmotm 2022-03-30-13-01 uploaded (drivers/platform/x86/amd-pmc.o)Quoted 3 lines · Andrew Morton
The mm-of-the-moment snapshot 2022-03-30-13-01 has been uploaded to
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww
w.ozlabs.org%2F~akpm%2Fmmotm%2F&data=04%7C01%7Cmario.limo nciello%40amd.com%7Caa3aae02b7b6437c46ea08da132e4222%7C3dd8961fe 4884e608e11a82d994e183d%7C0%7C0%7C637843386674652995%7CUnknown %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha WwiLCJXVCI6Mn0%3D%7C3000&sdata=WpfXOyTRBgvqCj3iZ%2BJjXVTb V%2FUWDP4ds5XtDfa5bPc%3D&reserved=0Quoted 6 lines
mmotm-readme.txt says
README for mm-of-the-moment:
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww
w.ozlabs.org%2F~akpm%2Fmmotm%2F&data=04%7C01%7Cmario.limo nciello%40amd.com%7Caa3aae02b7b6437c46ea08da132e4222%7C3dd8961fe 4884e608e11a82d994e183d%7C0%7C0%7C637843386674652995%7CUnknown %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha WwiLCJXVCI6Mn0%3D%7C3000&sdata=WpfXOyTRBgvqCj3iZ%2BJjXVTb V%2FUWDP4ds5XtDfa5bPc%3D&reserved=0Quoted 7 lines
This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week.
You will need quilt to apply these patches to the latest Linus release (5.x or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fozla
bs.org%2F~akpm%2Fmmotm%2Fseries&data=04%7C01%7Cmario.limon ciello%40amd.com%7Caa3aae02b7b6437c46ea08da132e4222%7C3dd8961fe4 884e608e11a82d994e183d%7C0%7C0%7C637843386674652995%7CUnknown %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha WwiLCJXVCI6Mn0%3D%7C3000&sdata=adnYHchdMvieQ0lCqQ1er1jhHA UMomgFpaWBo%2BMnINk%3D&reserved=0Quoted 1 line
on
x86_64:
whenCONFIG_SUSPENDis not set:
drivers/platform/x86/amd-pmc.o: in function `amd_pmc_remove':
amd-pmc.c:(.text+0x11d): undefined reference to `acpi_unregister_lps0_dev'
ld:drivers/platform/x86/amd-pmc.o: in function `amd_pmc_probe':
amd-pmc.c:(.text+0x20be): undefined reference to `acpi_register_lps0_dev'
Quoted 4 lines
Quoted 2 lines
--
~RandyAFAICT you're missing
20e1d6402a71dba7ad2b81f332a3c14c7d3b939b.
That is unlikely since the whole series got merged through the pdx86/for-next branch, so either some other tree has the whole series or none of it.
Also note that Randy wrote:
"when CONFIG_SUSPEND is not set"
The problem is that all of drivers/acpi/x86/s2idle.c is wrapped by #ifdef CONFIG_SUSPEND ... #endif
Since AFAIK the whole amd-pmc driver's whole purpose is to allow s2idle to work properly. I think this can be fixed by simply doing:
drivers/platform/x86/Kconfig +1 -1
@@ -198,7 +198,7 @@ config ACER_WMI config AMD_PMC tristate "AMD SoC PMC driver" - depends on ACPI && PCI && RTC_CLASS + depends on ACPI && SUSPEND && PCI && RTC_CLASS help The driver provides support for AMD Power Management Controller primarily responsible for S2Idle transactions that are driven from
If you agree, please submit a patch with this change and I'll queue it up in my fixes branch.
Regards,
Hans
RE: mmotm 2022-03-30-13-01 uploaded (drivers/platform/x86/amd-pmc.o)
[Public]
Quoted 113 lines
-----Original Message-----
From: Hans de Goede <[email protected]>
Sent: Friday, April 1, 2022 10:01
To: Limonciello, Mario <[email protected]>; Randy Dunlap <[email protected]>; Andrew Morton <[email protected]>; [email protected]; [email protected]; [email protected]; linux- [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; platform- [email protected]
Subject: Re: mmotm 2022-03-30-13-01 uploaded (drivers/platform/x86/amd-pmc.o)Hi Mario,
Quoted 7 lines · Mario
[AMD Official Use Only]
Quoted 5 lines
-----Original Message-----
From: Randy Dunlap <[email protected]>
Sent: Thursday, March 31, 2022 10:51
To: Andrew Morton <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected];linux-
Quoted 4 lines
Quoted 4 lines
[email protected]; [email protected]; linux- [email protected]; [email protected]; platform-driver- [email protected]; Limonciello, Mario <[email protected]>
Subject: Re: mmotm 2022-03-30-13-01 uploaded(
drivers/platform/x86/amd-Quoted 6 lines
Quoted 6 lines
pmc.o)
Quoted 1 line · Andrew Morton
The mm-of-the-moment snapshot 2022-03-30-13-01 has been uploaded
to
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww
Quoted 1 line
Quoted 1 line
w.ozlabs.org%2F~akpm%2Fmmotm%2F&data=04%7C01%7Cmario.limo
Quoted 1 line
Quoted 1 line
nciello%40amd.com%7Caa3aae02b7b6437c46ea08da132e4222%7C3dd8961fe
Quoted 1 line
Quoted 1 line
4884e608e11a82d994e183d%7C0%7C0%7C637843386674652995%7CUnknown
Quoted 1 line
Quoted 1 line
%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
Quoted 1 line
Quoted 1 line
WwiLCJXVCI6Mn0%3D%7C3000&sdata=WpfXOyTRBgvqCj3iZ%2BJjXVTb
Quoted 8 lines
Quoted 8 lines
V%2FUWDP4ds5XtDfa5bPc%3D&reserved=0
Quoted 6 lines
mmotm-readme.txt says
README for mm-of-the-moment:
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fww
Quoted 1 line
Quoted 1 line
w.ozlabs.org%2F~akpm%2Fmmotm%2F&data=04%7C01%7Cmario.limo
Quoted 1 line
Quoted 1 line
nciello%40amd.com%7Caa3aae02b7b6437c46ea08da132e4222%7C3dd8961fe
Quoted 1 line
Quoted 1 line
4884e608e11a82d994e183d%7C0%7C0%7C637843386674652995%7CUnknown
Quoted 1 line
Quoted 1 line
%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
Quoted 1 line
Quoted 1 line
WwiLCJXVCI6Mn0%3D%7C3000&sdata=WpfXOyTRBgvqCj3iZ%2BJjXVTb
Quoted 3 lines
Quoted 3 lines
V%2FUWDP4ds5XtDfa5bPc%3D&reserved=0
Quoted 2 lines
This is a snapshot of my -mm patch queue. Uploaded at random
hopefully
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
more than once a week.
You will need quilt to apply these patches to the latest Linus release (5.x or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fozla
Quoted 1 line
Quoted 1 line
bs.org%2F~akpm%2Fmmotm%2Fseries&data=04%7C01%7Cmario.limon
Quoted 1 line
Quoted 1 line
ciello%40amd.com%7Caa3aae02b7b6437c46ea08da132e4222%7C3dd8961fe4
Quoted 1 line
Quoted 1 line
884e608e11a82d994e183d%7C0%7C0%7C637843386674652995%7CUnknown
Quoted 1 line
Quoted 1 line
%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
Quoted 1 line
Quoted 1 line
WwiLCJXVCI6Mn0%3D%7C3000&sdata=adnYHchdMvieQ0lCqQ1er1jhHA
Quoted 11 lines
Quoted 11 lines
UMomgFpaWBo%2BMnINk%3D&reserved=0
Quoted 1 line
on
x86_64:
whenCONFIG_SUSPENDis not set:
drivers/platform/x86/amd-pmc.o: in function `amd_pmc_remove':
amd-pmc.c:(.text+0x11d): undefined reference to `acpi_unregister_lps0_dev'
ld:drivers/platform/x86/amd-pmc.o: in function `amd_pmc_probe':
amd-pmc.c:(.text+0x20be): undefined reference to`acpi_register_lps0_dev'
Quoted 7 lines
Quoted 5 lines
--
~RandyAFAICT you're missing
20e1d6402a71dba7ad2b81f332a3c14c7d3b939b.That is unlikely since the whole series got merged through the pdx86/for-next branch, so either some other tree has the whole series or none of it.
Quoted 7 lines
Also note that Randy wrote:
"when
CONFIG_SUSPENDis not set"The problem is that all of
drivers/acpi/x86/s2idle.cis wrapped by #ifdefCONFIG_SUSPEND... #endif
Ah thanks.
Quoted 18 lines
Since AFAIK the whole amd-pmc driver's whole purpose is to allow s2idle to work properly. I think this can be fixed by simply doing:
drivers/platform/x86/Kconfig +1
-1@@ -198,7 +198,7 @@ config ACER_WMI config AMD_PMC tristate "AMD SoC PMC driver" - depends on ACPI && PCI && RTC_CLASS + depends on ACPI && SUSPEND && PCI && RTC_CLASS help The driver provides support for AMD Power ManagementController
primarily responsible for S2Idle transactions that are driven from
Quoted 6 lines
If you agree, please submit a patch with this change and I'll queue it up in my fixes branch.
Regards,
Hans
That's the primary reason, but you can technically also fetch an STB and read idle mask from debugfs even without debugfs set. I will weigh out both options and send something to fix this then.