netfilter: nft_fib: reverse path filter for policy-based routing on iif
Subsystems (2)
Pablo Neira Ayuso
maintainerPATCH 1/1 netfilter: nft_fib: reverse path filter for policy-based routing on iif
If policy-based routing using the iif selector is used, then the fib expression fails to look up for the reverse path from the prerouting hook because the input interface cannot be inferred. In order to support this scenario, extend the fib expression to allow to use after the route lookup, from the forward chain.
Signed-off-by Pablo Neira Ayuso <[email protected]>
--- net/ipv4/netfilter/nft_fib_ipv4.c | 4 ++++ net/ipv6/netfilter/nft_fib_ipv6.c | 4 ++++ net/netfilter/nft_fib.c | 2 ++ 3 files changed, 10 insertions(+)
net/ipv4/netfilter/nft_fib_ipv4.c +4 -0
@@ -112,6 +112,10 @@ void nft_fib4_eval(const struct nft_expr *expr, struct nft_regs *regs, fl4.daddr = iph->daddr; fl4.saddr =get_saddr (iph->saddr); }else { +if (nft_hook (pkt) ==NF_INET_FORWARD && + priv->flags &NFTA_FIB_F_IIF ) + fl4.flowi4_iif =nft_out (pkt)->ifindex; + fl4.daddr = iph->saddr; fl4.saddr =get_saddr (iph->daddr); }
net/ipv6/netfilter/nft_fib_ipv6.c +4 -0
@@ -30,6 +30,10 @@ static int nft_fib6_flowi_init(struct flowi6 *fl6, const struct nft_fib *priv, fl6->daddr = iph->daddr; fl6->saddr = iph->saddr; }else { +if (nft_hook (pkt) ==NF_INET_FORWARD && + priv->flags &NFTA_FIB_F_IIF ) + fl6->flowi6_iif =nft_out (pkt)->ifindex; + fl6->daddr = iph->saddr; fl6->saddr = iph->daddr; }
net/netfilter/nft_fib.c +2 -0
@@ -35,6 +35,8 @@ int nft_fib_validate(const struct nft_ctx *ctx, const struct nft_expr *expr,case NFT_FIB_RESULT_OIF :case NFT_FIB_RESULT_OIFNAME : hooks = (1 <<NF_INET_PRE_ROUTING ); +if (priv->flags &NFTA_FIB_F_IIF ) + hooks |= (1 <<NF_INET_FORWARD );break ;case NFT_FIB_RESULT_ADDRTYPE :if (priv->flags &NFTA_FIB_F_IIF )
Signature · 1 line
2.30.2
Quoted 5 lines · Pablo Neira Ayuso
If policy-based routing using the iif selector is used, then the fib expression fails to look up for the reverse path from the prerouting hook because the input interface cannot be inferred. In order to support this scenario, extend the fib expression to allow to use after the route lookup, from the forward chain.
LGTM,
Acked-by Florian Westphal <[email protected]>