Skip to contentSkip to conversation

ARM: dts: aspeed: romed8hm3: Add lm25066 sense resistor values

PATCH In review Zev Weiss 3 participants 5 messages Mar 31, 2022

Subsystems (2)
lore
Share & tools
lore

Zev Weiss

author
#0 lore raw

PATCH 1/2 ARM: dts: aspeed: romed8hm3: Add lm25066 sense resistor values

With this property set the sensor readings from these devices can now be calibrated properly.

---
 arch/arm/boot/dts/aspeed-bmc-asrock-romed8hm3.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/aspeed-bmc-asrock-romed8hm3.dts +2 -0
index e71ccfd1df63..572a43e57cac 100644
@@ -100,12 +100,14 @@ w83773g at 4c {
 	lm25066 at 40 {
 		compatible = "lm25066";
 		reg = <0x40>;
+		shunt-resistor-micro-ohms = <1000>;
 	};
 
 	/* 12VSB PMIC */
 	lm25066 at 41 {
 		compatible = "lm25066";
 		reg = <0x41>;
+		shunt-resistor-micro-ohms = <10000>;
 	};
 };
 
Signature · 1 line
2.35.1
author
#1 lore raw

PATCH 2/2 ARM: dts: aspeed: romed8hm3: Fix GPIOB0 name

This GPIO was mislabeled as DDR_MEM_TEMP in the schematic; after a correction from ASRock Rack its name now reflects its actual functionality (POST_COMPLETE_N).

---
 arch/arm/boot/dts/aspeed-bmc-asrock-romed8hm3.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/aspeed-bmc-asrock-romed8hm3.dts +1 -1
index 572a43e57cac..ff4c07c69af1 100644
@@ -198,7 +198,7 @@ &gpio {
 	gpio-line-names =
 		/*  A */ "LOCATORLED_STATUS_N", "BMC_MAC2_INTB", "NMI_BTN_N", "BMC_NMI",
 			"", "", "", "",
-		/*  B */ "DDR_MEM_TEMP", "", "", "", "", "", "", "",
+		/*  B */ "POST_COMPLETE_N", "", "", "", "", "", "", "",
 		/*  C */ "", "", "", "", "PCIE_HP_SEL_N", "PCIE_SATA_SEL_N", "LOCATORBTN", "",
 		/*  D */ "BMC_PSIN", "BMC_PSOUT", "BMC_RESETCON", "RESETCON",
 			"", "", "", "PSU_FAN_FAIL_N",
Signature · 1 line
2.35.1
maintainer Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] ARM: dts: aspeed: romed8hm3: Fix GPIOB0 name

Quoted 4 lines · Zev Weiss

This GPIO was mislabeled as DDR_MEM_TEMP in the schematic; after a correction from ASRock Rack its name now reflects its actual functionality (POST_COMPLETE_N).

Those are quite different functions :)

Quoted 2 lines
Fixes a9a3d60b937a ("ARM: dts: aspeed: Add ASRock ROMED8HM3 BMC")

I'll send some fixes in after -rc1.

Quoted 20 lines
---
 arch/arm/boot/dts/aspeed-bmc-asrock-romed8hm3.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/aspeed-bmc-asrock-romed8hm3.dts +1 -2
index 572a43e57cac..ff4c07c69af1 100644
@@ -198,7 +198,7 @@ &gpio {
        gpio-line-names =
                /*  A */ "LOCATORLED_STATUS_N", "BMC_MAC2_INTB", "NMI_BTN_N", "BMC_NMI",
                        "", "", "", "",
-               /*  B */ "DDR_MEM_TEMP", "", "", "", "", "", "", "",
+               /*  B */ "POST_COMPLETE_N", "", "", "", "", "", "", "",
                /*  C */ "", "", "", "", "PCIE_HP_SEL_N", "PCIE_SATA_SEL_N", "LOCATORBTN", "",
                /*  D */ "BMC_PSIN", "BMC_PSOUT", "BMC_RESETCON", "RESETCON",
                        "", "", "", "PSU_FAN_FAIL_N",
--

2.35.1

#3 lore raw

Re: [PATCH 2/2] ARM: dts: aspeed: romed8hm3: Fix GPIOB0 name

Quoted 8 lines · Joel Stanley
Quoted 4 lines · Zev Weiss

This GPIO was mislabeled as DDR_MEM_TEMP in the schematic; after a correction from ASRock Rack its name now reflects its actual functionality (POST_COMPLETE_N).

Those are quite different functions :)

Yes, rather -- that little tidbit resolved quite a bit of head-scratching that had been going on...

Quoted 4 lines
Quoted 2 lines
Fixes a9a3d60b937a ("ARM: dts: aspeed: Add ASRock ROMED8HM3 BMC")

Ah yes, I'll try to remember to include those to start with.

Quoted 4 lines

I'll send some fixes in after -rc1.

Thanks!

Zev

maintainer Reviewed-by on v1 1/2
#4 lore raw
In reply to Zev Weiss
Quoted 5 lines · Zev Weiss

With this property set the sensor readings from these devices can now be calibrated properly.

I guess:

Fixes a9a3d60b937a ("ARM: dts: aspeed: Add ASRock ROMED8HM3 BMC")

I'll send some fixes in after -rc1.

Quoted 26 lines
---
 arch/arm/boot/dts/aspeed-bmc-asrock-romed8hm3.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/aspeed-bmc-asrock-romed8hm3.dts +2 -1
index e71ccfd1df63..572a43e57cac 100644
@@ -100,12 +100,14 @@ w83773g at 4c {
        lm25066 at 40 {
                compatible = "lm25066";
                reg = <0x40>;
+               shunt-resistor-micro-ohms = <1000>;
        };
 
        /* 12VSB PMIC */
        lm25066 at 41 {
                compatible = "lm25066";
                reg = <0x41>;
+               shunt-resistor-micro-ohms = <10000>;
        };
 };
 
--

2.35.1