board: gateworks: venice: determine dram size at runtime
PATCH v2 1/1 board: gateworks: venice: determine dram size at runtime
The SPL does not update the memory node with the dram size from EEPROM but instead we can use get_ram_size which does a simple memory test to determine the available RAM. Update PHYS_SDRAM_SIZE to 4GiB as that is the max used on the Venice boards.
---
v2:
- bump PHYS_SDRAM_SIZE for imx8mn_venice to account for boards that have more than 1GiB of DRAM
- added Fabio's rb tag
--- board/gateworks/venice/venice.c | 13 ++----------- include/configs/imx8mm_venice.h | 2 +- include/configs/imx8mn_venice.h | 2 +- 3 files changed, 4 insertions(+), 13 deletions(-)
board/gateworks/venice/venice.c +2 -11
@@ -21,19 +21,10 @@ DECLARE_GLOBAL_DATA_PTR;int board_phys_sdram_size (phys_size_t *size) { -const fdt64_t *val; -int offset; -int len; - -/* get size from dt which SPL updated per EEPROM config */ - offset =fdt_path_offset (gd->fdt_blob,"/memory" ); -if (offset <0 ) +if (!size)return -EINVAL ; - val =fdt_getprop (gd->fdt_blob, offset,"reg" , &len); -if (len <sizeof (*val) *2 ) -return -EINVAL ; - *size =get_unaligned_be64 (&val[1 ]); + *size =get_ram_size ((void *)PHYS_SDRAM ,PHYS_SDRAM_SIZE );return 0 ; }
include/configs/imx8mm_venice.h +1 -1
@@ -83,7 +83,7 @@/* SDRAM configuration */ #define PHYS_SDRAM 0x40000000 -#define PHYS_SDRAM_SIZE SZ_1G/* 1GB DDR */ +#define PHYS_SDRAM_SIZE SZ_4G#define CONFIG_SYS_BOOTM_LEN SZ_256M/* UART */
include/configs/imx8mn_venice.h +1 -1
@@ -80,7 +80,7 @@/* SDRAM configuration */ #define PHYS_SDRAM 0x40000000 -#define PHYS_SDRAM_SIZE SZ_1G +#define PHYS_SDRAM_SIZE SZ_4G#define CONFIG_SYS_BOOTM_LEN SZ_256M/* UART */
Signature · 1 line
2.17.1
Fabio Estevam
reviewerHi Tim,
Quoted 8 lines · Tim Harvey
The SPL does not update the memory node with the dram size from EEPROM but instead we can use
get_ram_sizewhich does a simple memory test to determine the available RAM. UpdatePHYS_SDRAM_SIZEto 4GiB as that is the max used on the Venice boards.Signed-off-by Tim Harvey <[email protected]>Reviewed-by Fabio Estevam <[email protected]>
Is this 2022.04 material?
Quoted 10 lines · Fabio Estevam
Hi Tim,
Quoted 6 lines · Tim Harvey
The SPL does not update the memory node with the dram size from EEPROM but instead we can use
get_ram_sizewhich does a simple memory test to determine the available RAM. UpdatePHYS_SDRAM_SIZEto 4GiB as that is the max used on the Venice boards.
Quoted 4 lines
Quoted 2 lines
Signed-off-by Tim Harvey <[email protected]>Reviewed-by Fabio Estevam <[email protected]>Is this 2022.04 material?
Fabio,
Probably a good idea - without it the DRAM size is set to something that may not be appropriate and if larger than what's actually on the board could cause a crash if someone tried to allocate that memory.
Thanks,
Tim
Quoted 7 lines · Tim Harvey
The SPL does not update the memory node with the dram size from EEPROM but instead we can use
get_ram_sizewhich does a simple memory test to determine the available RAM. UpdatePHYS_SDRAM_SIZEto 4GiB as that is the max used on the Venice boards.Signed-off-by Tim Harvey <[email protected]>Reviewed-by Fabio Estevam <[email protected]>
Applied to u-boot/master, thanks!
Signature · 1 line
Tom