Skip to contentSkip to conversation

common/mlx5: fix MR range calculation

PATCH In review Dmitry Kozlyuk 2 participants 2 messages Mar 31, 2022 – Apr 12, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 common/mlx5: fix MR range calculation

MR end for a mempool chunk may be calculated incorrectly. For example, for chunk with addr=1.5M and len=1M with 2M page size the range would be [0, 2M), while the proper result is [0, 4M). Fix the calculation.

Fixes 690b2a88c2f7 ("common/mlx5: add mempool registration facilities")
---
 drivers/common/mlx5/mlx5_common_mr.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/common/mlx5/mlx5_common_mr.c +3 -2
index fa27bd98de..06e4c8f187 100644
@@ -1289,11 +1289,12 @@ mlx5_range_from_mempool_chunk(struct rte_mempool *mp, void *opaque,
 			      unsigned int idx)
 {
 	struct mlx5_range *ranges = opaque, *range = &ranges[idx];
+	uintptr_t start = (uintptr_t)memhdr->addr;
 	uint64_t page_size = rte_mem_page_size();
 
 	RTE_SET_USED(mp);
-	range->start = RTE_ALIGN_FLOOR((uintptr_t)memhdr->addr, page_size);
-	range->end = RTE_ALIGN_CEIL(range->start + memhdr->len, page_size);
+	range->start = RTE_ALIGN_FLOOR(start, page_size);
+	range->end = RTE_ALIGN_CEIL(start + memhdr->len, page_size);
 }
 
 /**
Signature · 1 line
2.25.1
#1 lore raw

Hi,

Quoted 13 lines

-----Original Message-----
From: Dmitry Kozlyuk <[email protected]>
Sent: Thursday, March 31, 2022 5:33 PM
To: [email protected]
Cc: [email protected]; Matan Azrad <[email protected]>; Slava Ovsiienko <[email protected]>
Subject: [PATCH] common/mlx5: fix MR range calculation

MR end for a mempool chunk may be calculated incorrectly. For example, for chunk with addr=1.5M and len=1M with 2M page size the range would be [0, 2M), while the proper result is [0, 4M). Fix the calculation.

Quoted 5 lines
Fixes 690b2a88c2f7 ("common/mlx5: add mempool registration facilities")

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh