Skip to contentSkip to conversation

add PSR-SU DPCD bitfield definitions as per eDP 1.5

PATCH Superseded David Zhang 3 participants 5 messages Mar 31, 2022 – Apr 1, 2022

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover add PSR-SU DPCD bitfield definitions as per eDP 1.5

*** BLURB HERE ***

David Zhang (1):
drm: add PSR2 support and capability definition as per eDP 1.5

 include/drm/drm_dp_helper.h | 2 ++
 1 file changed, 2 insertions(+)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 drm: add PSR2 support and capability definition as per eDP 1.5

[why & how]
In eDP 1.5 spec, some new DPCD bit fileds are defined for PSR-SU support.

---
 include/drm/drm_dp_helper.h | 2 ++
 1 file changed, 2 insertions(+)
include/drm/drm_dp_helper.h +2 -0
index 30359e434c3f..ac7b7571ae66 100644
@@ -361,6 +361,7 @@ struct drm_panel;
 # define DP_PSR_IS_SUPPORTED                1
 # define DP_PSR2_IS_SUPPORTED		    2	    /* eDP 1.4 */
 # define DP_PSR2_WITH_Y_COORD_IS_SUPPORTED  3	    /* eDP 1.4a */
+# define DP_PSR2_WITH_Y_COORD_ET_SUPPORTED  4	    /* eDP 1.5, adopted eDP 1.4b SCR */
 
 #define DP_PSR_CAPS                         0x071   /* XXX 1.2? */
 # define DP_PSR_NO_TRAIN_ON_EXIT            1
@@ -375,6 +376,7 @@ struct drm_panel;
 # define DP_PSR_SETUP_TIME_SHIFT            1
 # define DP_PSR2_SU_Y_COORDINATE_REQUIRED   (1 << 4)  /* eDP 1.4a */
 # define DP_PSR2_SU_GRANULARITY_REQUIRED    (1 << 5)  /* eDP 1.4b */
+# define DP_PSR2_SU_AUX_FRAME_SYNC_NOT_NEEDED (1 << 6)/* eDP 1.5, adopted eDP 1.4b SCR */
 
 #define DP_PSR2_SU_X_GRANULARITY	    0x072 /* eDP 1.4b */
 #define DP_PSR2_SU_Y_GRANULARITY	    0x074 /* eDP 1.4b */
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#2 lore raw

Re: [PATCH 1/1] drm: add PSR2 support and capability definition as per eDP 1.5

Quoted 2 lines · David Zhang

[why & how]
In eDP 1.5 spec, some new DPCD bit fileds are defined for PSR-SU

Please fix up the type in "fileds"

Quoted 3 lines

support.

With that fixed this patch is

Btw, you don't need to add a cover letter for a single patch. The patch alone is fine.

Harry

Quoted 24 lines
---
 include/drm/drm_dp_helper.h | 2 ++
 1 file changed, 2 insertions(+)
include/drm/drm_dp_helper.h +2 -0
index 30359e434c3f..ac7b7571ae66 100644
@@ -361,6 +361,7 @@ struct drm_panel;
 # define DP_PSR_IS_SUPPORTED                1
 # define DP_PSR2_IS_SUPPORTED		    2	    /* eDP 1.4 */
 # define DP_PSR2_WITH_Y_COORD_IS_SUPPORTED  3	    /* eDP 1.4a */
+# define DP_PSR2_WITH_Y_COORD_ET_SUPPORTED  4	    /* eDP 1.5, adopted eDP 1.4b SCR */
 
 #define DP_PSR_CAPS                         0x071   /* XXX 1.2? */
 # define DP_PSR_NO_TRAIN_ON_EXIT            1
@@ -375,6 +376,7 @@ struct drm_panel;
 # define DP_PSR_SETUP_TIME_SHIFT            1
 # define DP_PSR2_SU_Y_COORDINATE_REQUIRED   (1 << 4)  /* eDP 1.4a */
 # define DP_PSR2_SU_GRANULARITY_REQUIRED    (1 << 5)  /* eDP 1.4b */
+# define DP_PSR2_SU_AUX_FRAME_SYNC_NOT_NEEDED (1 << 6)/* eDP 1.5, adopted eDP 1.4b SCR */
 
 #define DP_PSR2_SU_X_GRANULARITY	    0x072 /* eDP 1.4b */
 #define DP_PSR2_SU_Y_GRANULARITY	    0x074 /* eDP 1.4b */
#3 lore raw

Re: [PATCH 1/1] drm: add PSR2 support and capability definition as per eDP 1.5

In reply to David Zhang

Dear David,

Thank you for your patch.

Am 31.03.22 um 19:26 schrieb David Zhang:

Quoted 3 lines

[why & how]
In eDP 1.5 spec, some new DPCD bit fileds are defined for PSR-SU support.

You could be specific by using the exact number two. Maybe:

As per eDP 1.5 specification, add the two DPCD bit fields below for PSR-SU support:

1. DP_PSR2_WITH_Y_COORD_ET_SUPPORTED
2. DP_PSR2_SU_AUX_FRAME_SYNC_NOT_NEEDED

Kind regards,

Paul

Quoted 25 lines
---
  include/drm/drm_dp_helper.h | 2 ++
  1 file changed, 2 insertions(+)
include/drm/drm_dp_helper.h +2 -0
index 30359e434c3f..ac7b7571ae66 100644
@@ -361,6 +361,7 @@ struct drm_panel;
  # define DP_PSR_IS_SUPPORTED                1
  # define DP_PSR2_IS_SUPPORTED		    2	    /* eDP 1.4 */
  # define DP_PSR2_WITH_Y_COORD_IS_SUPPORTED  3	    /* eDP 1.4a */
+# define DP_PSR2_WITH_Y_COORD_ET_SUPPORTED  4	    /* eDP 1.5, adopted eDP 1.4b SCR */
 
  #define DP_PSR_CAPS                         0x071   /* XXX 1.2? */
  # define DP_PSR_NO_TRAIN_ON_EXIT            1
@@ -375,6 +376,7 @@ struct drm_panel;
  # define DP_PSR_SETUP_TIME_SHIFT            1
  # define DP_PSR2_SU_Y_COORDINATE_REQUIRED   (1 << 4)  /* eDP 1.4a */
  # define DP_PSR2_SU_GRANULARITY_REQUIRED    (1 << 5)  /* eDP 1.4b */
+# define DP_PSR2_SU_AUX_FRAME_SYNC_NOT_NEEDED (1 << 6)/* eDP 1.5, adopted eDP 1.4b SCR */
 
  #define DP_PSR2_SU_X_GRANULARITY	    0x072 /* eDP 1.4b */
  #define DP_PSR2_SU_Y_GRANULARITY	    0x074 /* eDP 1.4b */
#4 lore raw

Re: [PATCH 1/1] drm: add PSR2 support and capability definition as per eDP 1.5

[AMD Official Use Only]

Hi Paul and Harry,

Thanks for reviewing the patch and commit msg has been revised as per your comments in the v2.

From: Paul Menzel <[email protected]>
Sent: Friday, April 1, 2022 1:46 AM
To: Zhang, Dingchen (David) <[email protected]>
Cc: [email protected] <[email protected]>; [email protected] <[email protected]>; Wang, Chao-kai (Stylon) <[email protected]>; [email protected] <[email protected]>; Li, Sun peng (Leo) <[email protected]>; Wentland, Harry <[email protected]>; Zhuo, Qingqing (Lillian) <[email protected]>; Siqueira, Rodrigo <[email protected]>; Li, Roman <[email protected]>; Chiu, Solomon <[email protected]>; Zuo, Jerry <[email protected]>; Pillai, Aurabindo <[email protected]>; [email protected] <[email protected]>; Lin, Wayne <[email protected]>; Lakha, Bhawanpreet <[email protected]>; Gutierrez, Agustin <[email protected]>; Kotarac, Pavle <[email protected]>
Subject: Re: [PATCH 1/1] drm: add PSR2 support and capability definition as per eDP 1.5

Dear David,

Thank you for your patch.

Am 31.03.22 um 19:26 schrieb David Zhang:

Quoted 3 lines

[why & how]
In eDP 1.5 spec, some new DPCD bit fileds are defined for PSR-SU support.

You could be specific by using the exact number two. Maybe:

As per eDP 1.5 specification, add the two DPCD bit fields below for PSR-SU support:

1. DP_PSR2_WITH_Y_COORD_ET_SUPPORTED
2. DP_PSR2_SU_AUX_FRAME_SYNC_NOT_NEEDED

Kind regards,

Paul

Quoted 25 lines
---
  include/drm/drm_dp_helper.h | 2 ++
  1 file changed, 2 insertions(+)
include/drm/drm_dp_helper.h +2 -0
index 30359e434c3f..ac7b7571ae66 100644
@@ -361,6 +361,7 @@ struct drm_panel;
  # define DP_PSR_IS_SUPPORTED                1
  # define DP_PSR2_IS_SUPPORTED                   2        /* eDP 1.4 */
  # define DP_PSR2_WITH_Y_COORD_IS_SUPPORTED  3           /* eDP 1.4a */
+# define DP_PSR2_WITH_Y_COORD_ET_SUPPORTED  4            /* eDP 1.5, adopted eDP 1.4b SCR */
 
  #define DP_PSR_CAPS                         0x071   /* XXX 1.2? */
  # define DP_PSR_NO_TRAIN_ON_EXIT            1
@@ -375,6 +376,7 @@ struct drm_panel;
  # define DP_PSR_SETUP_TIME_SHIFT            1
  # define DP_PSR2_SU_Y_COORDINATE_REQUIRED   (1 << 4)  /* eDP 1.4a */
  # define DP_PSR2_SU_GRANULARITY_REQUIRED    (1 << 5)  /* eDP 1.4b */
+# define DP_PSR2_SU_AUX_FRAME_SYNC_NOT_NEEDED (1 << 6)/* eDP 1.5, adopted eDP 1.4b SCR */
 
  #define DP_PSR2_SU_X_GRANULARITY        0x072 /* eDP 1.4b */
  #define DP_PSR2_SU_Y_GRANULARITY        0x074 /* eDP 1.4b */