Skip to contentSkip to conversation

dt-bindings: clock: convert rockchip,rk3288-cru.txt to YAML

PATCH Applied Johan Jonker 4 participants 5 messages Mar 29, 2022 – May 17, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 dt-bindings: clock: convert rockchip,rk3288-cru.txt to YAML

Current dts files with RK3288 'cru' nodes are manually verified. In order to automate this process rockchip,rk3288-cru.txt has to be converted to YAML.

Changed:
Add properties to fix notifications by clocks.yaml for example:
clocks
clock-names

---

Changed V2:
add Rockchip maintainer on her request
fix yamllint line too long
restyle

---
 .../bindings/clock/rockchip,rk3288-cru.txt    | 67 ---------------
 .../bindings/clock/rockchip,rk3288-cru.yaml   | 85 +++++++++++++++++++
 2 files changed, 85 insertions(+), 67 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3288-cru.txt
 create mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3288-cru.yaml
Documentation/devicetree/bindings/clock/rockchip,rk3288-cru.txt deleted +0 -67
deleted file mode 100644
index bf3a9ec19..000000000
@@ -1,67 +0,0 @@
-* Rockchip RK3288 Clock and Reset Unit
-
-The RK3288 clock controller generates and supplies clock to various
-controllers within the SoC and also implements a reset controller for SoC
-peripherals.
-
-A revision of this SoC is available: rk3288w. The clock tree is a bit
-different so another dt-compatible is available. Noticed that it is only
-setting the difference but there is no automatic revision detection. This
-should be performed by bootloaders.
-
-Required Properties:
-
-- compatible: should be "rockchip,rk3288-cru" or "rockchip,rk3288w-cru" in
-  case of this revision of Rockchip rk3288.
-- reg: physical base address of the controller and length of memory mapped
-  region.
-- #clock-cells: should be 1.
-- #reset-cells: should be 1.
-
-Optional Properties:
-
-- rockchip,grf: phandle to the syscon managing the "general register files"
-  If missing pll rates are not changeable, due to the missing pll lock status.
-
-Each clock is assigned an identifier and client nodes can use this identifier
-to specify the clock which they consume. All available clocks are defined as
-preprocessor macros in the dt-bindings/clock/rk3288-cru.h headers and can be
-used in device tree sources. Similar macros exist for the reset sources in
-these files.
-
-External clocks:
-
-There are several clocks that are generated outside the SoC. It is expected
-that they are defined using standard clock bindings with following
-clock-output-names:
- - "xin24m" - crystal input - required,
- - "xin32k" - rtc clock - optional,
- - "ext_i2s" - external I2S clock - optional,
- - "ext_hsadc" - external HSADC clock - optional,
- - "ext_edp_24m" - external display port clock - optional,
- - "ext_vip" - external VIP clock - optional,
- - "ext_isp" - external ISP clock - optional,
- - "ext_jtag" - external JTAG clock - optional
-
-Example: Clock controller node:
-
-	cru: cru@20000000 {
-		compatible = "rockchip,rk3188-cru";
-		reg = <0x20000000 0x1000>;
-		rockchip,grf = <&grf>;
-
-		#clock-cells = <1>;
-		#reset-cells = <1>;
-	};
-
-Example: UART controller node that consumes the clock generated by the clock
-  controller:
-
-	uart0: serial@10124000 {
-		compatible = "snps,dw-apb-uart";
-		reg = <0x10124000 0x400>;
-		interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
-		reg-shift = <2>;
-		reg-io-width = <1>;
-		clocks = <&cru SCLK_UART0>;
-	};
Documentation/devicetree/bindings/clock/rockchip,rk3288-cru.yaml new file +85 -0

85 lines not on this page · raw message

Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 2/2 ARM: dts: rockchip: add clocks property to cru node rk3288

Add clocks property to rk3288 cru node to fix warnings like:
'clocks' is a dependency of 'assigned-clocks'.

---
 arch/arm/boot/dts/rk3288.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/rk3288.dtsi +2 -0
index 26b9bbe31..487b0e03d 100644
@@ -862,6 +862,8 @@
 	cru: clock-controller@ff760000 {
 		compatible = "rockchip,rk3288-cru";
 		reg = <0x0 0xff760000 0x0 0x1000>;
+		clocks = <&xin24m>;
+		clock-names = "xin24m";
 		rockchip,grf = <&grf>;
 		#clock-cells = <1>;
 		#reset-cells = <1>;
Signature · 1 line
2.20.1
Reviewed-by on v2 1/2
#2 lore raw

Re: [PATCH v2 1/2] dt-bindings: clock: convert rockchip, rk3288-cru.txt to YAML

In reply to Johan Jonker
Quoted 11 lines · Johan Jonker

Current dts files with RK3288 'cru' nodes are manually verified. In order to automate this process rockchip,rk3288-cru.txt has to be converted to YAML.

Changed:
Add properties to fix notifications by clocks.yaml for example:
clocks
clock-names

---

You missed my review tag. The changes between v1 and v2 were minor, so please always include it in your next versions or resends.

Best regards,
Krzysztof

maintainer
#3 lore raw
In reply to Johan Jonker

Quoting Johan Jonker (2022-03-29 04:36:56)

Quoted 11 lines

Current dts files with RK3288 'cru' nodes are manually verified. In order to automate this process rockchip,rk3288-cru.txt has to be converted to YAML.

Changed:
Add properties to fix notifications by clocks.yaml for example:
clocks
clock-names

---

Same comments about clocks applies here. Please send a cover letter anytime there's more than one patch being sent so that we can easily see the topic at a top-level of the patch series "Convert Rockchip clk bindings to yaml and add clocks property". Furthermore, I don't see why we need to have a different series for each file. Just combine everything into one series please with a cover letter.

maintainer Applied
#4 lore raw
In reply to Johan Jonker
Quoted 8 lines · Johan Jonker

Current dts files with RK3288 'cru' nodes are manually verified. In order to automate this process rockchip,rk3288-cru.txt has to be converted to YAML.

Changed:
Add properties to fix notifications by clocks.yaml for example:
clocks
clock-names

Applied, thanks!

[1/2] dt-bindings: clock: convert rockchip,rk3288-cru.txt to YAML

      commit: 03339ecc41201218eb2e9fa191bfa84b86cf26fd
[2/2] ARM: dts: rockchip: add clocks property to cru node rk3288
      commit: 1b36d43799187791750aa73286f0e2530f67f003

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>