Skip to contentSkip to conversation

scsi: pm8001: Fix resource leak in pm8001_send_abort_all()

PATCH New Jianglei Nie 1 participant 1 message Apr 1, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: pm8001: Fix resource leak in pm8001_send_abort_all()

sas_alloc_slow_task() allocates a task in line 1774. But when pm8001_tag_alloc() or pm8001_mpi_build_cmd() fail, the allocated task is not freed by sas_free_task(), which will lead to resource leak.

We can fix it by freeing the task when pm8001_tag_alloc() and pm8001_mpi_build_cmd() fail.

---
 drivers/scsi/pm8001/pm8001_hwi.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/scsi/pm8001/pm8001_hwi.c +6 -3
index 9ec310b795c3..fec5e26fbf0f 100644
@@ -1781,8 +1781,10 @@ static void pm8001_send_abort_all(struct pm8001_hba_info *pm8001_ha,
 	task->task_done = pm8001_task_done;
 
 	res = pm8001_tag_alloc(pm8001_ha, &ccb_tag);
-	if (res)
+	if (res) {
+		sas_free_task(task);
 		return;
+	}
 
 	ccb = &pm8001_ha->ccb_info[ccb_tag];
 	ccb->device = pm8001_ha_dev;
@@ -1798,9 +1800,10 @@ static void pm8001_send_abort_all(struct pm8001_hba_info *pm8001_ha,
 
 	ret = pm8001_mpi_build_cmd(pm8001_ha, circularQ, opc, &task_abort,
 			sizeof(task_abort), 0);
-	if (ret)
+	if (ret) {
+		sas_free_task(task);
 		pm8001_tag_free(pm8001_ha, ccb_tag);
-
+	}
 }
 
 static void pm8001_send_read_log(struct pm8001_hba_info *pm8001_ha,
Signature · 1 line
2.25.1