tests/kms_display_modes: Skip this test on DP MST config
PATCH 1/1 tests/kms_display_modes: Skip this test on DP MST config
currently this test fails on dp-mst setup. so, with this fix test will skip which is expected for extended mode test case.
--- tests/kms_display_modes.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
tests/kms_display_modes.c +11 -0
@@ -135,6 +135,8 @@ igt_mainint valid_output =0 , i, j =0 ;igt_output_t *output;int pipe[IGT_MAX_PIPES ]; +struct kmstest_connector_config config; +const char *encoder; igt_fixture { data.drm_fd =drm_open_driver_master (DRIVER_ANY );
@@ -146,6 +148,11 @@ igt_mainif (valid_output >1 )break ; + +kmstest_get_connector_config (data.drm_fd, + output->config.connector->connector_id, +-1 , &config); + encoder =kmstest_encoder_type_str (config.encoder->encoder_type); } data.n_pipes =0 ;
@@ -160,6 +167,10 @@ igt_mainigt_describe ("Test for validating display extended mode with a pair of connected displays" ); igt_subtest_with_dynamic("extended-mode-basic") { + +if (strcmp (encoder,"DP MST" ) ==0 ) +igt_skip ("Test dosen't support DP MST\n" ); +for (i =0 ; i < data.n_pipes -1 ; i++) {igt_dynamic_f ("pipe-%s%s" ,kmstest_pipe_name (pipe[i]),kmstest_pipe_name (pipe[i+1 ]));
Signature · 1 line
2.35.1
Quoted 2 lines · Jeevan B
currently this test fails on dp-mst setup. so, with this fix test will skip which is expected for extended mode test case.
Why is it expected?
Just "this test fails" is not a good reason to introduce explicit skips. You have to explain why that case is not a kernel bug.
Signature · 1 line
Petri Latvala
Quoted 45 lines
Signed-off-by Jeevan B <[email protected]>--- tests/kms_display_modes.c | 11 +++++++++++ 1 file changed, 11 insertions(+)tests/kms_display_modes.c +11
-0@@ -135,6 +135,8 @@ igt_mainint valid_output =0 , i, j =0 ;igt_output_t *output;int pipe[IGT_MAX_PIPES ]; +struct kmstest_connector_config config; +const char *encoder; igt_fixture { data.drm_fd =drm_open_driver_master (DRIVER_ANY );@@ -146,6 +148,11 @@ igt_mainif (valid_output >1 )break ; + +kmstest_get_connector_config (data.drm_fd, + output->config.connector->connector_id, +-1 , &config); + encoder =kmstest_encoder_type_str (config.encoder->encoder_type); } data.n_pipes =0 ;@@ -160,6 +167,10 @@ igt_mainigt_describe ("Test for validating display extended mode with a pair of connected displays" ); igt_subtest_with_dynamic("extended-mode-basic") { + +if (strcmp (encoder,"DP MST" ) ==0 ) +igt_skip ("Test dosen't support DP MST\n" ); +for (i =0 ; i < data.n_pipes -1 ; i++) {igt_dynamic_f ("pipe-%s%s" ,kmstest_pipe_name (pipe[i]),kmstest_pipe_name (pipe[i+1 ]));Signature · 1 line
2.35.1
Patchwork
CI[igt-dev] ✗ GitLab.Pipeline: warning for tests/kms_display_modes: Skip this test on DP MST config
In reply to Jeevan B== Series Details ==
== Series Details ==
Series: tests/kms_display_modes: Skip this test on DP MST config
URL : https://patchwork.freedesktop.org/series/102063/
State : warning
== Summary ==
Pipeline status: FAILED.
see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/547722 for the overview.
test:ninja-test-arm64 has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/20606530):
Ok: 22
Expected Fail: 3
Fail: 287
Unexpected Pass: 0 Skipped: 0 Timeout: 0
Full log written to /builds/gfx-ci/igt-ci-tags/build/meson-logs/testlog.txt section_end:1648811202:step_script
section_start:1648811202:upload_artifacts_on_failure
Uploading artifacts for failed job
Uploading artifacts...
build: found 1712 matching files and directories
Uploading artifacts as "archive" to coordinator... 201 Created id=20606530 responseStatus=201 Created token=Q8UcQRtW section_end:1648811213:upload_artifacts_on_failure
section_start:1648811213:cleanup_file_variables
Cleaning up project directory and file based variables section_end:1648811214:cleanup_file_variables
ERROR: Job failed: exit code 1
== Logs ==
For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/547722
Patchwork
CI[igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_display_modes: Skip this test on DP MST config
In reply to Jeevan B== Series Details ==
== Series Details ==
Series: tests/kms_display_modes: Skip this test on DP MST config
URL : https://patchwork.freedesktop.org/series/102063/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11437 -> IGTPW_6856
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_6856 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_6856, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/index.html
Participating hosts (42 -> 40)
------------------------------
Additional (3): fi-hsw-4770 fi-icl-u2 fi-tgl-u2
Missing (5): shard-tglu fi-bsw-cyan fi-pnv-d510 shard-rkl fi-bdw-samus
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_6856:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_rpm@module-reload:
- fi-cfl-8109u: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11437/fi-cfl-8109u/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-cfl-8109u/igt@[email protected]
Known issues
------------
Here are the changes found in IGTPW_6856 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-gfx:
- fi-hsw-4770: NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#109315]) +17 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-hsw-4770/igt@amdgpu/[email protected]
* igt@amdgpu/amd_cs_nop@fork-gfx0:
- fi-icl-u2: NOTRUN -> [SKIP][4] ([fdo#109315]) +17 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-icl-u2/igt@amdgpu/[email protected]
* igt@gem_exec_suspend@basic-s3@smem:
- fi-rkl-11600: [PASS][5] -> [INCOMPLETE][6] ([i915#5127])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11437/fi-rkl-11600/igt@gem_exec_suspend@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-rkl-11600/igt@gem_exec_suspend@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-tgl-u2: NOTRUN -> [SKIP][7] ([i915#2190])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-tgl-u2/igt@[email protected]
- fi-hsw-4770: NOTRUN -> [SKIP][8] ([fdo#109271]) +9 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-hsw-4770/igt@[email protected]
- fi-icl-u2: NOTRUN -> [SKIP][9] ([i915#2190])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-icl-u2/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][10] ([i915#4613]) +3 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-icl-u2/igt@[email protected]
* igt@gem_lmem_swapping@verify-random:
- fi-tgl-u2: NOTRUN -> [SKIP][11] ([i915#4613]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-tgl-u2/igt@[email protected]
* igt@i915_pm_backlight@basic-brightness:
- fi-hsw-4770: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#3012])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-hsw-4770/igt@[email protected]
* igt@kms_busy@basic@flip:
- fi-tgl-u2: NOTRUN -> [DMESG-WARN][13] ([i915#402])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-tgl-u2/igt@kms_busy@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-4770: NOTRUN -> [SKIP][14] ([fdo#109271] / [fdo#111827]) +8 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-hsw-4770/igt@[email protected]
* igt@kms_chamelium@dp-hpd-fast:
- fi-tgl-u2: NOTRUN -> [SKIP][15] ([fdo#109284] / [fdo#111827]) +8 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-tgl-u2/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][16] ([fdo#111827]) +8 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-icl-u2/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-tgl-u2: NOTRUN -> [SKIP][17] ([i915#4103]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-tgl-u2/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: NOTRUN -> [SKIP][18] ([fdo#109278]) +2 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-icl-u2/igt@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- fi-tgl-u2: NOTRUN -> [SKIP][19] ([fdo#109285])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-tgl-u2/igt@[email protected]
- fi-icl-u2: NOTRUN -> [SKIP][20] ([fdo#109285])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-icl-u2/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-hsw-4770: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#533])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-hsw-4770/igt@[email protected]
* igt@kms_psr@primary_mmap_gtt:
- fi-hsw-4770: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#1072]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-hsw-4770/igt@kms_psr@primary_mmap_gtt.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-icl-u2: NOTRUN -> [SKIP][23] ([i915#3555])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-icl-u2/igt@[email protected]
- fi-tgl-u2: NOTRUN -> [SKIP][24] ([i915#3555])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-tgl-u2/igt@[email protected]
* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][25] ([i915#3301])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/fi-icl-u2/igt@[email protected]
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- {bat-adlp-6}: [DMESG-WARN][26] ([i915#3576]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11437/bat-adlp-6/igt@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/bat-adlp-6/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5127]: https://gitlab.freedesktop.org/drm/intel/issues/5127
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_6404 -> IGTPW_6856
CI-20190529: 20190529
CI_DRM_11437: a75f66f3417815fd54ff41017c02436cbc7aa666 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6856: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/index.html
IGT_6404: b6805229aaf5c1d6c85ec35eebf3a41f8a12f66c @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6856/index.html