Skip to contentSkip to conversation

imx: power-domain: Add i.MX8MP HSIOMIX driver

PATCH Superseded Marek Vasut 2 participants 2 messages Apr 1, 2022 – Apr 7, 2022 Arm i.MX and Layerscape

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 imx: power-domain: Add i.MX8MP HSIOMIX driver

Add trivial driver for i.MX8MP HSIOMIX handling. This is responsible for enabling the GPCv2 power domains and clock for USB 3.0 and PCIe in the correct order. Currently supported is the USB 3.0 part which can be tested, PCIe support should be easy to add.

Cc Fabio Estevam <[email protected]>
Cc Peng Fan <[email protected]>
Cc Stefano Babic <[email protected]>

---
V2: Drop two left over unused variables which triggered build warning

---
 drivers/power/domain/Kconfig          |   7 ++
 drivers/power/domain/Makefile         |   1 +
 drivers/power/domain/imx8mp-hsiomix.c | 159 ++++++++++++++++++++++++++
 3 files changed, 167 insertions(+)
 create mode 100644 drivers/power/domain/imx8mp-hsiomix.c
drivers/power/domain/Kconfig +7 -0
index 04fc0054323..7e1b8c072fa 100644
@@ -40,6 +40,13 @@ config IMX8M_POWER_DOMAIN
 	  Enable support for manipulating NXP i.MX8M on-SoC power domains via
 	  requests to the ATF.
 
+config IMX8MP_HSIOMIX_BLKCTRL
+	bool "Enable i.MX8MP HSIOMIX domain driver"
+	depends on POWER_DOMAIN && IMX8MP
+	select CLK
+	help
+	  Enable support for manipulating NXP i.MX8MP on-SoC HSIOMIX block controller.
+
 config MTK_POWER_DOMAIN
 	bool "Enable the MediaTek power domain driver"
 	depends on POWER_DOMAIN && ARCH_MEDIATEK
drivers/power/domain/Makefile +1 -0
index 7c8af67dbd6..e6244776216 100644
@@ -8,6 +8,7 @@ obj-$(CONFIG_APPLE_PMGR_POWER_DOMAIN) += apple-pmgr.o
 obj-$(CONFIG_BCM6328_POWER_DOMAIN) += bcm6328-power-domain.o
 obj-$(CONFIG_IMX8_POWER_DOMAIN) += imx8-power-domain-legacy.o imx8-power-domain.o
 obj-$(CONFIG_IMX8M_POWER_DOMAIN) += imx8m-power-domain.o
+obj-$(CONFIG_IMX8MP_HSIOMIX_BLKCTRL) += imx8mp-hsiomix.o
 obj-$(CONFIG_MTK_POWER_DOMAIN) += mtk-power-domain.o
 obj-$(CONFIG_MESON_GX_VPU_POWER_DOMAIN) += meson-gx-pwrc-vpu.o
 obj-$(CONFIG_MESON_EE_POWER_DOMAIN) += meson-ee-pwrc.o
drivers/power/domain/imx8mp-hsiomix.c new file +159 -0

159 lines not on this page · raw message

Signature · 1 line
2.35.1
Tested-by on v2 1/1
#1 lore raw
Quoted 215 lines · Marek Vasut

Add trivial driver for i.MX8MP HSIOMIX handling. This is responsible for enabling the GPCv2 power domains and clock for USB 3.0 and PCIe in the correct order. Currently supported is the USB 3.0 part which can be tested, PCIe support should be easy to add.

Cc Fabio Estevam <[email protected]>
Cc Peng Fan <[email protected]>
Cc Stefano Babic <[email protected]>

---
V2: Drop two left over unused variables which triggered build warning

---
 drivers/power/domain/Kconfig          |   7 ++
 drivers/power/domain/Makefile         |   1 +
 drivers/power/domain/imx8mp-hsiomix.c | 159 ++++++++++++++++++++++++++
 3 files changed, 167 insertions(+)
 create mode 100644 drivers/power/domain/imx8mp-hsiomix.c
drivers/power/domain/Kconfig +7 -0
index 04fc0054323..7e1b8c072fa 100644
@@ -40,6 +40,13 @@ config IMX8M_POWER_DOMAIN
          Enable support for manipulating NXP i.MX8M on-SoC power domains via
          requests to the ATF.
 
+config IMX8MP_HSIOMIX_BLKCTRL
+       bool "Enable i.MX8MP HSIOMIX domain driver"
+       depends on POWER_DOMAIN && IMX8MP
+       select CLK
+       help
+         Enable support for manipulating NXP i.MX8MP on-SoC HSIOMIX block controller.
+
 config MTK_POWER_DOMAIN
        bool "Enable the MediaTek power domain driver"
        depends on POWER_DOMAIN && ARCH_MEDIATEK
drivers/power/domain/Makefile +1 -0
index 7c8af67dbd6..e6244776216 100644
@@ -8,6 +8,7 @@ obj-$(CONFIG_APPLE_PMGR_POWER_DOMAIN) += apple-pmgr.o
 obj-$(CONFIG_BCM6328_POWER_DOMAIN) += bcm6328-power-domain.o
 obj-$(CONFIG_IMX8_POWER_DOMAIN) += imx8-power-domain-legacy.o imx8-power-domain.o
 obj-$(CONFIG_IMX8M_POWER_DOMAIN) += imx8m-power-domain.o
+obj-$(CONFIG_IMX8MP_HSIOMIX_BLKCTRL) += imx8mp-hsiomix.o
 obj-$(CONFIG_MTK_POWER_DOMAIN) += mtk-power-domain.o
 obj-$(CONFIG_MESON_GX_VPU_POWER_DOMAIN) += meson-gx-pwrc-vpu.o
 obj-$(CONFIG_MESON_EE_POWER_DOMAIN) += meson-ee-pwrc.o
drivers/power/domain/imx8mp-hsiomix.c new file +159 -1
new file mode 100644
index 00000000000..6a721a934a7
@@ -0,0 +1,159 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2022 Marek Vasut <[email protected]>
+ */
+
+#include <common.h>
+#include <asm/io.h>
+#include <clk.h>
+#include <dm.h>
+#include <dm/device.h>
+#include <dm/device_compat.h>
+#include <power-domain-uclass.h>
+
+#include <dt-bindings/power/imx8mp-power.h>
+
+#define GPR_REG0               0x0
+#define  PCIE_CLOCK_MODULE_EN  BIT(0)
+#define  USB_CLOCK_MODULE_EN   BIT(1)
+
+struct imx8mp_hsiomix_priv {
+       void __iomem *base;
+       struct clk clk_usb;
+       struct power_domain pd_bus;
+       struct power_domain pd_usb;
+       struct power_domain pd_usb_phy1;
+       struct power_domain pd_usb_phy2;
+};
+
+static int imx8mp_hsiomix_on(struct power_domain *power_domain)
+{
+       struct udevice *dev = power_domain->dev;
+       struct imx8mp_hsiomix_priv *priv = dev_get_priv(dev);
+       struct power_domain *domain;
+       int ret;
+
+       ret = power_domain_on(&priv->pd_bus);
+       if (ret)
+               return ret;
+
+       if (power_domain->id == IMX8MP_HSIOBLK_PD_USB) {
+               domain = &priv->pd_usb;
+       } else if (power_domain->id == IMX8MP_HSIOBLK_PD_USB_PHY1) {
+               domain = &priv->pd_usb_phy1;
+       } else if (power_domain->id == IMX8MP_HSIOBLK_PD_USB_PHY2) {
+               domain = &priv->pd_usb_phy2;
+       } else {
+               ret = -EINVAL;
+               goto err_pd;
+       }
+
+       ret = power_domain_on(domain);
+       if (ret)
+               goto err_pd;
+
+       ret = clk_enable(&priv->clk_usb);
+       if (ret)
+               goto err_clk;
+
+       if (power_domain->id == IMX8MP_HSIOBLK_PD_USB)
+               setbits_le32(priv->base + GPR_REG0, USB_CLOCK_MODULE_EN);
+
+       return 0;
+
+err_clk:
+       power_domain_off(domain);
+err_pd:
+       power_domain_off(&priv->pd_bus);
+       return ret;
+}
+
+static int imx8mp_hsiomix_off(struct power_domain *power_domain)
+{
+       struct udevice *dev = power_domain->dev;
+       struct imx8mp_hsiomix_priv *priv = dev_get_priv(dev);
+
+       if (power_domain->id == IMX8MP_HSIOBLK_PD_USB)
+               clrbits_le32(priv->base + GPR_REG0, USB_CLOCK_MODULE_EN);
+
+       clk_disable(&priv->clk_usb);
+
+       if (power_domain->id == IMX8MP_HSIOBLK_PD_USB)
+               power_domain_off(&priv->pd_usb);
+       else if (power_domain->id == IMX8MP_HSIOBLK_PD_USB_PHY1)
+               power_domain_off(&priv->pd_usb_phy1);
+       else if (power_domain->id == IMX8MP_HSIOBLK_PD_USB_PHY2)
+               power_domain_off(&priv->pd_usb_phy2);
+
+       power_domain_off(&priv->pd_bus);
+
+       return 0;
+}
+
+static int imx8mp_hsiomix_of_xlate(struct power_domain *power_domain,
+                                  struct ofnode_phandle_args *args)
+{
+       power_domain->id = args->args[0];
+
+       return 0;
+}
+
+static int imx8mp_hsiomix_probe(struct udevice *dev)
+{
+       struct imx8mp_hsiomix_priv *priv = dev_get_priv(dev);
+       int ret;
+
+       priv->base = dev_read_addr_ptr(dev);
+
+       ret = clk_get_by_name(dev, "usb", &priv->clk_usb);
+       if (ret < 0)
+               return ret;
+
+       ret = power_domain_get_by_name(dev, &priv->pd_bus, "bus");
+       if (ret < 0)
+               goto err_pd_bus;
+
+       ret = power_domain_get_by_name(dev, &priv->pd_usb, "usb");
+       if (ret < 0)
+               goto err_pd_usb;
+
+       ret = power_domain_get_by_name(dev, &priv->pd_usb_phy1, "usb-phy1");
+       if (ret < 0)
+               goto err_pd_usb_phy1;
+
+       ret = power_domain_get_by_name(dev, &priv->pd_usb_phy2, "usb-phy2");
+       if (ret < 0)
+               goto err_pd_usb_phy2;
+
+       return 0;
+
+err_pd_usb_phy2:
+       power_domain_free(&priv->pd_usb_phy1);
+err_pd_usb_phy1:
+       power_domain_free(&priv->pd_usb);
+err_pd_usb:
+       power_domain_free(&priv->pd_bus);
+err_pd_bus:
+       clk_free(&priv->clk_usb);
+       return ret;
+}
+
+static const struct udevice_id imx8mp_hsiomix_ids[] = {
+       { .compatible = "fsl,imx8mp-hsio-blk-ctrl" },
+       { }
+};
+
+struct power_domain_ops imx8mp_hsiomix_ops = {
+       .on = imx8mp_hsiomix_on,
+       .off = imx8mp_hsiomix_off,
+       .of_xlate = imx8mp_hsiomix_of_xlate,
+};
+
+U_BOOT_DRIVER(imx8mp_hsiomix) = {
+       .name           = "imx8mp_hsiomix",
+       .id             = UCLASS_POWER_DOMAIN,
+       .of_match       = imx8mp_hsiomix_ids,
+       .probe          = imx8mp_hsiomix_probe,
+       .priv_auto      = sizeof(struct imx8mp_hsiomix_priv),
+       .ops            = &imx8mp_hsiomix_ops,
+};
--
Quoted 2 lines

2.35.1

Marek,

Thanks for submitting this!

Best Regards,

Tim