target/i386: Suppress coverity warning on fsave/frstor
PATCH 1/1 target/i386: Suppress coverity warning on fsave/frstor
Coverity warns that 14 << data32 may overflow with respect to the target_ulong to which it is subsequently added. We know this wasn't true because data32 is in [1,2], but the suggested fix is perfectly fine.
--- target/i386/tcg/fpu_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
target/i386/tcg/fpu_helper.c +2 -2
@@ -2466,7 +2466,7 @@ static void do_fsave(CPUX86State *env, target_ulong ptr, int data32,do_fstenv (env, ptr, data32, retaddr); - ptr += (14 << data32); + ptr += (target_ulong )14 << data32;for (i =0 ; i <8 ; i++) { tmp =ST (i);do_fstt (env, tmp, ptr, retaddr);
@@ -2488,7 +2488,7 @@ static void do_frstor(CPUX86State *env, target_ulong ptr, int data32,int i;do_fldenv (env, ptr, data32, retaddr); - ptr += (14 << data32); + ptr += (target_ulong )14 << data32;for (i =0 ; i <8 ; i++) { tmp =do_fldt (env, ptr, retaddr);
Signature · 1 line
2.25.1
Quoted 25 lines · Richard Henderson
Coverity warns that 14 << data32 may overflow with respect to the
target_ulongto which it is subsequently added. We know this wasn't true because data32 is in [1,2], but the suggested fix is perfectly fine.Fixes Coverity CID 1487135, 1487256Signed-off-by Richard Henderson <[email protected]>--- target/i386/tcg/fpu_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)target/i386/tcg/fpu_helper.c +1
-1@@ -2466,7 +2466,7 @@ static void do_fsave(CPUX86State *env, target_ulong ptr, int data32,do_fstenv (env, ptr, data32, retaddr); - ptr += (14 << data32); + ptr += (target_ulong )14 << data32;for (i =0 ; i <8 ; i++) { tmp =ST (i);do_fstt (env, tmp, ptr, retaddr);
target/i386/tcg/fpu_helper.c static void do_frstor(CPUX86State *env, target_ulong ptr, int data32, · line 2494
Quoted 8 lines
target/i386/tcg/fpu_helper.c +1
-1@@ -2488,7 +2488,7 @@ static void do_frstor(CPUX86State *env, target_ulong ptr, int data32,int i;do_fldenv (env, ptr, data32, retaddr); - ptr += (14 << data32); + ptr += (target_ulong )14 << data32;for (i =0 ; i <8 ; i++) { tmp =do_fldt (env, ptr, retaddr);
Quoted 25 lines · Richard Henderson
Coverity warns that 14 << data32 may overflow with respect to the
target_ulongto which it is subsequently added. We know this wasn't true because data32 is in [1,2], but the suggested fix is perfectly fine.Fixes Coverity CID 1487135, 1487256Signed-off-by Richard Henderson <[email protected]>--- target/i386/tcg/fpu_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)target/i386/tcg/fpu_helper.c +1
-1@@ -2466,7 +2466,7 @@ static void do_fsave(CPUX86State *env, target_ulong ptr, int data32,do_fstenv (env, ptr, data32, retaddr); - ptr += (14 << data32); + ptr += (target_ulong )14 << data32;for (i =0 ; i <8 ; i++) { tmp =ST (i);do_fstt (env, tmp, ptr, retaddr);
target/i386/tcg/fpu_helper.c static void do_frstor(CPUX86State *env, target_ulong ptr, int data32, · line 2494
Quoted 8 lines
target/i386/tcg/fpu_helper.c +1
-1@@ -2488,7 +2488,7 @@ static void do_frstor(CPUX86State *env, target_ulong ptr, int data32,int i;do_fldenv (env, ptr, data32, retaddr); - ptr += (14 << data32); + ptr += (target_ulong )14 << data32;for (i =0 ; i <8 ; i++) { tmp =do_fldt (env, ptr, retaddr);
Queuing to tcg-next.
r~