xlnx-bbram: hw/nvram: Fix Coverity CID 1487233
cover xlnx-bbram: hw/nvram: Fix Coverity CID 1487233
This patch addresses Coverity CID 1487233 by adding the required initialiation of a local variable of type Error *.
Tong Ho (1):
xlnx-bbram: hw/nvram: Fix uninitialized Error *
hw/nvram/xlnx-bbram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 1 line
2.25.1
PATCH 1/1 xlnx-bbram: hw/nvram: Fix uninitialized Error *
This adds required initialization of Error * variable.
Signed-off-by Tong Ho <[email protected]>
--- hw/nvram/xlnx-bbram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
hw/nvram/xlnx-bbram.c +1 -1
@@ -89,7 +89,7 @@ static bool bbram_pgm_enabled(XlnxBBRam *s)static void bbram_bdrv_error (XlnxBBRam *s,int rc,gchar *detail) { -Error *errp; +Error *errp =NULL ;error_setg_errno (&errp, -rc,"%s: BBRAM backstore %s failed." ,blk_name (s->blk), detail);
Signature · 1 line
2.25.1
Re: [PATCH 1/1] xlnx-bbram: hw/nvram: Fix uninitialized Error *
Quoted 3 lines · Tong Ho
This adds required initialization of Error * variable.
Signed-off-by Tong Ho <[email protected]>
Reviewed-by Francisco Iglesias <[email protected]>
Quoted 21 lines
--- hw/nvram/xlnx-bbram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)hw/nvram/xlnx-bbram.c +1
-1@@ -89,7 +89,7 @@ static bool bbram_pgm_enabled(XlnxBBRam *s)static void bbram_bdrv_error (XlnxBBRam *s,int rc,gchar *detail) { -Error *errp; +Error *errp =NULL ;error_setg_errno (&errp, -rc,"%s: BBRAM backstore %s failed." ,blk_name (s->blk), detail);Signature · 1 line
2.25.1
Peter Maydell
AppliedQuoted 9 lines · Tong Ho
This patch addresses Coverity CID 1487233 by adding the required initialiation of a local variable of type Error *.
Tong Ho (1):
xlnx-bbram: hw/nvram: Fix uninitialized Error *hw/nvram/xlnx-bbram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to target-arm.next for 7.0, thanks.
-- PMM