rtla: Don't overwrite existing directory mode
PATCH 1/2 rtla: Don't overwrite existing directory mode
The mode on /usr/bin is often 555 these days,
but make install on rtla overwrites this with 755
Fix this by preserving the current directory if it exists.
--- tools/tracing/rtla/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
tools/tracing/rtla/Makefile +2 -1
@@ -23,6 +23,7 @@ $(call allow-override,LD_SO_CONF_PATH,/etc/ld.so.conf.d/) $(call allow-override,LDCONFIG,ldconfig) INSTALL = install +MKDIR = mkdir FOPTS := -flto=auto -ffat-lto-objects -fexceptions -fstack-protector-strong \ -fasynchronous-unwind-tables -fstack-clash-protection WOPTS := -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -Wno-maybe-uninitialized
@@ -68,7 +69,7 @@ static: $(OBJ) .PHONY: install install: doc_install - $(INSTALL) -d -m 755 $(DESTDIR)$(BINDIR) + $(MKDIR) -p $(DESTDIR)$(BINDIR) $(INSTALL) rtla -m 755 $(DESTDIR)$(BINDIR) $(STRIP) $(DESTDIR)$(BINDIR)/rtla @test ! -f $(DESTDIR)$(BINDIR)/osnoise || rm $(DESTDIR)$(BINDIR)/osnoise
Signature · 1 line
2.31.1
PATCH 2/2 rtla: Minor fix to grammar in README.txt
"The rtla" doesn't make sense, change it to "The rtla tool" This is better than removing the word "The" since some packaging tools need the description to start with a capital letter.
--- tools/tracing/rtla/README.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/tracing/rtla/README.txt +1 -1
@@ -1,6 +1,6 @@ RTLA: Real-Time Linux Analysis tools -The rtla is a meta-tool that includes a set of commands that +The rtla tool is a meta-tool that includes a set of commands that aims to analyze the real-time properties of Linux. But, instead of testing Linux as a black box, rtla leverages kernel tracing capabilities to provide precise information about the properties
Signature · 1 line
2.31.1
Re: [PATCH 2/2] rtla: Minor fix to grammar in README.txt
Quoted 14 lines · John Kacur
"The rtla" doesn't make sense, change it to "The rtla tool" This is better than removing the word "The" since some packaging tools need the description to start with a capital letter.
Signed-off-by John Kacur <[email protected]>--- tools/tracing/rtla/README.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/tracing/rtla/README.txt +0
-0
tools/tracing/rtla/README.txt line 3
Quoted 4 lines
tools/tracing/rtla/README.txt +1
-1@@ -1,6 +1,6 @@ RTLA: Real-Time Linux Analysis tools -The rtla is a meta-tool that includes a set of commands that +The rtla tool is a meta-tool that includes a set of commands that
I do not like bike-shedding but 'the rtla tool is a meta-tool" sounds repetitive.
Does:
The rtla meta-tool includes a set of commands...
sound good for you?
-- Daniel
Re: [PATCH 2/2] rtla: Minor fix to grammar in README.txt
Quoted 22 lines · Daniel Bristot de Oliveira
Quoted 14 lines · John Kacur
"The rtla" doesn't make sense, change it to "The rtla tool" This is better than removing the word "The" since some packaging tools need the description to start with a capital letter.
Signed-off-by John Kacur <[email protected]>--- tools/tracing/rtla/README.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/tracing/rtla/README.txt +0
-0tools/tracing/rtla/README.txt line 3
Quoted 4 lines
tools/tracing/rtla/README.txt +1
-1@@ -1,6 +1,6 @@ RTLA: Real-Time Linux Analysis tools -The rtla is a meta-tool that includes a set of commands that +The rtla tool is a meta-tool that includes a set of commands thatI do not like bike-shedding but 'the rtla tool is a meta-tool" sounds repetitive.
Quoted 9 lines
Does:
The rtla meta-tool includes a set of commands...
sound good for you?
-- Daniel
Perfect
Re: [PATCH 2/2] rtla: Minor fix to grammar in README.txt
Quoted 7 lines
Quoted 7 lines
tools/tracing/rtla/README.txt line 3
Quoted 3 lines
tools/tracing/rtla/README.txt +1
-1-The rtla is a meta-tool that includes a set of commands that +The rtla tool is a meta-tool that includes a set of commands thatI do not like bike-shedding but 'the rtla tool is a meta-tool" sounds repetitive.
Does:
Quoted 9 lines
Quoted 7 lines
The rtla meta-tool includes a set of commands...
sound good for you?
-- Daniel
Perfect
Would you mind re-sending this patch?
You will also need to adjust the paragraph alignment as the first line is shorter now ...
-- Daniel
Quoted 6 lines · John Kacur
The mode on
/usr/binis often 555 these days,
but make install on rtla overwrites this with 755Fix this by preserving the current directory if it exists.
Signed-off-by John Kacur <[email protected]>
Thanks!
-- Daniel