staging: sm750fb: Call iounmap() to free mapped bus memory
PATCH 1/1 staging: sm750fb: Call iounmap() to free mapped bus memory
If ioremap_wc() fails, the code jumps to the "exit" label and forgets to free the bus memory mapped into "sm750_dev->pvReg". Mapped bus memory must always be freed by calling iounmap().
Call iounmap(sm750_dev->pvReg) when the above-mentioned failures happen.
The site of the missing iounmap() has been detected by Smatch.
Signed-off-by Fabio M. De Francesco <[email protected]>
--- drivers/staging/sm750fb/sm750_hw.c | 1 + 1 file changed, 1 insertion(+)
drivers/staging/sm750fb/sm750_hw.c +1 -0
@@ -81,6 +81,7 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev) sm750_dev->pvMem =ioremap_wc (sm750_dev->vidmem_start, sm750_dev->vidmem_size);if (!sm750_dev->pvMem) { +iounmap (sm750_dev->pvReg);pr_err ("Map video memory failed\n" ); ret = -EFAULT ; goto exit;
Signature · 1 line
2.34.1