Skip to contentSkip to conversation

drm: bridge: icn6211: Convert to regmap

PATCH In review Marek Vasut 2 participants 3 messages Apr 3, 2022 – Apr 13, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm: bridge: icn6211: Convert to regmap

To make debugging easier, convert driver to regmap. Implement read and write regmap tables for known registers, keep all known register readable and mark those which are obviously read-only as not writeable.

Use common I2C regmap for the I2C configuration, implement custom regmap bus for DSI configuration. The later is mandatory as this chip requires one extra byte set to read access length between register address and data.

Cc Jagan Teki <[email protected]>
Cc Mark Brown <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Robert Foss <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Thomas Zimmermann <[email protected]>

To: [email protected]

---
 drivers/gpu/drm/bridge/Kconfig           |  1 +
 drivers/gpu/drm/bridge/chipone-icn6211.c | 96 ++++++++++++++++++++++--
 2 files changed, 89 insertions(+), 8 deletions(-)
drivers/gpu/drm/bridge/Kconfig +1 -0
index ee7610c2c1a4d..9d22826dc8545 100644
@@ -32,6 +32,7 @@ config DRM_CHIPONE_ICN6211
 	select DRM_KMS_HELPER
 	select DRM_MIPI_DSI
 	select DRM_PANEL_BRIDGE
+	select REGMAP_I2C
 	help
 	  ICN6211 is MIPI-DSI/RGB Converter bridge from chipone.
 
drivers/gpu/drm/bridge/chipone-icn6211.c +88 -8

136 lines not on this page · raw message

Signature · 1 line
2.35.1
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Marek Vasut

To make debugging easier, convert driver to regmap. Implement read and write regmap tables for known registers, keep all known register readable and mark those which are obviously read-only as not writeable.

#2 lore raw
Quoted 6 lines · Mark Brown
Quoted 3 lines · Marek Vasut

To make debugging easier, convert driver to regmap. Implement read and write regmap tables for known registers, keep all known register readable and mark those which are obviously read-only as not writeable.

If that's OK with everyone, I will apply this soon.