sched/fair: Revise comment about lb decision matrix
PATCH 1/1 sched/fair: Revise comment about lb decision matrix
If busiest group type is group_misfit_task, the local group type must be group_has_spare according to below code in update_sd_pick_busiest():
if (sgs->group_type == group_misfit_task &&
(!capacity_greater(capacity_of(env->dst_cpu), sg->sgc->max_capacity) ||
sds->local_stat.group_type != group_has_spare))
return false;group type imbalanced and overloaded and fully_busy are filtered in here. misfit and asym are filtered before in update_sg_lb_stats(). So, change the decision matrix to:
busiest \ local has_spare fully_busy misfit asym imbalanced overloaded
has_spare nr_idle balanced N/A N/A balanced balanced fully_busy nr_idle nr_idle N/A N/A balanced balanced misfit_task force N/A N/A N/A *N/A* *N/A* asym_packing force force N/A N/A force force imbalanced force force N/A N/A force force overloaded force force N/A N/A force avg_load --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/fair.c +1 -1
@@ -9441,7 +9441,7 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s* busiest \ local has_spare fully_busy misfit asym imbalanced overloaded * has_spare nr_idle balanced N/A N/A balanced balanced * fully_busy nr_idle nr_idle N/A N/A balanced balanced -* misfit_task force N/A N/A N/A force force +* misfit_task force N/A N/A N/A N/A N/A * asym_packing force force N/A N/A force force * imbalanced force force N/A N/A force force * overloaded force force N/A N/A force avg_load
Signature · 1 line
2.35.1
Quoted 29 lines · Tao Zhou
If busiest group type is
group_misfit_task, the local group type must begroup_has_spareaccording to below code inupdate_sd_pick_busiest():if (
sgs->group_type==group_misfit_task&&(!capacity_greater(capacity_of(env->dst_cpu), sg->sgc->max_capacity) || sds->local_stat.group_type != group_has_spare)) return false;group type imbalanced and overloaded and
fully_busyare filtered in here. misfit and asym are filtered before inupdate_sg_lb_stats(). So, change the decision matrix to:busiest \ local
has_sparefully_busymisfit asym imbalanced overloadedhas_spare nr_idle balanced N/A N/A balanced balanced fully_busy nr_idle nr_idle N/A N/A balanced balanced misfit_task force N/A N/A N/A *N/A* *N/A* asym_packing force force N/A N/A force force imbalanced force force N/A N/A force force overloaded force force N/A N/A force avg_load --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/sched/fair.c +0
-0
kernel/sched/fair.c static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s · line 9447
Quoted 8 lines
kernel/sched/fair.c +1
-1@@ -9441,7 +9441,7 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s* busiest \ local has_spare fully_busy misfit asym imbalanced overloaded * has_spare nr_idle balanced N/A N/A balanced balanced * fully_busy nr_idle nr_idle N/A N/A balanced balanced -* misfit_task force N/A N/A N/A force force +* misfit_task force N/A N/A N/A N/A N/A * asym_packing force force N/A N/A force force * imbalanced force force N/A N/A force force * overloaded force force N/A N/A force avg_load
You should put people you find in ./scripts/get_maintainer.pl kernel/sched/fair.c on To/Cc to attract more attention.
Otherwise, LGTM.
Quoted 42 lines · Dietmar Eggemann
Quoted 29 lines · Tao Zhou
If busiest group type is
group_misfit_task, the local group type must begroup_has_spareaccording to below code inupdate_sd_pick_busiest():if (
sgs->group_type==group_misfit_task&&(!capacity_greater(capacity_of(env->dst_cpu), sg->sgc->max_capacity) || sds->local_stat.group_type != group_has_spare)) return false;group type imbalanced and overloaded and
fully_busyare filtered in here. misfit and asym are filtered before inupdate_sg_lb_stats(). So, change the decision matrix to:busiest \ local
has_sparefully_busymisfit asym imbalanced overloadedhas_spare nr_idle balanced N/A N/A balanced balanced fully_busy nr_idle nr_idle N/A N/A balanced balanced misfit_task force N/A N/A N/A *N/A* *N/A* asym_packing force force N/A N/A force force imbalanced force force N/A N/A force force overloaded force force N/A N/A force avg_load --- kernel/sched/fair.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)kernel/sched/fair.c +0
-0kernel/sched/fair.c static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s · line 9447
Quoted 8 lines
kernel/sched/fair.c +1
-1@@ -9441,7 +9441,7 @@ static inline void calculate_imbalance(struct lb_env *env, struct sd_lb_stats *s* busiest \ local has_spare fully_busy misfit asym imbalanced overloaded * has_spare nr_idle balanced N/A N/A balanced balanced * fully_busy nr_idle nr_idle N/A N/A balanced balanced -* misfit_task force N/A N/A N/A force force +* misfit_task force N/A N/A N/A N/A N/A * asym_packing force force N/A N/A force force * imbalanced force force N/A N/A force force * overloaded force force N/A N/A force avg_load You should put people you find in
./scripts/get_maintainer.pl kernel/sched/fair.con To/Cc to attract more attention.
Quoted 3 lines
Otherwise, LGTM.
Reviewed-by Dietmar Eggemann <[email protected]>
I will send based on latest rc version..
Thanks,
Tao