Skip to contentSkip to conversation

drivers: hwmon: jc42: add HWMON_C_TZ_REGISTER

PATCH Applied Eduardo Valentin 2 participants 4 messages Mar 18, 2022 – Apr 3, 2022 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: hwmon: jc42: add HWMON_C_TZ_REGISTER

Add a thermal zone interface to the devices added under jc42 driver. This way, thermal zones described in device tree can make use of the of nodes of these devices.

Cc Guenter Roeck <[email protected]> (maintainer:JC42.4 TEMPERATURE SENSOR DRIVER)
Cc Jean Delvare <[email protected]> (maintainer:HARDWARE MONITORING)
Cc [email protected] (open list:JC42.4 TEMPERATURE SENSOR DRIVER)
Cc [email protected] (open list)
---
 drivers/hwmon/jc42.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/hwmon/jc42.c +2 -0
index cb347a6bd8d9..f40df2f29d41 100644
@@ -443,6 +443,8 @@ static int jc42_detect(struct i2c_client *client, struct i2c_board_info *info)
 }
 
 static const struct hwmon_channel_info *jc42_info[] = {
+	HWMON_CHANNEL_INFO(chip,
+			   HWMON_C_REGISTER_TZ | HWMON_C_UPDATE_INTERVAL),
 	HWMON_CHANNEL_INFO(temp,
 			   HWMON_T_INPUT | HWMON_T_MIN | HWMON_T_MAX |
 			   HWMON_T_CRIT | HWMON_T_MAX_HYST |
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 5 lines · Eduardo Valentin

Add a thermal zone interface to the devices added under jc42 driver. This way, thermal zones described in device tree can make use of the of nodes of these devices.

Makes sense. I'll apply the patch, but it is a functional change and a bit too risky to include in the upcoming commit window. I'll apply it after the commit window closes.

Thanks,
Guenter

Quoted 24 lines
Cc Guenter Roeck <[email protected]> (maintainer:JC42.4 TEMPERATURE SENSOR DRIVER)
Cc Jean Delvare <[email protected]> (maintainer:HARDWARE MONITORING)
Cc [email protected] (open list:JC42.4 TEMPERATURE SENSOR DRIVER)
Cc [email protected] (open list)
---
  drivers/hwmon/jc42.c | 2 ++
  1 file changed, 2 insertions(+)
drivers/hwmon/jc42.c +2 -0
index cb347a6bd8d9..f40df2f29d41 100644
@@ -443,6 +443,8 @@ static int jc42_detect(struct i2c_client *client, struct i2c_board_info *info)
  }
 
  static const struct hwmon_channel_info *jc42_info[] = {
+	HWMON_CHANNEL_INFO(chip,
+			   HWMON_C_REGISTER_TZ | HWMON_C_UPDATE_INTERVAL),
  	HWMON_CHANNEL_INFO(temp,
  			   HWMON_T_INPUT | HWMON_T_MIN | HWMON_T_MAX |
  			   HWMON_T_CRIT | HWMON_T_MAX_HYST |
#2 lore raw
Quoted 11 lines · Guenter Roeck

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.

Quoted 5 lines · Eduardo Valentin

Add a thermal zone interface to the devices added under jc42 driver. This way, thermal zones described in device tree can make use of the of nodes of these devices.

Quoted 3 lines

Makes sense. I'll apply the patch, but it is a functional change and a bit too risky to include in the upcoming commit window. I'll apply it after the commit window closes.

Thank you Guenter. Yeah, this can go on the next window.

Quoted 29 lines

Thanks,
Guenter

Quoted 24 lines
Cc Guenter Roeck <[email protected]> (maintainer:JC42.4 TEMPERATURE SENSOR DRIVER)
Cc Jean Delvare <[email protected]> (maintainer:HARDWARE MONITORING)
Cc [email protected] (open list:JC42.4 TEMPERATURE SENSOR DRIVER)
Cc [email protected] (open list)
---
  drivers/hwmon/jc42.c | 2 ++
  1 file changed, 2 insertions(+)
drivers/hwmon/jc42.c +2 -0
index cb347a6bd8d9..f40df2f29d41 100644
@@ -443,6 +443,8 @@ static int jc42_detect(struct i2c_client *client, struct i2c_board_info *info)
  }
 
  static const struct hwmon_channel_info *jc42_info[] = {
+     HWMON_CHANNEL_INFO(chip,
+                        HWMON_C_REGISTER_TZ | HWMON_C_UPDATE_INTERVAL),
      HWMON_CHANNEL_INFO(temp,
                         HWMON_T_INPUT | HWMON_T_MIN | HWMON_T_MAX |
                         HWMON_T_CRIT | HWMON_T_MAX_HYST |
Signature · 2 lines
All the best,
Eduardo Valentin
maintainer Applied
#3 lore raw
In reply to Eduardo Valentin
Quoted 4 lines · Eduardo Valentin

Add a thermal zone interface to the devices added under jc42 driver. This way, thermal zones described in device tree can make use of the of nodes of these devices.

Applied to hwmon-next.

Thanks,
Guenter

Quoted 25 lines
Cc Guenter Roeck <[email protected]> (maintainer:JC42.4 TEMPERATURE SENSOR DRIVER)
Cc Jean Delvare <[email protected]> (maintainer:HARDWARE MONITORING)
Cc [email protected] (open list:JC42.4 TEMPERATURE SENSOR DRIVER)
Cc [email protected] (open list)
---
 drivers/hwmon/jc42.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/hwmon/jc42.c +2 -0
index cb347a6bd8d9..f40df2f29d41 100644
@@ -443,6 +443,8 @@ static int jc42_detect(struct i2c_client *client, struct i2c_board_info *info)
 }
 
 static const struct hwmon_channel_info *jc42_info[] = {
+	HWMON_CHANNEL_INFO(chip,
+			   HWMON_C_REGISTER_TZ | HWMON_C_UPDATE_INTERVAL),
 	HWMON_CHANNEL_INFO(temp,
 			   HWMON_T_INPUT | HWMON_T_MIN | HWMON_T_MAX |
 			   HWMON_T_CRIT | HWMON_T_MAX_HYST |