HSI: omap_ssi: Fix refcount leak in ssi_probe
PATCH 1/1 HSI: omap_ssi: Fix refcount leak in ssi_probe
When returning or breaking early from a for_each_available_child_of_node() loop, we need to explicitly call of_node_put() on the child node to possibly release the node.
Fixes b209e047bc74 ("HSI: Introduce OMAP SSI driver")
Signed-off-by Miaoqian Lin <[email protected]>
--- drivers/hsi/controllers/omap_ssi_core.c | 1 + 1 file changed, 1 insertion(+)
drivers/hsi/controllers/omap_ssi_core.c +1 -0
@@ -524,6 +524,7 @@ static int ssi_probe(struct platform_device *pd)if (!childpdev) { err = -ENODEV ;dev_err (&pd->dev,"failed to create ssi controller port\n" ); +of_node_put (child); goto out3; } }
Signature · 1 line
2.17.1
Hi,
Quoted 7 lines · Miaoqian Lin
When returning or breaking early from a
for_each_available_child_of_node()loop, we need to explicitly callof_node_put()on the child node to possibly release the node.Fixes b209e047bc74 ("HSI: Introduce OMAP SSI driver")Signed-off-by Miaoqian Lin <[email protected]>---
Thanks, queued.
-- Sebastian
Quoted 18 lines
drivers/hsi/controllers/omap_ssi_core.c | 1 + 1 file changed, 1 insertion(+)drivers/hsi/controllers/omap_ssi_core.c +1
-0@@ -524,6 +524,7 @@ static int ssi_probe(struct platform_device *pd)if (!childpdev) { err = -ENODEV ;dev_err (&pd->dev,"failed to create ssi controller port\n" ); +of_node_put (child); goto out3; } }Signature · 1 line
2.17.1