ipv6: Fix stats accounting in ip6_pkt_drop
Subsystems (3)
David Ahern
maintainerPATCH 1/1 ipv6: Fix stats accounting in ip6_pkt_drop
VRF devices are the loopbacks for VRFs, and a loopback can not be assigned to a VRF. Accordingly, the condition in ip6_pkt_drop should be '||' not '&&'.
Fixes 1d3fd8a10bed ("vrf: Use orig netdev to count Ip6InNoRoutes and a fresh route lookup when sending dest unreach")
Reported-by Pudak, Filip <[email protected]>
Reported-by Xiao, Jiguang <[email protected]>
Signed-off-by David Ahern <[email protected]>
--- net/ipv6/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv6/route.c +1 -1
@@ -4484,7 +4484,7 @@ static int ip6_pkt_drop(struct sk_buff *skb, u8 code, int ipstats_mib_noroutes)struct inet6_dev *idev;int type; -if (netif_is_l3_master (skb->dev) && +if (netif_is_l3_master (skb->dev) || dst->dev == net->loopback_dev) idev =__in6_dev_get_safely (dev_get_by_index_rcu (net,IP6CB (skb)->iif));else
Signature · 1 line
2.24.3 (Apple Git-128)
This patch was applied to netdev/net.git (master) by Paolo Abeni <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by Paolo Abeni <[email protected]>:
Quoted 10 lines · On Mon, 4 Apr 2022 09:09:08 -0600 you wrote:
VRF devices are the loopbacks for VRFs, and a loopback can not be assigned to a VRF. Accordingly, the condition in
ip6_pkt_dropshould be '||' not '&&'.Fixes 1d3fd8a10bed ("vrf: Use orig netdev to count Ip6InNoRoutes and a fresh route lookup when sending dest unreach")Reported-by Pudak, Filip <[email protected]>Reported-by Xiao, Jiguang <[email protected]>Signed-off-by David Ahern <[email protected]>[...]
Here is the summary with links:
- [net] ipv6: Fix stats accounting in ip6_pkt_drop
https://git.kernel.org/netdev/net/c/1158f79f82d4
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html