Skip to contentSkip to conversation

dt-bindings: display: panel: mipi-dbi-spi: Make width-mm/height-mm mandatory

PATCH In review Marek Vasut 4 participants 7 messages Apr 4, 2022 – Apr 8, 2022

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: display: panel: mipi-dbi-spi: Make width-mm/height-mm mandatory

Make the width-mm/height-mm panel properties mandatory to correctly report the panel dimensions to the OS.

Fixes 2f3468b82db97 ("dt-bindings: display: add bindings for MIPI DBI compatible SPI panels")
Cc Christoph Niedermaier <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Dmitry Osipenko <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Noralf Trønnes <[email protected]>
Cc Rob Herring <[email protected]>
Cc Robert Foss <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Thomas Zimmermann <[email protected]>

To: [email protected]

---
 .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml   | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml +2 -0
index f29789994b180..c2df8d28aaf5f 100644
@@ -83,6 +83,8 @@ properties:
 required:
   - compatible
   - reg
+  - width-mm
+  - height-mm
   - panel-timing
 
 unevaluatedProperties: false
Signature · 1 line
2.35.1
Acked-by on v1 1/1
#1 lore raw

Den 04.04.2022 21.21, skrev Marek Vasut:

Quoted 15 lines

Make the width-mm/height-mm panel properties mandatory to correctly report the panel dimensions to the OS.

Fixes 2f3468b82db97 ("dt-bindings: display: add bindings for MIPI DBI compatible SPI panels")
Cc Christoph Niedermaier <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Dmitry Osipenko <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Noralf Trønnes <[email protected]>
Cc Rob Herring <[email protected]>
Cc Robert Foss <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Thomas Zimmermann <[email protected]>
Quoted 2 lines

To: [email protected]
---

Quoted 16 lines
 .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml   | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml +2 -0
index f29789994b180..c2df8d28aaf5f 100644
@@ -83,6 +83,8 @@ properties:
 required:
   - compatible
   - reg
+  - width-mm
+  - height-mm
   - panel-timing
 
 unevaluatedProperties: false
Reviewed-by on v1 1/1
#2 lore raw
In reply to Marek Vasut

Hi Marek,

Thank you for the patch.

Quoted 15 lines · Marek Vasut

Make the width-mm/height-mm panel properties mandatory to correctly report the panel dimensions to the OS.

Fixes 2f3468b82db97 ("dt-bindings: display: add bindings for MIPI DBI compatible SPI panels")
Cc Christoph Niedermaier <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Dmitry Osipenko <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Noralf Trønnes <[email protected]>
Cc Rob Herring <[email protected]>
Cc Robert Foss <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Thomas Zimmermann <[email protected]>
Quoted 1 line

To: [email protected]

Quoted 17 lines
---
 .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml   | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml +2 -0
index f29789994b180..c2df8d28aaf5f 100644
@@ -83,6 +83,8 @@ properties:
 required:
   - compatible
   - reg
+  - width-mm
+  - height-mm
   - panel-timing
 
 unevaluatedProperties: false
Signature · 3 lines
Regards,

Laurent Pinchart
maintainer Acked-by on v1 1/1
#3 lore raw
In reply to Marek Vasut
Quoted 15 lines · Marek Vasut

Make the width-mm/height-mm panel properties mandatory to correctly report the panel dimensions to the OS.

Fixes 2f3468b82db97 ("dt-bindings: display: add bindings for MIPI DBI compatible SPI panels")
Cc Christoph Niedermaier <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Dmitry Osipenko <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Noralf Trønnes <[email protected]>
Cc Rob Herring <[email protected]>
Cc Robert Foss <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Thomas Zimmermann <[email protected]>
Quoted 5 lines

To: [email protected]

---
 .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml   | 2 ++
 1 file changed, 2 insertions(+)
#4 lore raw
In reply to Marek Vasut

Hi Marek,

I see that you have commit rights so I assume you will be applying this patch.

Noralf.

Den 04.04.2022 21.21, skrev Marek Vasut:

Quoted 33 lines

Make the width-mm/height-mm panel properties mandatory to correctly report the panel dimensions to the OS.

Fixes 2f3468b82db97 ("dt-bindings: display: add bindings for MIPI DBI compatible SPI panels")
Cc Christoph Niedermaier <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Dmitry Osipenko <[email protected]>
Cc Laurent Pinchart <[email protected]>
Cc Noralf Trønnes <[email protected]>
Cc Rob Herring <[email protected]>
Cc Robert Foss <[email protected]>
Cc Sam Ravnborg <[email protected]>
Cc Thomas Zimmermann <[email protected]>

To: [email protected]

---
 .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml   | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml +2 -0
index f29789994b180..c2df8d28aaf5f 100644
@@ -83,6 +83,8 @@ properties:
 required:
   - compatible
   - reg
+  - width-mm
+  - height-mm
   - panel-timing
 
 unevaluatedProperties: false