Skip to contentSkip to conversation

package/opus: fix build with BR2_OPTIMIZE_FAST

PATCH In review Peter Korsgaard 1 participant 2 messages Apr 5, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/opus: fix build with BR2_OPTIMIZE_FAST

Fixes:
http://autobuild.buildroot.net/results/194/1941e194e1f5ad0bc4982ad39c3e34d266bc49c6/

opus requires that it is configured with --enable-float-approx when -ffast-math (BR2_OPTIMIZE_FAST) is used, otherwise it errors out at build time:

celt/arch.h:198:2: error: #error Cannot build libopus with -ffast-math unless FLOAT_APPROX is defined. This could result in crashes on extreme (e.g. NaN) input

---
 package/opus/opus.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/opus/opus.mk +4 -0
index 4f816df477..2fa929c7df 100644
@@ -23,6 +23,10 @@ ifeq ($(BR2_PACKAGE_OPUS_FIXED_POINT),y)
 OPUS_CONF_OPTS += --enable-fixed-point
 endif
 
+ifeq ($(BR2_OPTIMIZE_FAST),y)
+OPUS_CONF_OPTS += --enable-float-approx
+endif
+
 # When we're on ARM, but we don't have ARM instructions (only
 # Thumb-2), disable the usage of assembly as it is not Thumb-ready.
 ifeq ($(BR2_arm)$(BR2_armeb):$(BR2_ARM_CPU_HAS_ARM),y:)
Signature · 6 lines
2.30.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

Fixes:
http://autobuild.buildroot.net/results/194/1941e194e1f5ad0bc4982ad39c3e34d266bc49c6/

opus requires that it is configured with --enable-float-approx when -ffast-math (BR2_OPTIMIZE_FAST) is used, otherwise it errors out at build time:

Quoted 5 lines

celt/arch.h:198:2: error: #error Cannot build libopus with -ffast-math unless FLOAT_APPROX is defined. This could result in crashes on extreme (e.g. NaN) input

Committed, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot