Skip to contentSkip to conversation

hw/ppc/ppc405_boards: Initialize g_autofree pointer

PATCH Applied Bernhard Beschow 3 participants 3 messages Apr 5, 2022 – Apr 20, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 hw/ppc/ppc405_boards: Initialize g_autofree pointer

Resolves the only compiler warning when building a full QEMU under Arch Linux:

Compiling C object libqemu-ppc-softmmu.fa.p/hw_ppc_ppc405_boards.c.o In file included from /usr/include/glib-2.0/glib.h:114,

                   from qemu/include/glib-compat.h:32,
                   from qemu/include/qemu/osdep.h:132,
                   from ../src/hw/ppc/ppc405_boards.c:25:
  ../src/hw/ppc/ppc405_boards.c: In function ‘ref405ep_init’:
  /usr/include/glib-2.0/glib/glib-autocleanups.h:28:3: warning: ‘filename’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     28 |   g_free (*pp);
        |   ^~~~~~~~~~~~
  ../src/hw/ppc/ppc405_boards.c:265:26: note: ‘filename’ was declared here
    265 |         g_autofree char *filename;
        |                          ^~~~~~~~
---
 hw/ppc/ppc405_boards.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
hw/ppc/ppc405_boards.c +2 -2
index 7e1a4ac955..3bed7002d2 100644
@@ -262,13 +262,13 @@ static void ref405ep_init(MachineState *machine)
     /* allocate and load BIOS */
     if (machine->firmware) {
         MemoryRegion *bios = g_new(MemoryRegion, 1);
-        g_autofree char *filename;
+        g_autofree char *filename = qemu_find_file(QEMU_FILE_TYPE_BIOS,
+                                                   machine->firmware);
         long bios_size;
 
         memory_region_init_rom(bios, NULL, "ef405ep.bios", BIOS_SIZE,
                                &error_fatal);
 
-        filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, machine->firmware);
         if (!filename) {
             error_report("Could not find firmware '%s'", machine->firmware);
             exit(1);
Signature · 1 line
2.35.1
Reviewed-by on v2 1/1
#1 lore raw
Quoted 16 lines · Bernhard Beschow

Resolves the only compiler warning when building a full QEMU under Arch Linux:

Compiling C object libqemu-ppc-softmmu.fa.p/hw_ppc_ppc405_boards.c.o In file included from /usr/include/glib-2.0/glib.h:114,

                   from qemu/include/glib-compat.h:32,
                   from qemu/include/qemu/osdep.h:132,
                   from ../src/hw/ppc/ppc405_boards.c:25:
  ../src/hw/ppc/ppc405_boards.c: In function ‘ref405ep_init’:
  /usr/include/glib-2.0/glib/glib-autocleanups.h:28:3: warning: ‘filename’ may be used uninitialized in this function [-Wmaybe-uninitialized]
     28 |   g_free (*pp);
        |   ^~~~~~~~~~~~
  ../src/hw/ppc/ppc405_boards.c:265:26: note: ‘filename’ was declared here
    265 |         g_autofree char *filename;
        |                          ^~~~~~~~
Quoted 2 lines

---

thanks
-- PMM

#2 lore raw
In reply to Bernhard Beschow

Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,

Daniel

Quoted 40 lines · Bernhard Beschow

Resolves the only compiler warning when building a full QEMU under Arch Linux:

   Compiling C object libqemu-ppc-softmmu.fa.p/hw_ppc_ppc405_boards.c.o
   In file included from /usr/include/glib-2.0/glib.h:114,
                    from qemu/include/glib-compat.h:32,
                    from qemu/include/qemu/osdep.h:132,
                    from ../src/hw/ppc/ppc405_boards.c:25:
   ../src/hw/ppc/ppc405_boards.c: In function ‘ref405ep_init’:
   /usr/include/glib-2.0/glib/glib-autocleanups.h:28:3: warning: ‘filename’ may be used uninitialized in this function [-Wmaybe-uninitialized]
      28 |   g_free (*pp);
         |   ^~~~~~~~~~~~
   ../src/hw/ppc/ppc405_boards.c:265:26: note: ‘filename’ was declared here
     265 |         g_autofree char *filename;
         |                          ^~~~~~~~
---
  hw/ppc/ppc405_boards.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
hw/ppc/ppc405_boards.c +2 -2
index 7e1a4ac955..3bed7002d2 100644
@@ -262,13 +262,13 @@ static void ref405ep_init(MachineState *machine)
      /* allocate and load BIOS */
      if (machine->firmware) {
          MemoryRegion *bios = g_new(MemoryRegion, 1);
-        g_autofree char *filename;
+        g_autofree char *filename = qemu_find_file(QEMU_FILE_TYPE_BIOS,
+                                                   machine->firmware);
          long bios_size;
 
          memory_region_init_rom(bios, NULL, "ef405ep.bios", BIOS_SIZE,
                                 &error_fatal);
 
-        filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, machine->firmware);
          if (!filename) {
              error_report("Could not find firmware '%s'", machine->firmware);
              exit(1);