Skip to contentSkip to conversation

add PSR-SU FFU test case w/ visual confirm

PATCH Superseded David Zhang 3 participants 6 messages Apr 5, 2022 – Apr 6, 2022

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

cover add PSR-SU FFU test case w/ visual confirm

*** BLURB HERE ***
- add interactive option of PSR visual confirm and set TRUE by default
- add a full-frame update (FFU) PSR-SU test case by visual confirm

David Zhang (2):
tests/amdgpu/amd_psr: add interactive option of PSR visual confirm tests/amdgpu/amd_psr: add PSR-SU full frame update sub test case

 tests/amdgpu/amd_psr.c | 169 ++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 167 insertions(+), 2 deletions(-)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/2 tests/amdgpu/amd_psr: add interactive option of PSR visual confirm

[why & how]
AMDGPU DM debugfs provides a debug option of PSR visual confirm, we'd make it an interactive option that provides capability to usermode to choose if or not to enable the PSR visual confirm.

- add interactive option "visual-confirm" and by-default we select it as TRUE to enable visual confirm for PSR-SU test cases.
- set PSR visual confirm debugfs if interactive debug option of visual confirm set before any test run begins, and reset after any test run ends.

Cc Rodrigo Siqueira <[email protected]>
Cc Harry Wentland <[email protected]>
Cc Leo Li <[email protected]>
Cc Jay Pillai <[email protected]>
Cc Wayne Lin <[email protected]>
---
 tests/amdgpu/amd_psr.c | 44 ++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 42 insertions(+), 2 deletions(-)
tests/amdgpu/amd_psr.c +42 -2
index d21d41e3..e70c07cb 100644
@@ -62,6 +62,12 @@ typedef struct data {
 	int h;
 } data_t;
 
+struct {
+	bool visual_confirm;
+} opt = {
+	.visual_confirm = true,	/* visual confirm debug option */
+};
+
 static void draw_color_alpha(igt_fb_t *fb, int x, int y, int w, int h,
 		             double r, double g, double b, double a)
 {
@@ -312,10 +318,31 @@ static void run_check_psr_su_mpo(data_t *data)
 	for (int i = 0; i < N_MPO_TEST_RECT_FB; ++i)
 		igt_remove_fb(data->fd, &rect_fb[i]);
 	test_fini(data);
-	close(data->fd);
 }
 
-igt_main
+const char *help_str =
+"  --visual-confirm           PSR visual confirm debug option enable\n";
+
+struct option long_options[] = {
+	{"visual-confirm",	optional_argument, NULL, 'v'},
+	{ 0, 0, 0, 0 }
+};
+
+static int opt_handler(int option, int option_index, void *data)
+{
+	switch (option) {
+	case 'v':
+		opt.visual_confirm = strtol(optarg, NULL, 0);
+		igt_info(" PSR Visual Confirm %s\n", opt.visual_confirm ? "enabled" : "disabled");
+		break;
+	default:
+		return IGT_OPT_HANDLER_ERROR;
+	}
+
+	return IGT_OPT_HANDLER_SUCCESS;
+}
+
+igt_main_args("", long_options, help_str, opt_handler, NULL)
 {
 	data_t data;
 
@@ -333,6 +360,15 @@ igt_main
 		igt_display_require(&data.display, data.fd);
 		igt_require(&data.display.is_atomic);
 		igt_display_require_output(&data.display);
+
+		/* check if visual confirm option available */
+		if (opt.visual_confirm) {
+			igt_skip_on(!igt_amd_dm_has_visual_confirm(data.fd));
+			igt_skip_on_f(!igt_amd_dm_set_visual_confirm(data.fd, VISUAL_CONFIRM_PSR),
+			      "set PSR visual confirm failed\n");
+			/* double check set to PSR vc */
+			igt_require(igt_amd_dm_get_visual_confirm(data.fd) == VISUAL_CONFIRM_PSR);
+		}
 	}
 
 	igt_describe("Test whether PSR can be enabled with static screen");
@@ -347,6 +383,10 @@ igt_main
 
 	igt_fixture
 	{
+		if (opt.visual_confirm) {
+			igt_amd_dm_set_visual_confirm(data.fd, VISUAL_CONFIRM_DISABLE);
+			igt_require(igt_amd_dm_get_visual_confirm(data.fd) == VISUAL_CONFIRM_DISABLE);
+		}
 		close(data.debugfs_fd);
 		igt_display_fini(&data.display);
 	}
Signature · 1 line
2.25.1
#2 lore raw

Re: [igt-dev] [PATCH 1/2] tests/amdgpu/amd_psr: add interactive option of PSR visual confirm

Quoted 74 lines · David Zhang

[why & how]
AMDGPU DM debugfs provides a debug option of PSR visual confirm, we'd make it an interactive option that provides capability to usermode to choose if or not to enable the PSR visual confirm.

- add interactive option "visual-confirm" and by-default we select it as TRUE to enable visual confirm for PSR-SU test cases.
- set PSR visual confirm debugfs if interactive debug option of visual confirm set before any test run begins, and reset after any test run ends.

Cc Rodrigo Siqueira <[email protected]>
Cc Harry Wentland <[email protected]>
Cc Leo Li <[email protected]>
Cc Jay Pillai <[email protected]>
Cc Wayne Lin <[email protected]>
---
  tests/amdgpu/amd_psr.c | 44 ++++++++++++++++++++++++++++++++++++++++--
  1 file changed, 42 insertions(+), 2 deletions(-)
tests/amdgpu/amd_psr.c +29 -2
index d21d41e3..e70c07cb 100644
@@ -62,6 +62,12 @@ typedef struct data {
  	int h;
  } data_t;
 
+struct {
+	bool visual_confirm;
+} opt = {
+	.visual_confirm = true,	/* visual confirm debug option */
+};
+
  static void draw_color_alpha(igt_fb_t *fb, int x, int y, int w, int h,
  		             double r, double g, double b, double a)
  {
@@ -312,10 +318,31 @@ static void run_check_psr_su_mpo(data_t *data)
  	for (int i = 0; i < N_MPO_TEST_RECT_FB; ++i)
  		igt_remove_fb(data->fd, &rect_fb[i]);
  	test_fini(data);
-	close(data->fd);
  }
 
-igt_main
+const char *help_str =
+"  --visual-confirm           PSR visual confirm debug option enable\n";
+
+struct option long_options[] = {
+	{"visual-confirm",	optional_argument, NULL, 'v'},
+	{ 0, 0, 0, 0 }
+};
+
+static int opt_handler(int option, int option_index, void *data)
+{
+	switch (option) {
+	case 'v':
+		opt.visual_confirm = strtol(optarg, NULL, 0);
+		igt_info(" PSR Visual Confirm %s\n", opt.visual_confirm ? "enabled" : "disabled");
+		break;
+	default:
+		return IGT_OPT_HANDLER_ERROR;
+	}
+
+	return IGT_OPT_HANDLER_SUCCESS;
+}
+
+igt_main_args("", long_options, help_str, opt_handler, NULL)
  {
  	data_t data;
 

tests/amdgpu/amd_psr.c igt_main · line 368

Quoted 9 lines
tests/amdgpu/amd_psr.c +6 -0
@@ -333,6 +360,15 @@ igt_main
  		igt_display_require(&data.display, data.fd);
  		igt_require(&data.display.is_atomic);
  		igt_display_require_output(&data.display);
+
+		/* check if visual confirm option available */
+		if (opt.visual_confirm) {
+			igt_skip_on(!igt_amd_dm_has_visual_confirm(data.fd));
+			igt_skip_on_f(!igt_amd_dm_set_visual_confirm(data.fd, VISUAL_CONFIRM_PSR),
+			      "set PSR visual confirm failed\n");

nit: Align with previous line's opening brace

tests/amdgpu/amd_psr.c igt_main · line 370

Quoted 2 lines
tests/amdgpu/amd_psr.c +2 -0
+			/* double check set to PSR vc */
+			igt_require(igt_amd_dm_get_visual_confirm(data.fd) == VISUAL_CONFIRM_PSR);

Is this required? I would expect set_visual_confirm() to return error if anything unexpected occurs.

tests/amdgpu/amd_psr.c igt_main · line 388

Quoted 11 lines
tests/amdgpu/amd_psr.c +4 -0
+		}
  	}
 
  	igt_describe("Test whether PSR can be enabled with static screen");
@@ -347,6 +383,10 @@ igt_main
 
  	igt_fixture
  	{
+		if (opt.visual_confirm) {
+			igt_amd_dm_set_visual_confirm(data.fd, VISUAL_CONFIRM_DISABLE);
+			igt_require(igt_amd_dm_get_visual_confirm(data.fd) == VISUAL_CONFIRM_DISABLE);

Ditto, could we igt_require(igt_amd_dm_set_visual_confirm(...)); instead?

Thanks,
Leo

Quoted 4 lines
tests/amdgpu/amd_psr.c +1 -0
+		}
  		close(data.debugfs_fd);
  		igt_display_fini(&data.display);
  	}
#3 lore raw

PATCH 2/2 tests/amdgpu/amd_psr: add PSR-SU full frame update sub test case

In reply to David Zhang

[why]
We need a full-frame update (FFU) test case to validate PSR-SU feature enablement by visual confirm.

[how]
1. create two overlay FBs with full screen size and one primary FB w/ 1/4 screen size
2. panning the primary plane to top-left and flip for couple of frames
3. wait for couple of seconds to allow visual confirm
4. panning the primary plane from top-left to middle of screen
5. repeat step 3
6. panning the primary plane from middle to bottom-right of screen
7. repeat step 3

If the PSR-SU is enabled as expected, for FFU we'd observe the visual confirm by seeing the blue border at the bottom of screen and the bottom of primary plane (megenta rectangle) as well.

Cc Rodrigo Siqueira <[email protected]>
Cc Harry Wentland <[email protected]>
Cc Leo Li <[email protected]>
Cc Jay Pillai <[email protected]>
Cc Wayne Lin <[email protected]>
---
 tests/amdgpu/amd_psr.c | 125 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 125 insertions(+)
tests/amdgpu/amd_psr.c +125 -0
index e70c07cb..d976dd17 100644
@@ -54,6 +54,7 @@ typedef struct data {
 	igt_output_t *output;
 	igt_pipe_t *pipe;
 	igt_pipe_crc_t *pipe_crc;
+	igt_fb_t ov_fb[2];
 	drmModeModeInfo *mode;
 	enum pipe pipe_id;
 	int fd;
@@ -320,6 +321,126 @@ static void run_check_psr_su_mpo(data_t *data)
 	test_fini(data);
 }
 
+static void panning_rect_fb(data_t *data, igt_fb_t *rect_fb, int rect_w, int rect_h,
+	int prev_x, int prev_y, int curr_x, int curr_y, double alpha)
+{
+	int ret;
+
+	/* set new position for primary plane */
+	igt_plane_set_position(data->primary, curr_x, curr_y);
+
+	/* flip overlay for couple of frames */
+	igt_info("\n start flipping ...\n");
+	for (int i = 0; i < N_FLIPS; ++i) {
+		igt_info(" About to commit overlay w/ alpha updated in region (x=%d, y=%d, w=%d, h=%d), loop %d \n",
+			 curr_x, curr_y, rect_w, rect_h, i);
+
+		/* update alpha region in overlay for only once and do flip */
+		if (i < 2) {
+			draw_color_alpha(&data->ov_fb[i % 2], prev_x, prev_y, rect_w, rect_h,
+					 1.0, 1.0, 1.0, 1.0);
+			draw_color_alpha(&data->ov_fb[i % 2], curr_x, curr_y, rect_w, rect_h,
+					 (i == 0) ? .0 : 1.0,
+					 (i == 0) ? 1.0 : .0,
+					 1.0, alpha);
+		}
+		igt_plane_set_fb(data->overlay, &data->ov_fb[i % 2]);
+		igt_plane_set_fb(data->primary, rect_fb);
+		igt_plane_set_size(data->primary, rect_w, rect_h);
+		igt_output_set_pipe(data->output, data->pipe_id);
+
+		ret = igt_display_try_commit_atomic(&data->display, DRM_MODE_PAGE_FLIP_EVENT, NULL);
+		igt_require(ret == 0);
+		kmstest_wait_for_pageflip(data->fd);
+	}
+}
+
+static void panning_pfb_and_psrsu_check(data_t *data, igt_fb_t *fb, int fb_w, int fb_h, double alpha)
+{
+	const int pos[4][2] = {
+		{0, 0},
+		{0, 0},
+		{fb_w / 2, fb_h / 2},
+		{fb_w, fb_h}
+	};
+
+	for (int i = 1; i < sizeof(pos) / sizeof(pos[0]); ++i) {
+		/* panning primary rect fb */
+		panning_rect_fb(data, fb, fb_w, fb_h, pos[i - 1][0], pos[i - 1][1], pos[i][0], pos[i][1], alpha);
+
+		/* validate by visual confirm */
+		sleep(5);
+	}
+}
+
+static void run_check_psr_su_ffu(data_t *data)
+{
+	int edp_idx = check_conn_type(data, DRM_MODE_CONNECTOR_eDP);
+	bool sink_support_psrsu = false;
+	bool drv_suport_psrsu = false;
+	igt_fb_t rect_fb; 	// rectangle fbs for primary
+	igt_fb_t ref_fb;	// reference fb
+	int pb_w, pb_h, ob_w, ob_h;
+
+	/* skip the test run if no eDP sink detected */
+	igt_skip_on_f(edp_idx == -1, "no eDP connector found\n");
+
+	/* init */
+	test_init(data);
+	ob_w = data->w;
+	ob_h = data->h;
+	pb_w = data->w / 2;
+	pb_h = data->h / 2;
+
+	/* run the test i.i.f. eDP panel supports and kernel driver both support PSR-SU  */
+	igt_skip_on(!igt_amd_output_has_psr_cap(data->fd, data->output->name));
+	igt_skip_on(!igt_amd_output_has_psr_state(data->fd, data->output->name));
+	sink_support_psrsu = igt_amd_psr_support_sink(data->fd, data->output->name, PSR_MODE_2);
+	igt_skip_on_f(!sink_support_psrsu, "output %s not support PSR-SU\n", data->output->name);
+	drv_suport_psrsu = igt_amd_psr_support_drv(data->fd, data->output->name, PSR_MODE_2);
+	igt_skip_on_f(!drv_suport_psrsu, "kernel driver not support PSR-SU\n");
+
+	/* reference background pattern in grey */
+	igt_create_color_fb(data->fd, data->w, data->h, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
+			    .5, .5, .5, &ref_fb);
+	igt_plane_set_fb(data->primary, &ref_fb);
+	igt_output_set_pipe(data->output, data->pipe_id);
+	igt_display_commit_atomic(&data->display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+
+	/*
+	 * overlay and primary fbs creation
+	 * for full frame update (FFU) test case, we don't change primary FB content but to change
+	 * the position of primary FB (panning) and update the overlay plane alpha region.
+	 * Any overlay change is expected to be regarded as FFU from KMD's perspective.
+	 *
+	 * 1. create two overlay FBs with full screen size and one primary FB w/ 1/4 screen size
+	 * 2. panning the primary plane to top-left and flip for couple of frames
+	 * 3. wait for couple of seconds to allow visual confirm
+	 * 4. panning the primary plane from top-left to middle of screen
+	 * 5. repeat step 3
+	 * 6. panning the primary plane from middle to bottom-right of screen
+	 * 7. repeat step 3
+	 */
+
+	/* step 1 */
+	igt_create_color_fb(data->fd, ob_w, ob_h, DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR,
+			    1.0, 1.0, 1.0, &data->ov_fb[0]);
+	igt_create_color_fb(data->fd, ob_w, ob_h, DRM_FORMAT_ARGB8888, DRM_FORMAT_MOD_LINEAR,
+			    1.0, 1.0, 1.0, &data->ov_fb[1]);
+	igt_create_color_fb(data->fd, pb_w, pb_h, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR,
+			    1.0, .0, 1.0, &rect_fb);
+
+	/* step 2 - 7 */
+	panning_pfb_and_psrsu_check(data, &rect_fb, pb_w, pb_h, .3);
+
+	/* fini */
+	igt_remove_fb(data->fd, &ref_fb);
+	igt_remove_fb(data->fd, &data->ov_fb[0]);
+	igt_remove_fb(data->fd, &data->ov_fb[1]);
+	igt_remove_fb(data->fd, &rect_fb);
+	test_fini(data);
+}
+
 const char *help_str =
 "  --visual-confirm           PSR visual confirm debug option enable\n";
 
@@ -381,6 +502,10 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 		     "and to imitate Multiplane Overlay video playback scenario");
 	igt_subtest("psr_su_mpo") run_check_psr_su_mpo(&data);
 
+	igt_describe("Test to validate PSR SU enablement with Visual Confirm "
+		     "and to validate Full Frame Update scenario");
+	igt_subtest("psr_su_ffu") run_check_psr_su_ffu(&data);
+
 	igt_fixture
 	{
 		if (opt.visual_confirm) {
Signature · 1 line
2.25.1
#4 lore raw

[igt-dev] ✗ Fi.CI.BUILD: failure for add PSR-SU FFU test case w/ visual confirm

In reply to David Zhang
== Series Details ==

== Series Details ==

Series: add PSR-SU FFU test case w/ visual confirm
URL : https://patchwork.freedesktop.org/series/102199/
State : failure

== Summary ==

IGT patchset build failed on latest successful build cc359d5d2d3fc8be50340ba0379bacaf5c37bc5f intel-gpu-top: Add support for per client stats

  if ((expr)) igt_skip_check("!(" #expr ")" , NULL); \
       ^~~~
../tests/amdgpu/amd_psr.c:485:17: warning: nested extern declaration of ‘igt_amd_dm_has_visual_confirm’ [-Wnested-externs]
    igt_skip_on(!igt_amd_dm_has_visual_confirm(data.fd));
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/igt_core.h:1012:7: note: in definition of macro ‘igt_skip_on’
  if ((expr)) igt_skip_check("!(" #expr ")" , NULL); \
       ^~~~
../tests/amdgpu/amd_psr.c:486:19: error: implicit declaration of function ‘igt_amd_dm_set_visual_confirm’ [-Werror=implicit-function-declaration]
    igt_skip_on_f(!igt_amd_dm_set_visual_confirm(data.fd, VISUAL_CONFIRM_PSR),
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/igt_core.h:1062:7: note: in definition of macro ‘igt_skip_on_f’
  if ((expr)) igt_skip_check("!("#expr")", f); \
       ^~~~
../tests/amdgpu/amd_psr.c:486:19: warning: nested extern declaration of ‘igt_amd_dm_set_visual_confirm’ [-Wnested-externs]
    igt_skip_on_f(!igt_amd_dm_set_visual_confirm(data.fd, VISUAL_CONFIRM_PSR),
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/igt_core.h:1062:7: note: in definition of macro ‘igt_skip_on_f’
  if ((expr)) igt_skip_check("!("#expr")", f); \
       ^~~~
../tests/amdgpu/amd_psr.c:486:58: error: ‘VISUAL_CONFIRM_PSR’ undeclared (first use in this function)
    igt_skip_on_f(!igt_amd_dm_set_visual_confirm(data.fd, VISUAL_CONFIRM_PSR),
                                                          ^~~~~~~~~~~~~~~~~~
../lib/igt_core.h:1062:7: note: in definition of macro ‘igt_skip_on_f’
  if ((expr)) igt_skip_check("!("#expr")", f); \
       ^~~~
../tests/amdgpu/amd_psr.c:486:58: note: each undeclared identifier is reported only once for each function it appears in
    igt_skip_on_f(!igt_amd_dm_set_visual_confirm(data.fd, VISUAL_CONFIRM_PSR),
                                                          ^~~~~~~~~~~~~~~~~~
../lib/igt_core.h:1062:7: note: in definition of macro ‘igt_skip_on_f’
  if ((expr)) igt_skip_check("!("#expr")", f); \
       ^~~~
../tests/amdgpu/amd_psr.c:489:16: error: implicit declaration of function ‘igt_amd_dm_get_visual_confirm’ [-Werror=implicit-function-declaration]
    igt_require(igt_amd_dm_get_visual_confirm(data.fd) == VISUAL_CONFIRM_PSR);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/igt_core.h:997:8: note: in definition of macro ‘igt_require’
  if (!(expr)) igt_skip_check(#expr , NULL); \
        ^~~~
../tests/amdgpu/amd_psr.c:489:16: warning: nested extern declaration of ‘igt_amd_dm_get_visual_confirm’ [-Wnested-externs]
    igt_require(igt_amd_dm_get_visual_confirm(data.fd) == VISUAL_CONFIRM_PSR);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/igt_core.h:997:8: note: in definition of macro ‘igt_require’
  if (!(expr)) igt_skip_check(#expr , NULL); \
        ^~~~
../tests/amdgpu/amd_psr.c:510:43: error: ‘VISUAL_CONFIRM_DISABLE’ undeclared (first use in this function); did you mean ‘PIPEACONF_DISABLE’?
    igt_amd_dm_set_visual_confirm(data.fd, VISUAL_CONFIRM_DISABLE);
                                           ^~~~~~~~~~~~~~~~~~~~~~
                                           PIPEACONF_DISABLE

cc1: some warnings being treated as errors
ninja: build stopped: subcommand failed.

#5 lore raw

[igt-dev] ✗ GitLab.Pipeline: warning for add PSR-SU FFU test case w/ visual confirm

In reply to David Zhang
== Series Details ==

== Series Details ==

Series: add PSR-SU FFU test case w/ visual confirm
URL : https://patchwork.freedesktop.org/series/102199/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/551006 for the overview.

build:tests-debian-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/20735649):

    if (!(expr)) igt_skip_check(#expr , NULL); \
          ^~~~
  ../tests/amdgpu/amd_psr.c:489:16: warning: nested extern declaration of ‘igt_amd_dm_get_visual_confirm’ [-Wnested-externs]
      igt_require(igt_amd_dm_get_visual_confirm(data.fd) == VISUAL_CONFIRM_PSR);
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  ../lib/igt_core.h:997:8: note: in definition of macro ‘igt_require’
    if (!(expr)) igt_skip_check(#expr , NULL); \
          ^~~~
  ../tests/amdgpu/amd_psr.c:510:43: error: ‘VISUAL_CONFIRM_DISABLE’ undeclared (first use in this function); did you mean ‘PIPEACONF_DISABLE’?
      igt_amd_dm_set_visual_confirm(data.fd, VISUAL_CONFIRM_DISABLE);
                                             ^~~~~~~~~~~~~~~~~~~~~~
                                             PIPEACONF_DISABLE

cc1: some warnings being treated as errors
ninja: build stopped: subcommand failed. section_end:1649170834:step_script section_start:1649170834:cleanup_file_variables Cleaning up project directory and file based variables section_end:1649170834:cleanup_file_variables
ERROR: Job failed: exit code 1

build:tests-debian-meson-arm64 has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/20735652):

    if (!(expr)) igt_skip_check(#expr , NULL); \
          ^~~~
  ../tests/amdgpu/amd_psr.c:489:16: warning: nested extern declaration of ‘igt_amd_dm_get_visual_confirm’ [-Wnested-externs]
      igt_require(igt_amd_dm_get_visual_confirm(data.fd) == VISUAL_CONFIRM_PSR);
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  ../lib/igt_core.h:997:8: note: in definition of macro ‘igt_require’
    if (!(expr)) igt_skip_check(#expr , NULL); \
          ^~~~
  ../tests/amdgpu/amd_psr.c:510:43: error: ‘VISUAL_CONFIRM_DISABLE’ undeclared (first use in this function); did you mean ‘PIPEACONF_DISABLE’?
      igt_amd_dm_set_visual_confirm(data.fd, VISUAL_CONFIRM_DISABLE);
                                             ^~~~~~~~~~~~~~~~~~~~~~
                                             PIPEACONF_DISABLE

cc1: some warnings being treated as errors
ninja: build stopped: subcommand failed. section_end:1649170800:step_script section_start:1649170800:cleanup_file_variables Cleaning up project directory and file based variables section_end:1649170800:cleanup_file_variables
ERROR: Job failed: exit code 1

build:tests-debian-meson-armhf has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/20735651):

    if (!(expr)) igt_skip_check(#expr , NULL); \
          ^~~~
  ../tests/amdgpu/amd_psr.c:489:16: warning: nested extern declaration of ‘igt_amd_dm_get_visual_confirm’ [-Wnested-externs]
      igt_require(igt_amd_dm_get_visual_confirm(data.fd) == VISUAL_CONFIRM_PSR);
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  ../lib/igt_core.h:997:8: note: in definition of macro ‘igt_require’
    if (!(expr)) igt_skip_check(#expr , NULL); \
          ^~~~
  ../tests/amdgpu/amd_psr.c:510:43: error: ‘VISUAL_CONFIRM_DISABLE’ undeclared (first use in this function); did you mean ‘PIPEACONF_DISABLE’?
      igt_amd_dm_set_visual_confirm(data.fd, VISUAL_CONFIRM_DISABLE);
                                             ^~~~~~~~~~~~~~~~~~~~~~
                                             PIPEACONF_DISABLE

cc1: some warnings being treated as errors
ninja: build stopped: subcommand failed. section_end:1649170856:step_script section_start:1649170856:cleanup_file_variables Cleaning up project directory and file based variables section_end:1649170858:cleanup_file_variables
ERROR: Job failed: exit code 1

build:tests-debian-meson-mips has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/20735653):

    if (!(expr)) igt_skip_check(#expr , NULL); \
          ^~~~
  ../tests/amdgpu/amd_psr.c:489:16: warning: nested extern declaration of ‘igt_amd_dm_get_visual_confirm’ [-Wnested-externs]
      igt_require(igt_amd_dm_get_visual_confirm(data.fd) == VISUAL_CONFIRM_PSR);
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  ../lib/igt_core.h:997:8: note: in definition of macro ‘igt_require’
    if (!(expr)) igt_skip_check(#expr , NULL); \
          ^~~~
  ../tests/amdgpu/amd_psr.c:510:43: error: ‘VISUAL_CONFIRM_DISABLE’ undeclared (first use in this function); did you mean ‘PIPEACONF_DISABLE’?
      igt_amd_dm_set_visual_confirm(data.fd, VISUAL_CONFIRM_DISABLE);
                                             ^~~~~~~~~~~~~~~~~~~~~~
                                             PIPEACONF_DISABLE

cc1: some warnings being treated as errors
ninja: build stopped: subcommand failed. section_end:1649170832:step_script section_start:1649170832:cleanup_file_variables Cleaning up project directory and file based variables section_end:1649170832:cleanup_file_variables
ERROR: Job failed: exit code 1

build:tests-fedora has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/20735644):

    997 |  if (!(expr)) igt_skip_check(#expr , NULL); \
        |        ^~~~
  ../tests/amdgpu/amd_psr.c:489:16: warning: nested extern declaration of ‘igt_amd_dm_get_visual_confirm’ [-Wnested-externs]
    489 |    igt_require(igt_amd_dm_get_visual_confirm(data.fd) == VISUAL_CONFIRM_PSR);
        |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  ../lib/igt_core.h:997:8: note: in definition of macro ‘igt_require’
    997 |  if (!(expr)) igt_skip_check(#expr , NULL); \
        |        ^~~~
  ../tests/amdgpu/amd_psr.c:510:43: error: ‘VISUAL_CONFIRM_DISABLE’ undeclared (first use in this function); did you mean ‘PIPEACONF_DISABLE’?
    510 |    igt_amd_dm_set_visual_confirm(data.fd, VISUAL_CONFIRM_DISABLE);
        |                                           ^~~~~~~~~~~~~~~~~~~~~~
        |                                           PIPEACONF_DISABLE

cc1: some warnings being treated as errors
ninja: build stopped: subcommand failed. section_end:1649170763:step_script section_start:1649170763:cleanup_file_variables Cleaning up project directory and file based variables section_end:1649170764:cleanup_file_variables
ERROR: Job failed: exit code 1

build:tests-fedora-clang has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/20735648):
../tests/amdgpu/amd_psr.c:510:4: error: implicit declaration of function 'igt_amd_dm_set_visual_confirm' is invalid in C99 [-Werror,-Wimplicit-function-declaration]

                          igt_amd_dm_set_visual_confirm(data.fd, VISUAL_CONFIRM_DISABLE);
                          ^
  ../tests/amdgpu/amd_psr.c:510:43: error: use of undeclared identifier 'VISUAL_CONFIRM_DISABLE'
                          igt_amd_dm_set_visual_confirm(data.fd, VISUAL_CONFIRM_DISABLE);
                                                                 ^
  ../tests/amdgpu/amd_psr.c:511:16: error: implicit declaration of function 'igt_amd_dm_get_visual_confirm' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                          igt_require(igt_amd_dm_get_visual_confirm(data.fd) == VISUAL_CONFIRM_DISABLE);
                                      ^
  ../tests/amdgpu/amd_psr.c:511:58: error: use of undeclared identifier 'VISUAL_CONFIRM_DISABLE'
                          igt_require(igt_amd_dm_get_visual_confirm(data.fd) == VISUAL_CONFIRM_DISABLE);
                                                                                ^

1 warning and 9 errors generated.
ninja: build stopped: subcommand failed. section_end:1649170851:step_script section_start:1649170851:cleanup_file_variables Cleaning up project directory and file based variables section_end:1649170853:cleanup_file_variables
ERROR: Job failed: exit code 1

build:tests-fedora-no-libunwind has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/20735645):

    997 |  if (!(expr)) igt_skip_check(#expr , NULL); \
        |        ^~~~
  ../tests/amdgpu/amd_psr.c:489:16: warning: nested extern declaration of ‘igt_amd_dm_get_visual_confirm’ [-Wnested-externs]
    489 |    igt_require(igt_amd_dm_get_visual_confirm(data.fd) == VISUAL_CONFIRM_PSR);
        |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  ../lib/igt_core.h:997:8: note: in definition of macro ‘igt_require’
    997 |  if (!(expr)) igt_skip_check(#expr , NULL); \
        |        ^~~~
  ../tests/amdgpu/amd_psr.c:510:43: error: ‘VISUAL_CONFIRM_DISABLE’ undeclared (first use in this function); did you mean ‘PIPEACONF_DISABLE’?
    510 |    igt_amd_dm_set_visual_confirm(data.fd, VISUAL_CONFIRM_DISABLE);
        |                                           ^~~~~~~~~~~~~~~~~~~~~~
        |                                           PIPEACONF_DISABLE

cc1: some warnings being treated as errors
ninja: build stopped: subcommand failed. section_end:1649170741:step_script section_start:1649170741:cleanup_file_variables Cleaning up project directory and file based variables section_end:1649170741:cleanup_file_variables
ERROR: Job failed: exit code 1

build:tests-fedora-oldest-meson has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/20735646):

    997 |  if (!(expr)) igt_skip_check(#expr , NULL); \
        |        ^~~~
  ../tests/amdgpu/amd_psr.c:489:16: warning: nested extern declaration of ‘igt_amd_dm_get_visual_confirm’ [-Wnested-externs]
    489 |    igt_require(igt_amd_dm_get_visual_confirm(data.fd) == VISUAL_CONFIRM_PSR);
        |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  ../lib/igt_core.h:997:8: note: in definition of macro ‘igt_require’
    997 |  if (!(expr)) igt_skip_check(#expr , NULL); \
        |        ^~~~
  ../tests/amdgpu/amd_psr.c:510:43: error: ‘VISUAL_CONFIRM_DISABLE’ undeclared (first use in this function); did you mean ‘PIPEACONF_DISABLE’?
    510 |    igt_amd_dm_set_visual_confirm(data.fd, VISUAL_CONFIRM_DISABLE);
        |                                           ^~~~~~~~~~~~~~~~~~~~~~
        |                                           PIPEACONF_DISABLE

cc1: some warnings being treated as errors
ninja: build stopped: subcommand failed. section_end:1649170804:step_script section_start:1649170804:cleanup_file_variables Cleaning up project directory and file based variables section_end:1649170805:cleanup_file_variables
ERROR: Job failed: exit code 1

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/551006