staging: rtl8723bs: fix indentation
PATCH v2 1/1 staging: rtl8723bs: fix indentation
Adhere to Linux kernel coding style.
Reported by checkpatch:
WARNING: suspect code indent for conditional statements
---
v1 -> v2: Remove the comments that became irrelevant with proper indentation.
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +3 -11
@@ -5143,17 +5143,9 @@ void link_timer_hdl(struct timer_list *t) }else if (pmlmeinfo->state &WIFI_FW_AUTH_STATE ) {/* re-auth timer */ if (++pmlmeinfo->reauth_count >REAUTH_LIMIT ) { -/* if (pmlmeinfo->auth_algo != dot11AuthAlgrthm_Auto) */ -/* */ - pmlmeinfo->state =0 ; -report_join_res (padapter,-1 ); -return ; -/* */ -/* else */ -/* */ -/* pmlmeinfo->auth_algo = dot11AuthAlgrthm_Shared; */ -/* pmlmeinfo->reauth_count = 0; */ -/* */ + pmlmeinfo->state =0 ; +report_join_res (padapter,-1 ); +return ; } pmlmeinfo->auth_seq =1 ;
Signature · 1 line
2.25.1
Greg Kroah-Hartman
maintainerQuoted 5 lines · Sevinj Aghayeva
Adhere to Linux kernel coding style.
Reported by checkpatch:
WARNING: suspect code indent for conditional statements
You are also removing unneeded comments, right? Please explain that as the documentation link the bot pointed you to showed.
thanks,
greg k-h
Quoted 10 lines · Greg Kroah-Hartman
Quoted 5 lines · Sevinj Aghayeva
Adhere to Linux kernel coding style.
Reported by checkpatch:
WARNING: suspect code indent for conditional statements
You are also removing unneeded comments, right? Please explain that as the documentation link the bot pointed you to showed.
I specified that under the --- line:
v1 -> v2: Remove the comments that became irrelevant with proper indentation.
Quoted 4 lines
thanks,
greg k-h
Signature · 1 line
Sevinj.Aghayeva
Quoted 9 lines · Sevinj Aghayeva
Quoted 6 lines · Greg Kroah-Hartman
Quoted 4 lines · Sevinj Aghayeva
Adhere to Linux kernel coding style.
Reported by checkpatch:
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
WARNING: suspect code indent for conditional statements
You are also removing unneeded comments, right? Please explain that as the documentation link the bot pointed you to showed.
I specified that under the --- line:
v1 -> v2: Remove the comments that became irrelevant with proper indentation.
I think I misunderstood the bot's response. It looks like you triggered it because you wanted me to write a more complete description of what the commit is doing. I thought I received it because it was the second version of the patch from a previous patchset (the last bullet point in the bot response) that didn't include v2 in the subject and a v1 -> v2 after the --- line.
I can do a fresh patch with a complete description and no v2 stuff; please let me know.
Thanks
Quoted 11 lines
Quoted 5 lines
thanks,
greg k-h
--
Sevinj.Aghayeva
Signature · 1 line
Sevinj.Aghayeva
Greg Kroah-Hartman
maintainerQuoted 18 lines · Sevinj Aghayeva
Quoted 16 lines · Sevinj Aghayeva
Quoted 10 lines · Greg Kroah-Hartman
Quoted 5 lines · Sevinj Aghayeva
Adhere to Linux kernel coding style.
Reported by checkpatch:
WARNING: suspect code indent for conditional statements
You are also removing unneeded comments, right? Please explain that as the documentation link the bot pointed you to showed.
I specified that under the --- line:
Quoted 8 lines
Quoted 1 line
v1 -> v2: Remove the comments that became irrelevant with proper indentation.
I think I misunderstood the bot's response. It looks like you triggered it because you wanted me to write a more complete description of what the commit is doing. I thought I received it because it was the second version of the patch from a previous patchset (the last bullet point in the bot response) that didn't include v2 in the subject and a v1 -> v2 after the --- line.
That is one reason, yes, but you also need to update the changelog text to say everything you are doing in the commit.
Quoted 2 lines
I can do a fresh patch with a complete description and no v2 stuff; please let me know.
It will be a v3 patch, right?
thanks,
greg k-h
Quoted 29 lines · Greg Kroah-Hartman
Quoted 18 lines · Sevinj Aghayeva
Quoted 16 lines · Sevinj Aghayeva
Quoted 10 lines · Greg Kroah-Hartman
Quoted 5 lines · Sevinj Aghayeva
Adhere to Linux kernel coding style.
Reported by checkpatch:
WARNING: suspect code indent for conditional statements
You are also removing unneeded comments, right? Please explain that as the documentation link the bot pointed you to showed.
I specified that under the --- line:
Quoted 8 lines
Quoted 1 line
v1 -> v2: Remove the comments that became irrelevant with proper indentation.
I think I misunderstood the bot's response. It looks like you triggered it because you wanted me to write a more complete description of what the commit is doing. I thought I received it because it was the second version of the patch from a previous patchset (the last bullet point in the bot response) that didn't include v2 in the subject and a v1 -> v2 after the --- line.
Quoted 2 lines
That is one reason, yes, but you also need to update the changelog text to say everything you are doing in the commit.
Got it.
Quoted 5 lines
Quoted 3 lines
I can do a fresh patch with a complete description and no v2 stuff; please let me know.
It will be a v3 patch, right?
Right.
Quoted 4 lines
thanks,
greg k-h
Signature · 1 line
Sevinj.Aghayeva