imx8mm-venice-gw7902: update pci refclk
Subsystems (2)
PATCH 1/1 imx8mm-venice-gw7902: update pci refclk
Use the correct PCI clock bindings.
--- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts +3 -3
@@ -595,7 +595,7 @@ &pcie_phy { fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>; fsl,clkreq-unsupported; - clocks = <&clk IMX8MM_CLK_DUMMY>; + clocks = <&pcie0_refclk>; status = "okay"; };
@@ -604,8 +604,8 @@ pinctrl-0 = <&pinctrl_pcie0>; reset-gpio = <&gpio4 5 GPIO_ACTIVE_LOW>; clocks = <&clk IMX8MM_CLK_PCIE1_ROOT>, <&clk IMX8MM_CLK_PCIE1_AUX>, - <&clk IMX8MM_CLK_DUMMY>, <&pcie0_refclk>; - clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus"; + <&pcie0_refclk>; + clock-names = "pcie", "pcie_aux", "pcie_bus"; assigned-clocks = <&clk IMX8MM_CLK_PCIE1_AUX>, <&clk IMX8MM_CLK_PCIE1_CTRL>; assigned-clock-rates = <10000000>, <250000000>;
Signature · 7 lines
2.17.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 1 line · Tim Harvey
Use the correct PCI clock bindings.
Please improve the commit log to explain why clock "pcie_phy" can be dropped.
Shawn
Quoted 33 lines
Signed-off-by Tim Harvey <[email protected]>--- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts +3
-3@@ -595,7 +595,7 @@ &pcie_phy { fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>; fsl,clkreq-unsupported; - clocks = <&clk IMX8MM_CLK_DUMMY>; + clocks = <&pcie0_refclk>; status = "okay"; };@@ -604,8 +604,8 @@ pinctrl-0 = <&pinctrl_pcie0>; reset-gpio = <&gpio4 5 GPIO_ACTIVE_LOW>; clocks = <&clk IMX8MM_CLK_PCIE1_ROOT>, <&clk IMX8MM_CLK_PCIE1_AUX>, - <&clk IMX8MM_CLK_DUMMY>, <&pcie0_refclk>; - clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus"; + <&pcie0_refclk>; + clock-names = "pcie", "pcie_aux", "pcie_bus"; assigned-clocks = <&clk IMX8MM_CLK_PCIE1_AUX>, <&clk IMX8MM_CLK_PCIE1_CTRL>; assigned-clock-rates = <10000000>, <250000000>;Signature · 1 line
2.17.1
Quoted 7 lines · Shawn Guo
Quoted 1 line · Tim Harvey
Use the correct PCI clock bindings.
Please improve the commit log to explain why clock "
pcie_phy" can be dropped.
Shawn,
The original PCIe bindings for this board were wrong - they were from a version of the bindings that was not yet approved (my mistake) and I'm just trying to bring them up to date.
That said, I looked at the latest fsl,imx6q-pcie.yaml dt-bindings [1] and see that there should be a min of 3 clocks called 'pcie', 'pcie_bus', and 'pcie_phy'. However I notice that all of the current imx8mm boards that enable PCI have clock-names of 'pcie', 'pcie_aux', and 'pcie_bus'. It seems like all the imx8mm boards having pcie have clock-names this way:
arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsi arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi arch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dts arch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsi arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts arch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts
Does the binding need to change or do the clock names need to change in the above?
Best Regards,
Tim
[1]
Quoted 35 lines
Shawn
Quoted 33 lines
Signed-off-by Tim Harvey <[email protected]>--- arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts +3
-4@@ -595,7 +595,7 @@ &pcie_phy { fsl,refclk-pad-mode = <IMX8_PCIE_REFCLK_PAD_INPUT>; fsl,clkreq-unsupported; - clocks = <&clk IMX8MM_CLK_DUMMY>; + clocks = <&pcie0_refclk>; status = "okay"; };@@ -604,8 +604,8 @@ pinctrl-0 = <&pinctrl_pcie0>; reset-gpio = <&gpio4 5 GPIO_ACTIVE_LOW>; clocks = <&clk IMX8MM_CLK_PCIE1_ROOT>, <&clk IMX8MM_CLK_PCIE1_AUX>, - <&clk IMX8MM_CLK_DUMMY>, <&pcie0_refclk>; - clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus"; + <&pcie0_refclk>; + clock-names = "pcie", "pcie_aux", "pcie_bus"; assigned-clocks = <&clk IMX8MM_CLK_PCIE1_AUX>, <&clk IMX8MM_CLK_PCIE1_CTRL>; assigned-clock-rates = <10000000>, <250000000>; --2.17.1
Quoted 32 lines · Tim Harvey
Quoted 7 lines · Shawn Guo
Quoted 1 line · Tim Harvey
Use the correct PCI clock bindings.
Please improve the commit log to explain why clock "
pcie_phy" can be dropped.Shawn,
The original PCIe bindings for this board were wrong - they were from a version of the bindings that was not yet approved (my mistake) and I'm just trying to bring them up to date.
That said, I looked at the latest fsl,imx6q-pcie.yaml dt-bindings [1] and see that there should be a min of 3 clocks called 'pcie', '
pcie_bus', and 'pcie_phy'. However I notice that all of the current imx8mm boards that enable PCI have clock-names of 'pcie', 'pcie_aux', and 'pcie_bus'. It seems like all the imx8mm boards having pcie have clock-names this way:
arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsiarch/arm64/boot/dts/freescale/imx8mm-evk.dtsiarch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtsarch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsiarch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsiarch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsiarch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtsarch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtsarch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts
Quoted 2 lines
Does the binding need to change or do the clock names need to change in the above?
If the bindings is approved/correct, device tree should match bindings.
Shawn
Quoted 34 lines · Shawn Guo
Quoted 32 lines · Tim Harvey
Quoted 7 lines · Shawn Guo
Quoted 1 line · Tim Harvey
Use the correct PCI clock bindings.
Please improve the commit log to explain why clock "
pcie_phy" can be dropped.Shawn,
The original PCIe bindings for this board were wrong - they were from a version of the bindings that was not yet approved (my mistake) and I'm just trying to bring them up to date.
That said, I looked at the latest fsl,imx6q-pcie.yaml dt-bindings [1] and see that there should be a min of 3 clocks called 'pcie', '
pcie_bus', and 'pcie_phy'. However I notice that all of the current imx8mm boards that enable PCI have clock-names of 'pcie', 'pcie_aux', and 'pcie_bus'. It seems like all the imx8mm boards having pcie have clock-names this way:
arch/arm64/boot/dts/freescale/imx8mm-beacon-baseboard.dtsiarch/arm64/boot/dts/freescale/imx8mm-evk.dtsiarch/arm64/boot/dts/freescale/imx8mm-tqma8mqml-mba8mx.dtsarch/arm64/boot/dts/freescale/imx8mm-venice-gw71xx.dtsiarch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsiarch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsiarch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dtsarch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dtsarch/arm64/boot/dts/freescale/imx8mm-venice-gw7903.dts
Quoted 5 lines
Quoted 2 lines
Does the binding need to change or do the clock names need to change in the above?
If the bindings is approved/correct, device tree should match bindings.
Shawn,
I think the bindings are wrong.
Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml has [1]:
clocks:
minItems: 3
items:
- description: PCIe bridge clock.
- description: PCIe bus clock.
- description: PCIe PHY clock.
- description: Additional required clock entry for imx6sx-pcie, imx8mq-pcie.
clock-names:
minItems: 3
items:
- const: pcie
- const: pcie_bus
- const: pcie_phy
- const: pcie_inbound_axi for imx6sx-pcie, pcie_aux for imx8mq-pcie
This indicates the "pcie_phy" clock is required yet drivers/pci/controller/dwc/pci-imx6.c [2] doesn't require it if it has an abstract PHY driver which is the case for IMX8M (and that's why my patch drops it)
Additionally I note that the 4th clock described in the bindings could use some clarification for imx8mm-pcie as for this "pcie_aux" is required.
Best Regards,
Tim
[1] https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
[2] https://elixir.bootlin.com/linux/v5.18-rc4/source/drivers/pci/controller/dwc/pci-imx6.c#L1140