Skip to contentSkip to conversation

package/spidev_test: fix version determination (SPI_TX_OCTAL support needs linux headers >= 5.8)

PATCH Applied Peter Seiderer 2 participants 2 messages Apr 5, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/spidev_test: fix version determination (SPI_TX_OCTAL support needs linux headers >= 5.8)

Fixes:

- http://autobuild.buildroot.net/results/a5c008aaff40f4851ffa36439c7340b6243a4842

.../build/spidev_test-5.8/spidev_test.c:132:13: error: 'SPI_TX_OCTAL' undeclared (first use in this function); did you mean 'SPI_TX_DUAL'?

    132 |  if (mode & SPI_TX_OCTAL)
        |             ^~~~~~~~~~~~
        |             SPI_TX_DUAL
---
 package/spidev_test/Config.in      | 2 +-
 package/spidev_test/spidev_test.mk | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/spidev_test/Config.in +1 -1
index 81386adf7a..abfa885b73 100644
@@ -9,7 +9,7 @@ config BR2_PACKAGE_SPIDEV_TEST
 	  proper operation of 'spidev_test'.
 
 	  The version used is based on your toolchain headers version,
-	  if it's older than 3.15 then 3.0 is used, up to headers 4.20
+	  if it's older than 3.15 then 3.0 is used, up to headers 5.7
 	  version 4.10 is used and otherwise version 5.8.
 	  This means you won't have quad-pumped SPI support if your
 	  toolchain is too old.
package/spidev_test/spidev_test.mk +1 -1
index 6c5a9495a4..bd138b0142 100644
@@ -10,7 +10,7 @@
 # If you need quad-pumped spi support you need to upgrade your toolchain.
 # Note that the location of spidev_test.c changes from v4.5 onwards.
 
-ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_0),y)
+ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_8),y)
 SPIDEV_TEST_VERSION = 5.8
 SPIDEV_TEST_PATH = tools/spi
 else ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_15),y)
Signature · 6 lines
2.35.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

Peter, All,

On 2022-04-05 22:42 +0200, Peter Seiderer spake thusly:

Quoted 10 lines

Fixes:

- http://autobuild.buildroot.net/results/a5c008aaff40f4851ffa36439c7340b6243a4842

.../build/spidev_test-5.8/spidev_test.c:132:13: error: 'SPI_TX_OCTAL' undeclared (first use in this function); did you mean 'SPI_TX_DUAL'?

    132 |  if (mode & SPI_TX_OCTAL)
        |             ^~~~~~~~~~~~
        |             SPI_TX_DUAL

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 38 lines
---
 package/spidev_test/Config.in      | 2 +-
 package/spidev_test/spidev_test.mk | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/spidev_test/Config.in +1 -1
index 81386adf7a..abfa885b73 100644
@@ -9,7 +9,7 @@ config BR2_PACKAGE_SPIDEV_TEST
 	  proper operation of 'spidev_test'.
 
 	  The version used is based on your toolchain headers version,
-	  if it's older than 3.15 then 3.0 is used, up to headers 4.20
+	  if it's older than 3.15 then 3.0 is used, up to headers 5.7
 	  version 4.10 is used and otherwise version 5.8.
 	  This means you won't have quad-pumped SPI support if your
 	  toolchain is too old.
package/spidev_test/spidev_test.mk +1 -1
index 6c5a9495a4..bd138b0142 100644
@@ -10,7 +10,7 @@
 # If you need quad-pumped spi support you need to upgrade your toolchain.
 # Note that the location of spidev_test.c changes from v4.5 onwards.
 
-ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_0),y)
+ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_8),y)
 SPIDEV_TEST_VERSION = 5.8
 SPIDEV_TEST_PATH = tools/spi
 else ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_15),y)
Signature · 6 lines
2.35.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot