Skip to contentSkip to conversation

net: wan: remove the lanmedia (lmc) driver

PATCH Applied Jakub Kicinski 5 participants 5 messages Apr 6, 2022

Subsystems (3)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 net: wan: remove the lanmedia (lmc) driver

The driver for LAN Media WAN interfaces spews build warnings on microblaze. The virt_to_bus() calls discard the volatile keyword. The right thing to do would be to migrate this driver to a modern DMA API but it seems unlikely anyone is actually using it. There had been no fixes or functional changes here since the git era begun.

Let's remove this driver, there isn't much changing in the APIs, if users come forward we can apologize and revert.

---
CC: Krzysztof Hałasa <[email protected]>
CC: Andrew Stanley-Jones <[email protected]>
CC: Rob Braun <[email protected]>
CC: Michael Graff <[email protected]>,
CC: Matt Thomas <[email protected]>
CC: Arnd Bergmann <[email protected]>
CC: [email protected] # MIPS
CC: [email protected]
CC: [email protected]

---
 arch/mips/configs/gpr_defconfig  |    1 -
 arch/mips/configs/mtx1_defconfig |    1 -
 drivers/net/wan/Kconfig          |   28 -
 drivers/net/wan/Makefile         |    2 -
 drivers/net/wan/lmc/Makefile     |   18 -
 drivers/net/wan/lmc/lmc.h        |   33 -
 drivers/net/wan/lmc/lmc_debug.c  |   65 -
 drivers/net/wan/lmc/lmc_debug.h  |   52 -
 drivers/net/wan/lmc/lmc_ioctl.h  |  255 ----
 drivers/net/wan/lmc/lmc_main.c   | 2009 ------------------------------
 drivers/net/wan/lmc/lmc_media.c  | 1206 ------------------
 drivers/net/wan/lmc/lmc_proto.c  |  106 --
 drivers/net/wan/lmc/lmc_proto.h  |   18 -
 drivers/net/wan/lmc/lmc_var.h    |  468 -------
 14 files changed, 4262 deletions(-)
 delete mode 100644 drivers/net/wan/lmc/Makefile
 delete mode 100644 drivers/net/wan/lmc/lmc.h
 delete mode 100644 drivers/net/wan/lmc/lmc_debug.c
 delete mode 100644 drivers/net/wan/lmc/lmc_debug.h
 delete mode 100644 drivers/net/wan/lmc/lmc_ioctl.h
 delete mode 100644 drivers/net/wan/lmc/lmc_main.c
 delete mode 100644 drivers/net/wan/lmc/lmc_media.c
 delete mode 100644 drivers/net/wan/lmc/lmc_proto.c
 delete mode 100644 drivers/net/wan/lmc/lmc_proto.h
 delete mode 100644 drivers/net/wan/lmc/lmc_var.h
arch/mips/configs/gpr_defconfig +0 -1
index 5cb91509bb7c..f86838bcae4c 100644
@@ -214,7 +214,6 @@ CONFIG_ATH_DEBUG=y
 CONFIG_ATH5K=y
 CONFIG_ATH5K_DEBUG=y
 CONFIG_WAN=y
-CONFIG_LANMEDIA=m
 CONFIG_HDLC=m
 CONFIG_HDLC_RAW=m
 CONFIG_HDLC_RAW_ETH=m
arch/mips/configs/mtx1_defconfig +0 -1
index 205d3b34528c..eb0b313a2109 100644
@@ -363,7 +363,6 @@ CONFIG_USB_AN2720=y
 CONFIG_USB_EPSON2888=y
 CONFIG_USB_SIERRA_NET=m
 CONFIG_WAN=y
-CONFIG_LANMEDIA=m
 CONFIG_HDLC=m
 CONFIG_HDLC_RAW=m
 CONFIG_HDLC_RAW_ETH=m
drivers/net/wan/Kconfig +0 -28
index 140780ac1745..588b2333cdb8 100644
@@ -57,34 +57,6 @@ config COSA
 	  The driver will be compiled as a module: the
 	  module will be called cosa.
 
-#
-# Lan Media's board. Currently 1000, 1200, 5200, 5245
-#
-config LANMEDIA
-	tristate "LanMedia Corp. SSI/V.35, T1/E1, HSSI, T3 boards"
-	depends on PCI && VIRT_TO_BUS && HDLC
-	help
-	  Driver for the following Lan Media family of serial boards:
-
-	  - LMC 1000 board allows you to connect synchronous serial devices
-	  (for example base-band modems, or any other device with the X.21,
-	  V.24, V.35 or V.36 interface) to your Linux box.
-
-	  - LMC 1200 with on board DSU board allows you to connect your Linux
-	  box directly to a T1 or E1 circuit.
-
-	  - LMC 5200 board provides a HSSI interface capable of running up to
-	  52 Mbits per second.
-
-	  - LMC 5245 board connects directly to a T3 circuit saving the
-	  additional external hardware.
-
-	  To change setting such as clock source you will need lmcctl.
-	  It is available at <ftp://ftp.lanmedia.com/> (broken link).
-
-	  To compile this driver as a module, choose M here: the
-	  module will be called lmc.
-
 # There is no way to detect a Sealevel board. Force it modular
 config SEALEVEL_4021
 	tristate "Sealevel Systems 4021 support"
drivers/net/wan/Makefile +0 -2
index 480bcd1f6c1c..1cd42147b34f 100644
@@ -19,8 +19,6 @@ obj-$(CONFIG_SEALEVEL_4021)	+= z85230.o	sealevel.o
 obj-$(CONFIG_COSA)		+= cosa.o
 obj-$(CONFIG_FARSYNC)		+= farsync.o
 
-obj-$(CONFIG_LANMEDIA)		+= lmc/
-
 obj-$(CONFIG_LAPBETHER)		+= lapbether.o
 obj-$(CONFIG_N2)		+= n2.o
 obj-$(CONFIG_C101)		+= c101.o
drivers/net/wan/lmc/Makefile deleted +0 -18
deleted file mode 100644
index f00fe4491d69..000000000000
@@ -1,18 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0-only
-#
-# Makefile for the Lan Media 21140 based WAN cards
-# Specifically the 1000,1200,5200,5245
-#
-
-obj-$(CONFIG_LANMEDIA) += lmc.o
-
-lmc-objs := lmc_debug.o lmc_media.o lmc_main.o lmc_proto.o
-
-# Like above except every packet gets echoed to KERN_DEBUG
-# in hex
-#
-# DBDEF = \
-# -DDEBUG \
-# -DLMC_PACKET_LOG
-
-ccflags-y := $(DBGDEF)
drivers/net/wan/lmc/lmc.h deleted +0 -33
deleted file mode 100644
index d7d59b4595f9..000000000000
@@ -1,33 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef _LMC_H_
-#define _LMC_H_
-
-#include "lmc_var.h"
-
-/*
- * prototypes for everyone
- */
-int lmc_probe(struct net_device * dev);
-unsigned lmc_mii_readreg(lmc_softc_t * const sc, unsigned
-			  devaddr, unsigned regno);
-void lmc_mii_writereg(lmc_softc_t * const sc, unsigned devaddr,
-			       unsigned regno, unsigned data);
-void lmc_led_on(lmc_softc_t * const, u32);
-void lmc_led_off(lmc_softc_t * const, u32);
-unsigned lmc_mii_readreg(lmc_softc_t * const, unsigned, unsigned);
-void lmc_mii_writereg(lmc_softc_t * const, unsigned, unsigned, unsigned);
-void lmc_gpio_mkinput(lmc_softc_t * const sc, u32 bits);
-void lmc_gpio_mkoutput(lmc_softc_t * const sc, u32 bits);
-
-int lmc_ioctl(struct net_device *dev, struct if_settings *ifs);
-
-extern lmc_media_t lmc_ds3_media;
-extern lmc_media_t lmc_ssi_media;
-extern lmc_media_t lmc_t1_media;
-extern lmc_media_t lmc_hssi_media;
-
-#ifdef _DBG_EVENTLOG
-static void lmcEventLog(u32 EventNum, u32 arg2, u32 arg3);
-#endif
-
-#endif
drivers/net/wan/lmc/lmc_debug.c deleted +0 -65

65 lines not on this page · raw message

drivers/net/wan/lmc/lmc_debug.h deleted +0 -52

52 lines not on this page · raw message

drivers/net/wan/lmc/lmc_ioctl.h deleted +0 -255

255 lines not on this page · raw message

drivers/net/wan/lmc/lmc_main.c deleted +0 -2009

2,009 lines not on this page · raw message

drivers/net/wan/lmc/lmc_media.c deleted +0 -1206

512 lines not on this page · raw message

drivers/net/wan/lmc/lmc_proto.c deleted +0 -106

106 lines not on this page · raw message

drivers/net/wan/lmc/lmc_proto.h deleted +0 -18
deleted file mode 100644
index e56e7072de44..000000000000

Lines of this file are not shown. View the raw message.

drivers/net/wan/lmc/lmc_var.h deleted +0 -468

468 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.34.1

Part of the diff is not shown here. View the raw message.

Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Jakub Kicinski

The driver for LAN Media WAN interfaces spews build warnings on microblaze. The virt_to_bus() calls discard the volatile keyword. The right thing to do would be to migrate this driver to a modern DMA API but it seems unlikely anyone is actually using it. There had been no fixes or functional changes here since the git era begun.

Quoted 5 lines

Let's remove this driver, there isn't much changing in the APIs, if users come forward we can apologize and revert.

maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Jakub Kicinski
Quoted 40 lines · Jakub Kicinski

The driver for LAN Media WAN interfaces spews build warnings on microblaze. The virt_to_bus() calls discard the volatile keyword. The right thing to do would be to migrate this driver to a modern DMA API but it seems unlikely anyone is actually using it. There had been no fixes or functional changes here since the git era begun.

Let's remove this driver, there isn't much changing in the APIs, if users come forward we can apologize and revert.

---
CC: Krzysztof Hałasa <[email protected]>
CC: Andrew Stanley-Jones <[email protected]>
CC: Rob Braun <[email protected]>
CC: Michael Graff <[email protected]>,
CC: Matt Thomas <[email protected]>
CC: Arnd Bergmann <[email protected]>
CC: [email protected] # MIPS
CC: [email protected]
CC: [email protected]

---
 arch/mips/configs/gpr_defconfig  |    1 -
 arch/mips/configs/mtx1_defconfig |    1 -
 drivers/net/wan/Kconfig          |   28 -
 drivers/net/wan/Makefile         |    2 -
 drivers/net/wan/lmc/Makefile     |   18 -
 drivers/net/wan/lmc/lmc.h        |   33 -
 drivers/net/wan/lmc/lmc_debug.c  |   65 -
 drivers/net/wan/lmc/lmc_debug.h  |   52 -
 drivers/net/wan/lmc/lmc_ioctl.h  |  255 ----
 drivers/net/wan/lmc/lmc_main.c   | 2009 ------------------------------
 drivers/net/wan/lmc/lmc_media.c  | 1206 ------------------
 drivers/net/wan/lmc/lmc_proto.c  |  106 --
 drivers/net/wan/lmc/lmc_proto.h  |   18 -
 drivers/net/wan/lmc/lmc_var.h    |  468 -------
 14 files changed, 4262 deletions(-)
 delete mode 100644 drivers/net/wan/lmc/Makefile
 delete mode 100644 drivers/net/wan/lmc/lmc.h
Quoted 8 lines
 delete mode 100644 drivers/net/wan/lmc/lmc_debug.c
 delete mode 100644 drivers/net/wan/lmc/lmc_debug.h
 delete mode 100644 drivers/net/wan/lmc/lmc_ioctl.h
 delete mode 100644 drivers/net/wan/lmc/lmc_main.c
 delete mode 100644 drivers/net/wan/lmc/lmc_media.c
 delete mode 100644 drivers/net/wan/lmc/lmc_proto.c
 delete mode 100644 drivers/net/wan/lmc/lmc_proto.h
 delete mode 100644 drivers/net/wan/lmc/lmc_var.h
Signature · 2 lines
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]
Acked-by on v1 1/1
#3 lore raw
In reply to Jakub Kicinski
Quoted 9 lines · Jakub Kicinski

The driver for LAN Media WAN interfaces spews build warnings on microblaze. The virt_to_bus() calls discard the volatile keyword. The right thing to do would be to migrate this driver to a modern DMA API but it seems unlikely anyone is actually using it. There had been no fixes or functional changes here since the git era begun.

Let's remove this driver, there isn't much changing in the APIs, if users come forward we can apologize and revert.

I wouldn't hold my breath, though :-)

Signature · 5 lines
Krzysztof "Chris" Hałasa

Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa
#4 lore raw
In reply to Jakub Kicinski
This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:

Quoted 8 lines · On Tue, 5 Apr 2022 21:15:48 -0700 you wrote:

The driver for LAN Media WAN interfaces spews build warnings on microblaze. The virt_to_bus() calls discard the volatile keyword. The right thing to do would be to migrate this driver to a modern DMA API but it seems unlikely anyone is actually using it. There had been no fixes or functional changes here since the git era begun.

[...]

Here is the summary with links:
- [net-next] net: wan: remove the lanmedia (lmc) driver

    https://git.kernel.org/netdev/net-next/c/a5b116a0fa90

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html