spi: atmel-quadspi: Fix the buswidth adjustment between spi-mem and controller
Subsystems (3)
PATCH v2 1/2 spi: atmel-quadspi: Fix the buswidth adjustment between spi-mem and controller
Use the spi_mem_default_supports_op() core helper in order to take into account the buswidth specified by the user in device tree.
---
v2: amend patch's subject, s/"spi: atmel-quadspi.c:"/"spi: atmel-quadspi:"
drivers/spi/atmel-quadspi.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/spi/atmel-quadspi.c +3 -0
@@ -277,6 +277,9 @@ static int atmel_qspi_find_mode(const struct spi_mem_op *op)static bool atmel_qspi_supports_op (struct spi_mem *mem,const struct spi_mem_op *op) { +if (!spi_mem_default_supports_op (mem, op)) +return false; +if (atmel_qspi_find_mode (op) <0 )return false;
Signature · 7 lines
2.25.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH v2 2/2 spi: atmel-quadspi: Remove duplicated DTR checks
Remove the DTR checks as they are already handled in spi_mem_default_supports_op(). This code removal was intentionally not done in the previous patch that introduced the use of the spi_mem_default_supports_op() core helper and fixed the buswidth adjustment between SPIMEM and the SPI controller, so that the fix can be easily backported to stable kernels.
---
v2: no changes
drivers/spi/atmel-quadspi.c | 6 ------ 1 file changed, 6 deletions(-)
drivers/spi/atmel-quadspi.c +0 -6
@@ -288,12 +288,6 @@ static bool atmel_qspi_supports_op(struct spi_mem *mem, op->dummy.nbytes == 0)return false; -/* DTR ops not supported. */ -if (op->cmd.dtr || op->addr.dtr || op->dummy.dtr || op->data.dtr) -return false; -if (op->cmd.nbytes !=1 ) -return false; -return true; }
Signature · 7 lines
2.25.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Mark Brown
maintainerQuoted 4 lines · Tudor Ambarus
Use the
spi_mem_default_supports_op()core helper in order to take into account the buswidth specified by the user in device tree.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/2] spi: atmel-quadspi: Fix the buswidth adjustment between spi-mem and controller
commit: 8c235cc25087495c4288d94f547e9d3061004991
[2/2] spi: atmel-quadspi: Remove duplicated DTR checks
commit: f4cf11df69c048948b73ff0bebaf9fc5fa5cadddAll being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark