Skip to contentSkip to conversation

qemu-img: properly list formats which have consistency check implemented

PATCH Applied Denis V. Lunev 3 participants 3 messages Apr 7, 2022 – Apr 14, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qemu-img: properly list formats which have consistency check implemented

Simple grep for the .bdrv_co_check callback presence gives the following list of block drivers
* QED
* VDI
* VHDX
* VMDK
* Parallels
which have this callback. The presense of the callback means that consistency check is supported.

The patch updates documentation accordingly.

---
 docs/tools/qemu-img.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
docs/tools/qemu-img.rst +2 -2
index 8885ea11cf..85a6e05b35 100644
@@ -332,8 +332,8 @@ by the used format or see the format descriptions below for details.
   ``-r all`` fixes all kinds of errors, with a higher risk of choosing the
   wrong fix or hiding corruption that has already occurred.
 
-  Only the formats ``qcow2``, ``qed`` and ``vdi`` support
-  consistency checks.
+  Only the formats ``qcow2``, ``qed``, ``parallels``, ``vhdx``, ``vmdk`` and
+  ``vdi`` support consistency checks.
 
   In case the image does not have any inconsistencies, check exits with ``0``.
   Other exit codes indicate the kind of inconsistency found or if another error
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Denis V. Lunev

Simple grep for the .bdrv_co_check callback presence gives the following list of block drivers
* QED
* VDI
* VHDX
* VMDK
* Parallels
which have this callback. The presense of the callback means that consistency check is supported.

Quoted 8 lines

The patch updates documentation accordingly.

---
 docs/tools/qemu-img.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 3 lines
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org
Applied
#2 lore raw
In reply to Denis V. Lunev

Am 07.04.2022 um 10:39 hat Denis V. Lunev geschrieben:

Quoted 10 lines

Simple grep for the .bdrv_co_check callback presence gives the following list of block drivers
* QED
* VDI
* VHDX
* VMDK
* Parallels
which have this callback. The presense of the callback means that consistency check is supported.

Quoted 5 lines

The patch updates documentation accordingly.

Thanks, applied to the block branch.

Kevin