Skip to contentSkip to conversation

kbuild: Generate symbols for DTO application in DTBs

RFC PATCH In review Marek Vasut 2 participants 3 messages Apr 7, 2022 – Apr 10, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 kbuild: Generate symbols for DTO application in DTBs

Emit symbols section in DTBs to permit symbol resolution when applying DTOs.

Cc Masahiro Yamada <[email protected]>

---
NOTE: I am sending this as RFC, because I suspect there is a better way how
to pass extra flags to DTC during kernel build ?
Maybe from shell environment somehow ?
Or maybe b7e70391a5451 ("arm64: tegra: Enable device-tree overlay support") is the way to go about this ?

---
 arch/arm/boot/dts/Makefile   | 3 +++
 arch/arm64/boot/dts/Makefile | 3 +++
 2 files changed, 6 insertions(+)
arch/arm/boot/dts/Makefile +3 -0
index 252353fb4e3b3..2d50302d077dd 100644
@@ -1,4 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
+
+DTC_FLAGS += -@
+
 dtb-$(CONFIG_ARCH_ALPINE) += \
 	alpine-db.dtb
 dtb-$(CONFIG_MACH_ARTPEC6) += \
arch/arm64/boot/dts/Makefile +3 -0
index 1ba04e31a4387..f7b3c86517a0e 100644
@@ -1,4 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
+
+DTC_FLAGS += -@
+
 subdir-y += actions
 subdir-y += allwinner
 subdir-y += altera
Signature · 1 line
2.35.1
#1 lore raw

Hi Marek.
(+CC Rob, DT ML)

Quoted 2 lines · Marek Vasut

Emit symbols section in DTBs to permit symbol resolution when applying DTOs.

I CCed DT folks, but if I remember correctly, adding -@ globally was NACKed because it would increase blob size for platforms that do not need overlay.

Quoted 6 lines
Cc Masahiro Yamada <[email protected]>

---
NOTE: I am sending this as RFC, because I suspect there is a better way how
to pass extra flags to DTC during kernel build ?
Maybe from shell environment somehow ?

For local use, yes, you can add -@ from the command line.

Try this:

DTC_FLAGS=-@ make ARCH=arm64 dtbs

This is undocumented tip, but it seems to work
for the current code.

Quoted 2 lines

Or maybe b7e70391a5451 ("arm64: tegra: Enable device-tree overlay support") is the way to go about this ?

Since commit 15d16d6dadf6947ac7f9a686c615995c5a426ce2, adding -@ is automatic for platforms that support overlay.

If <platform>-dtbs exists, -@ is automatically added.

See arch/arm64/boot/dts/xilinx/Makefile
as an example code.

Quoted 32 lines
---
 arch/arm/boot/dts/Makefile   | 3 +++
 arch/arm64/boot/dts/Makefile | 3 +++
 2 files changed, 6 insertions(+)
arch/arm/boot/dts/Makefile +3 -0
index 252353fb4e3b3..2d50302d077dd 100644
@@ -1,4 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
+
+DTC_FLAGS += -@
+
 dtb-$(CONFIG_ARCH_ALPINE) += \
        alpine-db.dtb
 dtb-$(CONFIG_MACH_ARTPEC6) += \
arch/arm64/boot/dts/Makefile +3 -1
index 1ba04e31a4387..f7b3c86517a0e 100644
@@ -1,4 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0
+
+DTC_FLAGS += -@
+
 subdir-y += actions
 subdir-y += allwinner
 subdir-y += altera
--

2.35.1

Signature · 2 lines
Best Regards
Masahiro Yamada
#2 lore raw
Quoted 2 lines · Masahiro Yamada

Hi Marek.
(+CC Rob, DT ML)

Hi,

Quoted 19 lines · Marek Vasut
Quoted 2 lines

Emit symbols section in DTBs to permit symbol resolution when applying DTOs.

I CCed DT folks, but if I remember correctly, adding -@ globally was NACKed because it would increase blob size for platforms that do not need overlay.

Quoted 6 lines
Cc Masahiro Yamada <[email protected]>

---
NOTE: I am sending this as RFC, because I suspect there is a better way how
to pass extra flags to DTC during kernel build ?
Maybe from shell environment somehow ?

For local use, yes, you can add -@ from the command line.

Quoted 7 lines

Try this:

DTC_FLAGS=-@ make ARCH=arm64 dtbs

This is undocumented tip, but it seems to work
for the current code.

This is real nice (and very much what I need), thank you.

Quoted 4 lines
Quoted 2 lines

Or maybe b7e70391a5451 ("arm64: tegra: Enable device-tree overlay support") is the way to go about this ?

Quoted 8 lines

Since commit 15d16d6dadf6947ac7f9a686c615995c5a426ce2, adding -@ is automatic for platforms that support overlay.

If <platform>-dtbs exists, -@ is automatically added.

See arch/arm64/boot/dts/xilinx/Makefile
as an example code.

Is it now allowed to start upstreaming DT overlays then ? That would be nice too.