rtw89: ser: add a break statement
Subsystems (3)
PATCH 1/1 rtw89: ser: add a break statement
The clang build fails with
ser.c:397:2: error: unannotated fall-through
between switch labels [-Werror,-Wimplicit-fallthrough]
default:
^The case above the default does not have a break.
So add one.
--- drivers/net/wireless/realtek/rtw89/ser.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/wireless/realtek/rtw89/ser.c +1 -0
@@ -394,6 +394,7 @@ static void ser_idle_st_hdl(struct rtw89_ser *ser, u8 evt)break ;case SER_EV_STATE_OUT :rtw89_hci_recovery_start (rtwdev); +break ;default :break ; }
Signature · 1 line
2.27.0
Quoted 9 lines · Tom Rix
The clang build fails with
ser.c:397:2: error: unannotated fall-through
between switch labels [-Werror,-Wimplicit-fallthrough]default: ^The case above the default does not have a break.
So add one.Signed-off-by Tom Rix <[email protected]>
There is also https://lore.kernel.org/r/[email protected]/.
I have been using Documentation/process/deprecated.rst as justification for the extra break, warning aside, as all case statements must end in one of the following:
break
fallthrough
continue
goto
return
Quoted 19 lines
--- drivers/net/wireless/realtek/rtw89/ser.c | 1 + 1 file changed, 1 insertion(+)drivers/net/wireless/realtek/rtw89/ser.c +1
-0@@ -394,6 +394,7 @@ static void ser_idle_st_hdl(struct rtw89_ser *ser, u8 evt)break ;case SER_EV_STATE_OUT :rtw89_hci_recovery_start (rtwdev); +break ;default :break ; }Signature · 1 line
2.27.0
Quoted 10 lines · Tom Rix
The clang build fails with
ser.c:397:2: error: unannotated fall-through
between switch labels [-Werror,-Wimplicit-fallthrough]default: ^The case above the default does not have a break.
So add one.Signed-off-by Tom Rix <[email protected]>Reviewed-by Nathan Chancellor <[email protected]>
I took Zong's version:
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
Patch set to Superseded.
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches