Skip to contentSkip to conversation

wcn36xx: clean up some inconsistent indenting

PATCH In review Yang Li 4 participants 6 messages Apr 8, 2022 – Apr 12, 2022

Subsystems (4)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/2 wcn36xx: clean up some inconsistent indenting

Eliminate the follow smatch warning:
drivers/net/wireless/ath/wcn36xx/smd.c:3151 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting

---
 drivers/net/wireless/ath/wcn36xx/smd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/ath/wcn36xx/smd.c +3 -3
index 872b37875c57..691e637b94f1 100644
@@ -3148,9 +3148,9 @@ static int wcn36xx_smd_gtk_offload_get_info_rsp(struct wcn36xx *wcn,
 			cpu_to_le64(rsp->key_replay_counter);
 		ieee80211_gtk_rekey_notify(vif, vif->bss_conf.bssid,
 					   (void *)&replay_ctr, GFP_KERNEL);
-		 wcn36xx_dbg(WCN36XX_DBG_HAL,
-			     "GTK replay counter increment %llu\n",
-			     rsp->key_replay_counter);
+		wcn36xx_dbg(WCN36XX_DBG_HAL,
+			    "GTK replay counter increment %llu\n",
+			    rsp->key_replay_counter);
 	}
 
 	wcn36xx_dbg(WCN36XX_DBG_HAL,
Signature · 1 line
2.20.1.7.g153144c
author
#1 lore raw

PATCH 2/2 ath9k: Remove unnecessary print function dev_err()

The print function dev_err() is redundant because platform_get_irq_byname() already prints an error.

Eliminate the follow coccicheck warning:
./drivers/net/wireless/ath/ath9k/ahb.c:103:2-9: line 103 is redundant because platform_get_irq() already prints an error

---
 drivers/net/wireless/ath/ath9k/ahb.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/wireless/ath/ath9k/ahb.c +1 -3
index c9b853af41d1..9cd12b20b18d 100644
@@ -99,10 +99,8 @@ static int ath_ahb_probe(struct platform_device *pdev)
 	}
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0) {
-		dev_err(&pdev->dev, "no IRQ resource found\n");
+	if (irq < 0)
 		return irq;
-	}
 
 	ath9k_fill_chanctx_ops();
 	hw = ieee80211_alloc_hw(sizeof(struct ath_softc), &ath9k_ops);
Signature · 1 line
2.20.1.7.g153144c
maintainer Acked-by on v1 2/2
#2 lore raw

Re: [PATCH -next 2/2] ath9k: Remove unnecessary print function dev_err()

Quoted 9 lines · Yang Li

The print function dev_err() is redundant because platform_get_irq_byname() already prints an error.

Eliminate the follow coccicheck warning:
./drivers/net/wireless/ath/ath9k/ahb.c:103:2-9: line 103 is redundant because platform_get_irq() already prints an error

Heh, so I was the one originally insisting on keeping that err print, but looking a bit closer now it does really appear to be redundant, so:

#3 lore raw

Re: [PATCH -next 2/2] ath9k: Remove unnecessary print function dev_err()

In reply to Yang Li
Quoted 11 lines · Yang Li

The print function dev_err() is redundant because platform_get_irq_byname() already prints an error.

Eliminate the follow coccicheck warning:
./drivers/net/wireless/ath/ath9k/ahb.c:103:2-9: line 103 is redundant because platform_get_irq() already prints an error

Patch applied to ath-next branch of ath.git, thanks.

d7ceee8051ba ath9k: Remove unnecessary print function dev_err()

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#5 lore raw
In reply to Yang Li
Quoted 8 lines · Yang Li

Eliminate the follow smatch warning:
drivers/net/wireless/ath/wcn36xx/smd.c:3151 wcn36xx_smd_gtk_offload_get_info_rsp() warn: inconsistent indenting

Patch applied to ath-next branch of ath.git, thanks.

2578171ff85e wcn36xx: clean up some inconsistent indenting

Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches