drm/mediatek: dpi: Use mt8183 output formats for mt8192
Subsystems (3)
PATCH v2 1/1 drm/mediatek: dpi: Use mt8183 output formats for mt8192
The configuration for mt8192 was incorrectly using the output formats from mt8173. Since the output formats for mt8192 are instead the same ones as for mt8183, which require two bus samples per pixel, the pixelclock and DDR edge setting were misconfigured. This made external displays unable to show the image.
Fix the issue by correcting the output format for mt8192 to be the same as for mt8183, fixing the usage of external displays for mt8192.
---
Changes in v2:
- Added Fixes tag
drivers/gpu/drm/mediatek/mtk_dpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/mediatek/mtk_dpi.c +2 -2
@@ -819,8 +819,8 @@ static const struct mtk_dpi_conf mt8192_conf = { .cal_factor = mt8183_calculate_factor, .reg_h_fre_con = 0xe0, .max_clock_khz = 150000, - .output_fmts = mt8173_output_fmts, - .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts), + .output_fmts = mt8183_output_fmts, + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts), };static int mtk_dpi_probe (struct platform_device *pdev)
Signature · 1 line
2.35.1
Il 08/04/22 03:39, Nícolas F. R. A. Prado ha scritto:
Quoted 6 lines
The configuration for mt8192 was incorrectly using the output formats from mt8173. Since the output formats for mt8192 are instead the same ones as for mt8183, which require two bus samples per pixel, the pixelclock and DDR edge setting were misconfigured. This made external displays unable to show the image.
Quoted 6 lines
Fix the issue by correcting the output format for mt8192 to be the same as for mt8183, fixing the usage of external displays for mt8192.
Fixes be63f6e8601f ("drm/mediatek: dpi: Add output bus formats to driver data")Signed-off-by Nícolas F. R. A. Prado <[email protected]>
Lovely!
Quoted 30 lines · Nícolas F. R. A. Prado
The configuration for mt8192 was incorrectly using the output formats from mt8173. Since the output formats for mt8192 are instead the same ones as for mt8183, which require two bus samples per pixel, the pixelclock and DDR edge setting were misconfigured. This made external
displays unable to show the image.Fix the issue by correcting the output format for mt8192 to be the same
as for mt8183, fixing the usage of external displays for mt8192.Fixes be63f6e8601f ("drm/mediatek: dpi: Add output bus formats todriver data")
Signed-off-by Nícolas F. R. A. Prado <[email protected]>Reviewed-by AngeloGioacchino Del Regno <Changes in v2:
- Added Fixes tagdrivers/gpu/drm/mediatek/mtk_dpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/mediatek/mtk_dpi.c +0
-0
drivers/gpu/drm/mediatek/mtk_dpi.c static const struct mtk_dpi_conf mt8192_conf = { · line 826
Quoted 10 lines
drivers/gpu/drm/mediatek/mtk_dpi.c +2
-2@@ -819,8 +819,8 @@ static const struct mtk_dpi_conf mt8192_conf = { .cal_factor = mt8183_calculate_factor, .reg_h_fre_con = 0xe0, .max_clock_khz = 150000, - .output_fmts = mt8173_output_fmts, - .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts), + .output_fmts = mt8183_output_fmts, + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts), };static int mtk_dpi_probe (struct platform_device *pdev)
Hello CK,
Gentle ping for this patch.
This patch is confirmed by Xinlei and Jitao.
BRs,
Rex
CK Hu
AppliedHi,
Quoted 43 lines · Rex-BC Chen
Quoted 42 lines · Nícolas F. R. A. Prado
The configuration for mt8192 was incorrectly using the output formats
from mt8173. Since the output formats for mt8192 are instead the same
ones as for mt8183, which require two bus samples per pixel, the pixelclock and DDR edge setting were misconfigured. This made external
displays unable to show the image.Fix the issue by correcting the output format for mt8192 to be the same
as for mt8183, fixing the usage of external displays for mt8192.Fixes be63f6e8601f ("drm/mediatek: dpi: Add output bus formats todriver data")
Signed-off-by Nícolas F. R. A. Prado <[email protected]>Reviewed-by AngeloGioacchino Del Regno <Changes in v2:
- Added Fixes tagdrivers/gpu/drm/mediatek/mtk_dpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/mediatek/mtk_dpi.c +2
-2@@ -819,8 +819,8 @@ static const struct mtk_dpi_conf mt8192_conf = { .cal_factor = mt8183_calculate_factor, .reg_h_fre_con = 0xe0, .max_clock_khz = 150000, - .output_fmts = mt8173_output_fmts, - .num_output_fmts = ARRAY_SIZE(mt8173_output_fmts), + .output_fmts = mt8183_output_fmts, + .num_output_fmts = ARRAY_SIZE(mt8183_output_fmts), };
Quoted 8 lines
Quoted 1 line
static int
mtk_dpi_probe(struct platform_device *pdev)Reviewed-by Rex-BC Chen <[email protected]>Hello CK,
Gentle ping for this patch.
This patch is confirmed by Xinlei and Jitao.
Applied to mediatek-drm-next [1].
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next
Regards,
CK
Quoted 4 lines
BRs,
Rex